felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-04-20 00:24:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Implemented PSG-680 - Sessions overview security recommendations

Browse Source 
- remove uppercased strings from localizables
- moved inactivity computation to the service
This commit is contained in:
Stefan Ceriu
2022-09-27 16:51:13 +03:00
committed by Stefan Ceriu
parent 6585aaf523
commit 7eee1cceab
20 changed files with 369 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RiotSwiftUI/Modules/UserSessions/Common/View/UserSessionCardView.swift
+4 -3
View File
@@ -136,13 +136,14 @@ struct UserSessionCardViewPreview: View {
let viewData: UserSessionCardViewData
init(isCurrentSessionInfo: Bool = false) {
let session = UserSessionInfo(sessionId: "alice",
sessionName: "iOS",
let session = UserSessionInfo(id: "alice",
name: "iOS",
deviceType: .mobile,
isVerified: false,
lastSeenIP: "10.0.0.10",
lastSeenTimestamp: Date().timeIntervalSince1970 - 100,
isCurrentSession: isCurrentSessionInfo)
isActive: true,
isCurrent: isCurrentSessionInfo)
viewData = UserSessionCardViewData(session: session)
}
RiotSwiftUI/Modules/UserSessions/Common/View/UserSessionCardViewData.swift
+3 -3
View File
@@ -67,12 +67,12 @@ struct UserSessionCardViewData {
extension UserSessionCardViewData {
init(session: UserSessionInfo) {
self.init(sessionId: session.sessionId,
sessionDisplayName: session.sessionName,
self.init(sessionId: session.id,
sessionDisplayName: session.name,
deviceType: session.deviceType,
isVerified: session.isVerified,
lastActivityTimestamp: session.lastSeenTimestamp,
lastSeenIP: session.lastSeenIP,
isCurrentSessionDisplayMode: session.isCurrentSession)
isCurrentSessionDisplayMode: session.isCurrent)
}
}