From 738a43e76ff3d6090fcc677029c8b0e517cbd577 Mon Sep 17 00:00:00 2001 From: manuroe Date: Tue, 21 May 2019 02:12:14 +0200 Subject: [PATCH] Reactions menu: Patch RoomContextualMenuPresenter while we have a retain cycle --- .../Room/ContextualMenu/RoomContextualMenuPresenter.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Riot/Modules/Room/ContextualMenu/RoomContextualMenuPresenter.swift b/Riot/Modules/Room/ContextualMenu/RoomContextualMenuPresenter.swift index 2a4c39a53..fa56d2de5 100644 --- a/Riot/Modules/Room/ContextualMenu/RoomContextualMenuPresenter.swift +++ b/Riot/Modules/Room/ContextualMenu/RoomContextualMenuPresenter.swift @@ -88,6 +88,10 @@ final class RoomContextualMenuPresenter: NSObject { let animationCompletionInstructions: (() -> Void) = { roomContextualMenuViewController.vc_removeFromParent() + + // TODO: To remove once the retain cycle caused by reactionsMenuViewModel is fixed + self.roomContextualMenuViewController = nil + completion?() }