Wrong copy for upgrade room message (#6003)

* Wrong copy for upgrade room message

- fixed
This commit is contained in:
Gil Eluard
2022-04-11 15:46:08 +02:00
committed by GitHub
parent 8c803e5b50
commit 728a80f328
22 changed files with 133 additions and 64 deletions
@@ -142,7 +142,7 @@ final class SpaceSettingsModalCoordinator: Coordinator {
return
}
// Needed more tests on synaose side before starting space upgrade implementation
let coordinator = RoomAccessCoordinator(parameters: RoomAccessCoordinatorParameters(room: room, allowsRoomUpgrade: false))
let coordinator = RoomAccessCoordinator(parameters: RoomAccessCoordinatorParameters(room: room, parentSpaceId: parameters.parentSpaceId, allowsRoomUpgrade: false))
coordinator.callback = { [weak self] result in
guard let self = self else { return }
@@ -36,6 +36,7 @@ final class SpaceSettingsModalCoordinatorBridgePresenter: NSObject {
private let spaceId: String
private let session: MXSession
private let parentSpaceId: String?
private var coordinator: SpaceSettingsModalCoordinator?
// MARK: Public
@@ -44,8 +45,9 @@ final class SpaceSettingsModalCoordinatorBridgePresenter: NSObject {
// MARK: - Setup
init(spaceId: String, session: MXSession) {
init(spaceId: String, parentSpaceId: String?, session: MXSession) {
self.spaceId = spaceId
self.parentSpaceId = parentSpaceId
self.session = session
super.init()
}
@@ -54,7 +56,7 @@ final class SpaceSettingsModalCoordinatorBridgePresenter: NSObject {
func present(from viewController: UIViewController, animated: Bool) {
let navigationRouter = NavigationRouter()
let coordinator = SpaceSettingsModalCoordinator(parameters: SpaceSettingsModalCoordinatorParameters(session: session, spaceId: spaceId, navigationRouter: navigationRouter))
let coordinator = SpaceSettingsModalCoordinator(parameters: SpaceSettingsModalCoordinatorParameters(session: session, spaceId: spaceId, parentSpaceId: parentSpaceId, navigationRouter: navigationRouter))
coordinator.callback = { [weak self] result in
guard let self = self else { return }
@@ -24,15 +24,20 @@ struct SpaceSettingsModalCoordinatorParameters {
/// The ID of the space
let spaceId: String
/// The ID of the currently selected parent of this space. `nil` for home
let parentSpaceId: String?
/// The navigation router that manage physical navigation
let navigationRouter: NavigationRouterType
init(session: MXSession,
spaceId: String,
parentSpaceId: String?,
navigationRouter: NavigationRouterType? = nil) {
self.session = session
self.spaceId = spaceId
self.parentSpaceId = parentSpaceId
self.navigationRouter = navigationRouter ?? NavigationRouter(navigationController: RiotNavigationController())
}
}