felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-05-05 23:47:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash in global search (https://github.com/matrix-org/riot-ios-rageshakes/issues/32)

Browse Source 
I was able to reproduce the bug by using bad network conditioner.
This commit is contained in:
manuroe
2017-06-09 12:09:20 +02:00
parent bb8c79d65f
commit 728082c663
1 changed files with 26 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Riot/ViewController/DirectoryViewController.m
+26 -14
View File
@@ -220,30 +220,42 @@
[self addSpinnerFooterView]; [self addSpinnerFooterView];
__weak __typeof(self) weakSelf = self;
[dataSource paginate:^(NSUInteger roomsAdded) { [dataSource paginate:^(NSUInteger roomsAdded) {
if (roomsAdded) if (weakSelf)
{ {
// Notify the table view there are new items at its tail __strong __typeof(weakSelf) self = weakSelf;
NSMutableArray<NSIndexPath *> *indexPaths = [NSMutableArray arrayWithCapacity:roomsAdded];
NSUInteger numberOfRowsBefore = [dataSource tableView:self.tableView numberOfRowsInSection:0]; if (roomsAdded)
numberOfRowsBefore -= roomsAdded;
for (NSUInteger i = 0; i < roomsAdded; i++)
{ {
NSIndexPath *indexPath = [NSIndexPath indexPathForRow:(numberOfRowsBefore + i) inSection:0]; // Notify the table view there are new items at its tail
[indexPaths addObject:indexPath]; NSMutableArray<NSIndexPath *> *indexPaths = [NSMutableArray arrayWithCapacity:roomsAdded];
NSUInteger numberOfRowsBefore = [self->dataSource tableView:self.tableView numberOfRowsInSection:0];
numberOfRowsBefore -= roomsAdded;
for (NSUInteger i = 0; i < roomsAdded; i++)
{
NSIndexPath *indexPath = [NSIndexPath indexPathForRow:(numberOfRowsBefore + i) inSection:0];
[indexPaths addObject:indexPath];
}
[self.tableView insertRowsAtIndexPaths:indexPaths withRowAnimation:UITableViewRowAnimationAutomatic];
} }
[self.tableView insertRowsAtIndexPaths:indexPaths withRowAnimation:UITableViewRowAnimationAutomatic]; [self removeSpinnerFooterView];
} }
[self removeSpinnerFooterView];
} failure:^(NSError *error) { } failure:^(NSError *error) {
[self removeSpinnerFooterView]; if (weakSelf)
{
__strong __typeof(weakSelf) self = weakSelf;
[self removeSpinnerFooterView];
}
}]; }];
} }