vector-im/element-ios/issues/5298 - Various tweaks following code review.

This commit is contained in:
Stefan Ceriu
2022-01-04 14:12:24 +02:00
committed by Stefan Ceriu
parent 0bac754ad9
commit 7161b99d1c
26 changed files with 248 additions and 211 deletions
@@ -21,11 +21,9 @@ import SwiftUI
struct AnalyticsPromptCoordinatorParameters {
/// The session to use if analytics are enabled.
let session: MXSession
/// The navigation router used to display the prompt.
let navigationRouter: NavigationRouterType
}
final class AnalyticsPromptCoordinator: Coordinator {
final class AnalyticsPromptCoordinator: Coordinator, Presentable {
// MARK: - Properties
@@ -78,8 +76,6 @@ final class AnalyticsPromptCoordinator: Coordinator {
MXLog.debug("[AnalyticsPromptCoordinator] did start.")
parameters.navigationRouter.present(toPresentable(), animated: true)
analyticsPromptViewModel.completion = { [weak self] result in
MXLog.debug("[AnalyticsPromptCoordinator] AnalyticsPromptViewModel did complete with result: \(result).")
@@ -88,11 +84,9 @@ final class AnalyticsPromptCoordinator: Coordinator {
switch result {
case .enable:
Analytics.shared.optIn(with: self.parameters.session)
self.parameters.navigationRouter.dismissModule(animated: true, completion: nil)
self.completion?()
case .disable:
Analytics.shared.optOut()
self.parameters.navigationRouter.dismissModule(animated: true, completion: nil)
self.completion?()
}
}