From 6deb6d34a30c79025b034a7e6533997c141aff1d Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:07:27 +0100
Subject: [PATCH 01/62] BubbleCellContentView: Add support for URL preview,
 expose several constraints.

---
 .../BubbleCellContentView.swift               | 30 ++++++++++++++++++-
 .../BaseBubbleCell/BubbleCellContentView.xib  | 15 ++++++++--
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
index 7fc615f8b..b2ada1d99 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
@@ -38,6 +38,7 @@ final class BubbleCellContentView: UIView, NibLoadable {
     
     @IBOutlet weak var innerContentViewLeadingConstraint: NSLayoutConstraint!
     @IBOutlet weak var innerContentViewTrailingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var innerContentViewBottomContraint: NSLayoutConstraint!
     
     @IBOutlet weak var encryptionStatusContainerView: UIView!
     @IBOutlet weak var encryptionImageView: UIImageView!
@@ -45,11 +46,15 @@ final class BubbleCellContentView: UIView, NibLoadable {
     @IBOutlet weak var bubbleInfoContainer: UIView!
     @IBOutlet weak var bubbleInfoContainerTopConstraint: NSLayoutConstraint!
     
+    @IBOutlet weak var urlPreviewContainerView: UIView!
+    
     @IBOutlet weak var readReceiptsContainerView: UIView!
     @IBOutlet weak var readReceiptsContentView: UIView!
     
     @IBOutlet weak var reactionsContainerView: UIView!
     @IBOutlet weak var reactionsContentView: UIView!
+    @IBOutlet weak var reactionsContentViewLeadingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var reactionsContentViewTrailingConstraint: NSLayoutConstraint!
 
     @IBOutlet weak var threadSummaryContainerView: UIView!
     
@@ -57,6 +62,15 @@ final class BubbleCellContentView: UIView, NibLoadable {
     
     // MARK: Private
     
+    private var showURLPreview: Bool {
+        get {
+            return !self.urlPreviewContainerView.isHidden
+        }
+        set {
+            self.urlPreviewContainerView.isHidden = !newValue
+        }
+    }
+    
     private var showReadReceipts: Bool {
         get {
             return !self.readReceiptsContainerView.isHidden
@@ -178,5 +192,19 @@ extension BubbleCellContentView: BubbleCellThreadSummaryDisplayable {
         self.showThreadSummary = false
         self.threadSummaryContainerView.vc_removeAllSubviews()
     }
-
+}
+
+// MARK: - RoomCellURLPreviewDisplayable
+extension BubbleCellContentView: RoomCellURLPreviewDisplayable {
+
+    func addURLPreviewView(_ urlPreviewView: UIView) {
+        self.urlPreviewContainerView.vc_removeAllSubviews()
+        self.urlPreviewContainerView.vc_addSubViewMatchingParent(urlPreviewView)
+        self.showURLPreview = true
+    }
+    
+    func removeURLPreviewView() {
+        self.showURLPreview = false
+        self.urlPreviewContainerView.vc_removeAllSubviews()
+    }
 }
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 2472391fc..76c12d077 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -17,7 +17,7 @@
                     <rect key="frame" x="0.0" y="0.0" width="595" height="97"/>
                     <color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                 </view>
-                <stackView opaque="NO" contentMode="scaleToFill" axis="vertical" distribution="equalSpacing" translatesAutoresizingMaskIntoConstraints="NO" id="5GX-gn-bK1">
+                <stackView opaque="NO" contentMode="scaleToFill" axis="vertical" translatesAutoresizingMaskIntoConstraints="NO" id="5GX-gn-bK1">
                     <rect key="frame" x="0.0" y="0.0" width="595" height="97"/>
                     <subviews>
                         <view hidden="YES" contentMode="scaleToFill" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="u1e-Q2-PhY">
@@ -159,7 +159,11 @@
                                 <constraint firstItem="oeI-eO-mFK" firstAttribute="leading" secondItem="vcq-cR-uBc" secondAttribute="leading" priority="750" id="vsh-pW-S46"/>
                             </constraints>
                         </view>
-                        <view hidden="YES" contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="4zo-V8-CNe">
+                        <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" verticalHuggingPriority="254" translatesAutoresizingMaskIntoConstraints="NO" id="57V-Sl-EmD">
+                            <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
+                            <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                        </view>
+                        <view hidden="YES" contentMode="scaleToFill" verticalHuggingPriority="253" translatesAutoresizingMaskIntoConstraints="NO" id="4zo-V8-CNe">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="12"/>
                             <subviews>
                                 <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="rQt-NH-Cb0">
@@ -178,7 +182,7 @@
                                 <constraint firstAttribute="trailing" secondItem="rQt-NH-Cb0" secondAttribute="trailing" constant="6" id="lq2-AY-Lus"/>
                             </constraints>
                         </view>
-                        <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="Dj1-m6-1Jw">
+                        <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" verticalHuggingPriority="252" translatesAutoresizingMaskIntoConstraints="NO" id="Dj1-m6-1Jw">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
                             <subviews>
                                 <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="SNw-aM-ILI">
@@ -206,6 +210,7 @@
                         <constraint firstItem="meG-P8-61b" firstAttribute="trailing" secondItem="oeI-eO-mFK" secondAttribute="trailing" id="2Dy-o0-r33"/>
                         <constraint firstItem="w0C-6a-f5M" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="5nl-Le-VDi"/>
                         <constraint firstItem="u1e-Q2-PhY" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="KrJ-dm-TaV"/>
+                        <constraint firstItem="57V-Sl-EmD" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="a2p-Bn-M5e"/>
                         <constraint firstItem="4zo-V8-CNe" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="bdq-sQ-NQy"/>
                         <constraint firstItem="meG-P8-61b" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="lq1-xP-tea"/>
                         <constraint firstItem="SNw-aM-ILI" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="x1n-oT-dez"/>
@@ -234,6 +239,7 @@
                 <outlet property="encryptionImageView" destination="Ujc-3c-e5B" id="7zc-Y7-1jT"/>
                 <outlet property="encryptionStatusContainerView" destination="uHE-o7-sCe" id="Dl7-QS-WKl"/>
                 <outlet property="innerContentView" destination="oeI-eO-mFK" id="ap1-He-C6g"/>
+                <outlet property="innerContentViewBottomContraint" destination="8M5-uW-82s" id="Vn0-6C-LSW"/>
                 <outlet property="innerContentViewLeadingConstraint" destination="0Fr-0L-9tU" id="ByY-oe-d8Y"/>
                 <outlet property="innerContentViewTrailingConstraint" destination="Pbe-4d-q6Y" id="24b-AS-hX4"/>
                 <outlet property="paginationLabel" destination="r7y-FK-GWS" id="R9V-ix-mDu"/>
@@ -241,10 +247,13 @@
                 <outlet property="paginationTitleContainerView" destination="u1e-Q2-PhY" id="Osl-dF-fpA"/>
                 <outlet property="reactionsContainerView" destination="Dj1-m6-1Jw" id="p5e-n1-Wca"/>
                 <outlet property="reactionsContentView" destination="SNw-aM-ILI" id="wMe-f0-qhq"/>
+                <outlet property="reactionsContentViewLeadingConstraint" destination="x1n-oT-dez" id="LUh-3Q-SVr"/>
+                <outlet property="reactionsContentViewTrailingConstraint" destination="ynR-d4-6cf" id="Sy0-o9-vAC"/>
                 <outlet property="readReceiptsContainerView" destination="4zo-V8-CNe" id="7ek-u4-CX8"/>
                 <outlet property="readReceiptsContentView" destination="rQt-NH-Cb0" id="tqw-je-kp9"/>
                 <outlet property="senderInfoContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="threadSummaryContainerView" destination="2eB-kB-m20" id="0Y4-4E-I9K"/>
+                <outlet property="urlPreviewContainerView" destination="57V-Sl-EmD" id="9c6-ai-BY8"/>
                 <outlet property="userNameLabel" destination="meG-P8-61b" id="ETK-ag-WYR"/>
                 <outlet property="userNameTouchMaskView" destination="ohU-Sc-mgb" id="FwW-aL-kc5"/>
             </connections>

From a01215df30b1384fd767c0d1cc804aab4725798c Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:12:47 +0100
Subject: [PATCH 02/62] Create TextMessageBubbleCellContentView

---
 .../TextMessageBubbleCellContentView.swift    | 38 +++++++++++++
 .../TextMessageBubbleCellContentView.xib      | 56 +++++++++++++++++++
 Riot/SupportingFiles/Riot-Bridging-Header.h   |  1 +
 3 files changed, 95 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.xib

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.swift
new file mode 100644
index 000000000..5a57b62c2
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.swift
@@ -0,0 +1,38 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+import Reusable
+
+final class TextMessageBubbleCellContentView: UIView, NibLoadable {
+    
+    // MARK: - Properties
+    
+    // MARK: Outlets
+    
+    @IBOutlet private(set) weak var bubbleBackgroundView: RoomMessageBubbleBackgroundView!
+    
+    @IBOutlet weak var bubbleBackgroundViewLeadingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var bubbleBackgroundViewTrailingConstraint: NSLayoutConstraint!
+    
+    @IBOutlet private(set) weak var textView: UITextView!
+    
+    // MARK: - Setup
+    
+    static func instantiate() -> TextMessageBubbleCellContentView {
+        return TextMessageBubbleCellContentView.loadFromNib()
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.xib
new file mode 100644
index 000000000..90fba0291
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBubbleCellContentView.xib
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="19529" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">
+    <device id="retina6_1" orientation="portrait" appearance="light"/>
+    <dependencies>
+        <deployment identifier="iOS"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="19519"/>
+        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
+    </dependencies>
+    <objects>
+        <placeholder placeholderIdentifier="IBFilesOwner" id="-1" userLabel="File's Owner"/>
+        <placeholder placeholderIdentifier="IBFirstResponder" id="-2" customClass="UIResponder"/>
+        <view contentMode="scaleToFill" id="8T9-hj-ply" customClass="TextMessageBubbleCellContentView" customModule="Riot" customModuleProvider="target">
+            <rect key="frame" x="0.0" y="0.0" width="313" height="82"/>
+            <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
+            <subviews>
+                <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="wRb-1K-GDt" customClass="RoomMessageBubbleBackgroundView" customModule="Riot" customModuleProvider="target">
+                    <rect key="frame" x="0.0" y="0.0" width="152" height="82"/>
+                    <subviews>
+                        <textView clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="scaleToFill" bounces="NO" scrollEnabled="NO" showsHorizontalScrollIndicator="NO" showsVerticalScrollIndicator="NO" editable="NO" text="text message" translatesAutoresizingMaskIntoConstraints="NO" id="1WT-up-UFQ" customClass="MXKMessageTextView">
+                            <rect key="frame" x="5" y="5" width="102" height="72"/>
+                            <color key="backgroundColor" red="0.0" green="0.0" blue="0.0" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
+                            <accessibility key="accessibilityConfiguration" identifier="MessageTextView"/>
+                            <fontDescription key="fontDescription" type="system" pointSize="15"/>
+                            <textInputTraits key="textInputTraits" autocapitalizationType="sentences"/>
+                            <dataDetectorType key="dataDetectorTypes" link="YES"/>
+                        </textView>
+                    </subviews>
+                    <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                    <constraints>
+                        <constraint firstAttribute="bottom" secondItem="1WT-up-UFQ" secondAttribute="bottom" constant="5" id="EMT-p9-z4L"/>
+                        <constraint firstItem="1WT-up-UFQ" firstAttribute="leading" secondItem="wRb-1K-GDt" secondAttribute="leading" constant="5" id="GhZ-J0-v1m"/>
+                        <constraint firstItem="1WT-up-UFQ" firstAttribute="top" secondItem="wRb-1K-GDt" secondAttribute="top" constant="5" id="OpF-jQ-D8Q"/>
+                        <constraint firstAttribute="trailing" secondItem="1WT-up-UFQ" secondAttribute="trailing" constant="45" id="Y8T-HE-6NX"/>
+                    </constraints>
+                </view>
+            </subviews>
+            <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+            <constraints>
+                <constraint firstItem="wRb-1K-GDt" firstAttribute="leading" secondItem="8T9-hj-ply" secondAttribute="leading" id="D7Y-mm-KEV"/>
+                <constraint firstAttribute="bottom" secondItem="wRb-1K-GDt" secondAttribute="bottom" id="JmB-yf-eq5"/>
+                <constraint firstItem="wRb-1K-GDt" firstAttribute="top" secondItem="8T9-hj-ply" secondAttribute="top" id="Jmy-ue-Qtg"/>
+                <constraint firstAttribute="trailing" relation="greaterThanOrEqual" secondItem="wRb-1K-GDt" secondAttribute="trailing" constant="80" id="UwK-6h-MvN"/>
+            </constraints>
+            <nil key="simulatedTopBarMetrics"/>
+            <nil key="simulatedBottomBarMetrics"/>
+            <freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
+            <connections>
+                <outlet property="bubbleBackgroundView" destination="wRb-1K-GDt" id="TWb-A8-15y"/>
+                <outlet property="bubbleBackgroundViewLeadingConstraint" destination="D7Y-mm-KEV" id="4le-fw-axb"/>
+                <outlet property="bubbleBackgroundViewTrailingConstraint" destination="UwK-6h-MvN" id="ZCA-gE-L11"/>
+                <outlet property="textView" destination="1WT-up-UFQ" id="Zh6-C0-kdV"/>
+            </connections>
+            <point key="canvasLocation" x="-1454.3478260869567" y="-392.41071428571428"/>
+        </view>
+    </objects>
+</document>
diff --git a/Riot/SupportingFiles/Riot-Bridging-Header.h b/Riot/SupportingFiles/Riot-Bridging-Header.h
index 165321909..4b517a310 100644
--- a/Riot/SupportingFiles/Riot-Bridging-Header.h
+++ b/Riot/SupportingFiles/Riot-Bridging-Header.h
@@ -67,3 +67,4 @@
 #import "MXKRoomDataSourceManager.h"
 #import "MXRoom+Sync.h"
 #import "UIAlertController+MatrixKit.h"
+#import "MXKMessageTextView.h"

From c848909219a087cca37c1e0b8fac37361ea14bdd Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:13:49 +0100
Subject: [PATCH 03/62] Add RoomCellURLPreviewDisplayable, a protocol
 indicating that a cell support displaying a URL preview.

---
 .../RoomCellURLPreviewDisplayable.swift       | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellURLPreviewDisplayable.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellURLPreviewDisplayable.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellURLPreviewDisplayable.swift
new file mode 100644
index 000000000..dd3a97d7b
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellURLPreviewDisplayable.swift
@@ -0,0 +1,23 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+/// `RoomCellURLPreviewDisplayable` is a protocol indicating that a cell support displaying a URL preview.
+@objc protocol RoomCellURLPreviewDisplayable {
+    func addURLPreviewView(_ urlPreviewView: UIView)
+    func removeURLPreviewView()
+}

From 719b837b4c431e3a502d828c4ebdaf4e3434c238 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:14:37 +0100
Subject: [PATCH 04/62] BaseBubbleCell: Add default support for
 RoomCellURLPreviewDisplayable.

---
 .../BaseBubbleCell/BaseBubbleCell.swift           | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
index 76abfe8e5..ba750c1d4 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
@@ -178,6 +178,10 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
         if let timestampDisplayable = self as? TimestampDisplayable {
             timestampDisplayable.removeTimestampView()
         }
+        
+        if let urlPreviewDisplayable = self as? RoomCellURLPreviewDisplayable {
+            urlPreviewDisplayable.removeURLPreviewView()
+        }
     }
     
     override func render(_ cellData: MXKCellData!) {
@@ -234,6 +238,17 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
         self.bubbleCellContentView = bubbleCellContentView
     }
     
+    // MARK: - RoomCellURLPreviewDisplayable
+    // Cannot use default implementation with ObjC protocol, if self conforms to BubbleCellReadReceiptsDisplayable method below will be used
+    
+    func addURLPreviewView(_ urlPreviewView: UIView) {
+        self.bubbleCellContentView?.addURLPreviewView(urlPreviewView)
+    }
+    
+    func removeURLPreviewView() {
+        self.bubbleCellContentView?.removeURLPreviewView()
+    }
+    
     // MARK: - BubbleCellReadReceiptsDisplayable
     // Cannot use default implementation with ObjC protocol, if self conforms to BubbleCellReadReceiptsDisplayable method below will be used
     

From a645f3a61d7663065ff967fc6b6032cdb7c26944 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:19:11 +0100
Subject: [PATCH 05/62] Create TextMessageBaseBubbleCell

---
 .../Common/TextMessageBaseBubbleCell.swift    | 110 ++++++++++++++++++
 1 file changed, 110 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift
new file mode 100644
index 000000000..3e1936276
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift
@@ -0,0 +1,110 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageBaseBubbleCell: SizableBaseBubbleCell, RoomCellURLPreviewDisplayable, BubbleCellReactionsDisplayable, BubbleCellThreadSummaryDisplayable, BubbleCellReadReceiptsDisplayable {
+    
+    // MARK: - Properties
+    
+    weak var textMessageContentView: TextMessageBubbleCellContentView?
+        
+    override var messageTextView: UITextView! {
+        get {
+            return self.textMessageContentView?.textView
+        }
+        set { }
+    }
+    
+    // MARK: - Overrides
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.backgroundColor = .clear
+        
+        guard let contentView = bubbleCellContentView?.innerContentView else {
+            return
+        }
+        
+        // TODO: Use constants
+        
+        let messageLeftMargin: CGFloat = 48
+        
+        bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin
+        
+        self.bubbleCellContentView?.innerContentViewBottomContraint.constant = 5.0
+        
+        self.bubbleCellContentView?.innerContentViewTrailingConstraint.constant = 34.0
+        
+        let textMessageContentView = TextMessageBubbleCellContentView.instantiate()
+                
+        contentView.vc_addSubViewMatchingParent(textMessageContentView)
+        
+        self.textMessageContentView = textMessageContentView
+    }
+    
+    override func update(theme: Theme) {
+        super.update(theme: theme)
+        
+        if let messageTextView = self.messageTextView {
+            messageTextView.tintColor = theme.tintColor
+        }
+        
+//        self.setupDebug()
+    }
+    
+    // MARK: - Private
+    
+    private func setupDebug() {
+        
+        self.bubbleCellContentView?.innerContentView.backgroundColor = .yellow
+        
+        self.bubbleCellContentView?.layer.borderWidth = 1.0
+        self.bubbleCellContentView?.layer.borderColor = UIColor.red.cgColor
+        
+        self.textMessageContentView?.layer.borderColor = UIColor.blue.cgColor
+        self.textMessageContentView?.layer.borderWidth = 1.0
+        
+        
+        self.bubbleCellContentView?.readReceiptsContainerView.layer.borderColor = UIColor.yellow.cgColor
+        self.bubbleCellContentView?.readReceiptsContainerView.layer.borderWidth = 1.0
+        
+        self.bubbleCellContentView?.reactionsContainerView.layer.borderColor = UIColor.blue.cgColor
+        self.bubbleCellContentView?.reactionsContainerView.layer.borderWidth = 1.0
+        
+        self.bubbleCellContentView?.threadSummaryContainerView.layer.borderColor = UIColor.purple.cgColor
+        self.bubbleCellContentView?.threadSummaryContainerView.layer.borderWidth = 1.0
+    }
+}
+
+// MARK: - RoomCellTimestampDisplayable
+extension TextMessageBaseBubbleCell: TimestampDisplayable {
+    
+    func addTimestampView(_ timestampView: UIView) {
+        guard let messageBubbleBackgroundView = self.textMessageContentView?.bubbleBackgroundView else {
+            return
+        }
+        messageBubbleBackgroundView.addTimestampView(timestampView)
+    }
+    
+    func removeTimestampView() {
+        guard let messageBubbleBackgroundView = self.textMessageContentView?.bubbleBackgroundView else {
+            return
+        }
+        messageBubbleBackgroundView.removeTimestampView()
+    }
+}

From 14f5688118e2f779520f25d6e7298cafcf94d6c5 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:27:16 +0100
Subject: [PATCH 06/62] Create incoming text message bubble cells.

---
 .../TextMessageIncomingBubbleCell.swift       | 67 +++++++++++++++++++
 ...ncomingWithPaginationTitleBubbleCell.swift | 26 +++++++
 ...eIncomingWithoutSenderInfoBubbleCell.swift | 26 +++++++
 3 files changed, 119 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleBubbleCell.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderInfoBubbleCell.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
new file mode 100644
index 000000000..082ae3e40
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
@@ -0,0 +1,67 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell {
+    
+    // MARK: - Constants
+    
+    // TODO: Use global constants
+    private enum BubbleMargins {
+        static let leading: CGFloat = 0
+        static let trailing: CGFloat = 80
+    }
+    
+    // MARK: - Overrides
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderInfo = true
+
+        self.setupBubbleConstraints()
+        self.setupDecorationConstraints()
+    }
+    
+    override func update(theme: Theme) {
+        super.update(theme: theme)
+        
+        self.textMessageContentView?.bubbleBackgroundView?.backgroundColor = theme.roomCellIncomingBubbleBackgroundColor
+    }
+    
+    // MARK: - Private
+    
+    private func setupBubbleConstraints() {
+        
+        self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint.constant = BubbleMargins.leading
+        
+        let innerContentViewTrailingMargin = self.bubbleCellContentView?.innerContentViewTrailingConstraint.constant ?? 0
+        
+        self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint.constant = BubbleMargins.trailing - innerContentViewTrailingMargin
+        
+    }
+    
+    private func setupDecorationConstraints() {
+        
+        self.setupReactionsContentViewContraints()
+    }
+    
+    private func setupReactionsContentViewContraints () {
+        
+        self.bubbleCellContentView?.reactionsContentViewTrailingConstraint.constant = BubbleMargins.trailing
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleBubbleCell.swift
new file mode 100644
index 000000000..7b47ab409
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleBubbleCell.swift
@@ -0,0 +1,26 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageIncomingWithPaginationTitleBubbleCell: TextMessageIncomingBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showPaginationTitle = true
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderInfoBubbleCell.swift
new file mode 100644
index 000000000..abeed3435
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderInfoBubbleCell.swift
@@ -0,0 +1,26 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageIncomingWithoutSenderInfoBubbleCell: TextMessageIncomingBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderInfo = false        
+    }
+}

From db30e2b869e3f5318444c125102d52147b039e2e Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:29:18 +0100
Subject: [PATCH 07/62] Create outgoing text message bubble cells.

---
 ...utgoingWithPaginationTitleBubbleCell.swift |  26 ++++
 ...eOutgoingWithoutSenderInfoBubbleCell.swift | 139 ++++++++++++++++++
 2 files changed, 165 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleBubbleCell.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleBubbleCell.swift
new file mode 100644
index 000000000..1ffb87c80
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleBubbleCell.swift
@@ -0,0 +1,26 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageOutgoingWithPaginationTitleBubbleCell: TextMessageOutgoingWithoutSenderInfoBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showPaginationTitle = true
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
new file mode 100644
index 000000000..ba59be892
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
@@ -0,0 +1,139 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell {
+    
+    // MARK: - Constants
+    
+    // TODO: Use global constants
+    private enum BubbleMargins {
+        static let leading: CGFloat = 80.0
+        static let trailing: CGFloat = 34.0
+    }
+    
+    // MARK: - Overrides
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderInfo = false
+                
+        self.setupBubbleConstraints()
+        self.setupDecorationConstraints()
+    }
+    
+    // MARK: - Private
+    
+    private func setupBubbleConstraints() {
+        
+        guard let containerView = self.textMessageContentView, let bubbleBackgroundView = containerView.bubbleBackgroundView else {
+            return
+        }
+        
+        // Remove existing contraints
+        
+        if let bubbleBackgroundViewLeadingConstraint = self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint {
+            bubbleBackgroundViewLeadingConstraint.isActive = false
+            self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint = nil
+        }
+        
+        if let bubbleBackgroundViewTrailingConstraint = self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint {
+            bubbleBackgroundViewTrailingConstraint.isActive = false
+            self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint = nil
+        }
+        
+        // Setup new constraints
+        
+        let leadingConstraint = bubbleBackgroundView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: BubbleMargins.leading)
+        
+        let trailingConstraint = bubbleBackgroundView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor, constant: 0)
+                
+        NSLayoutConstraint.activate([
+            leadingConstraint,
+            trailingConstraint
+        ])
+                
+        self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint = leadingConstraint
+        
+        self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint = trailingConstraint
+    }
+    
+    private func setupDecorationConstraints() {
+        
+        self.setupReactionsContentViewContraints()
+    }
+    
+    private func setupReactionsContentViewContraints () {
+        guard let bubbleCellContentView = self.bubbleCellContentView, let reactionsContentView = bubbleCellContentView.reactionsContentView, let reactionsContainerView = bubbleCellContentView.reactionsContainerView else {
+            return
+        }
+        
+        // Remove leading constraint
+        
+        bubbleCellContentView.reactionsContentViewLeadingConstraint.isActive = false
+        bubbleCellContentView.reactionsContentViewLeadingConstraint = nil
+        
+        // Setup new leading constraint
+        
+        let leadingConstraint = reactionsContentView.leadingAnchor.constraint(equalTo: reactionsContainerView.leadingAnchor, constant: BubbleMargins.leading)
+        
+        leadingConstraint.isActive = true
+        
+        bubbleCellContentView.reactionsContentViewLeadingConstraint = leadingConstraint
+        
+        // Update trailing constraint
+                                
+        bubbleCellContentView.reactionsContentViewTrailingConstraint.constant = BubbleMargins.trailing
+    }
+    
+    override func update(theme: Theme) {
+        super.update(theme: theme)
+        
+        self.textMessageContentView?.bubbleBackgroundView?.backgroundColor = theme.roomCellOutgoingBubbleBackgroundColor
+    }
+    
+    override func addReactionsView(_ reactionsView: UIView) {
+        
+        super.addReactionsView(reactionsView)
+        
+        if let bubbleReactionsView = reactionsView as? BubbleReactionsView {
+            bubbleReactionsView.alignment = .right
+        }
+    }
+    
+    override func addThreadSummaryView(_ threadSummaryView: ThreadSummaryView) {
+        
+        guard let bubbleCellContentView = self.bubbleCellContentView, let containerView = bubbleCellContentView.threadSummaryContainerView else {
+            return
+        }
+        
+        containerView.vc_removeAllSubviews()
+        
+        containerView.addSubview(threadSummaryView)
+        
+        NSLayoutConstraint.activate([
+            threadSummaryView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: BubbleMargins.trailing),
+            threadSummaryView.topAnchor.constraint(equalTo: containerView.topAnchor),
+            threadSummaryView.heightAnchor.constraint(equalToConstant: RoomBubbleCellLayout.threadSummaryViewHeight),
+            threadSummaryView.bottomAnchor.constraint(equalTo: containerView.bottomAnchor),
+            threadSummaryView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor,
+                                                        constant: -BubbleMargins.trailing)
+        ])
+        containerView.isHidden = false
+    }
+}

From 497c773cbfeba3383bead19245d4e55585eb152c Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 16:36:32 +0100
Subject: [PATCH 08/62] BubbleRoomTimelineCellProvider: Handle new text message
 cells.

---
 .../Bubble/BubbleRoomTimelineCellProvider.m   | 57 +++++++++++++++----
 .../Plain/PlainRoomTimelineCellProvider.h     |  6 ++
 2 files changed, 53 insertions(+), 10 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
index 51a4813b4..0378c7d3f 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
@@ -64,6 +64,25 @@
     [self registerFileWithoutThumbnailCellsForTableView:tableView];
 }
 
+- (void)registerIncomingTextMessageCellsForTableView:(UITableView*)tableView
+{
+    // Also register legacy cells for notice and emotes
+    [super registerIncomingTextMessageCellsForTableView:tableView];
+    
+    [tableView registerClass:TextMessageIncomingBubbleCell.class forCellReuseIdentifier:TextMessageIncomingBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageIncomingWithoutSenderInfoBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithoutSenderInfoBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageIncomingWithPaginationTitleBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithPaginationTitleBubbleCell.defaultReuseIdentifier];
+}
+
+- (void)registerOutgoingTextMessageCellsForTableView:(UITableView*)tableView
+{
+    // Also register legacy cells for notice and emotes
+    [super registerOutgoingTextMessageCellsForTableView:tableView];
+    
+    [tableView registerClass:TextMessageOutgoingWithoutSenderInfoBubbleCell.class forCellReuseIdentifier:TextMessageOutgoingWithoutSenderInfoBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageOutgoingWithPaginationTitleBubbleCell.class forCellReuseIdentifier:TextMessageOutgoingWithPaginationTitleBubbleCell.defaultReuseIdentifier];
+}
+
 - (void)registerVoiceMessageCellsForTableView:(UITableView*)tableView
 {
     // Incoming
@@ -112,22 +131,40 @@
 
 #pragma mark - Mapping
 
+- (NSDictionary<NSNumber*, Class>*)incomingTextMessageCellsMapping
+{
+    return @{
+        // Clear
+        @(RoomTimelineCellIdentifierIncomingTextMessage) : TextMessageIncomingBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithoutSenderName) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        // Encrypted
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncrypted) : TextMessageIncomingBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithoutSenderName) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+    };
+}
+
 - (NSDictionary<NSNumber*, Class>*)outgoingTextMessageCellsMapping
 {
     // Hide sender info and avatar for bubble outgoing messages
     return @{
         // Clear
-        @(RoomTimelineCellIdentifierOutgoingTextMessage) : RoomOutgoingTextMsgWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderInfo) : RoomOutgoingTextMsgWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitle) : RoomOutgoingTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderName) : RoomOutgoingTextMsgWithoutSenderNameBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitleWithoutSenderName) : RoomOutgoingTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessage) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
         // Encrypted
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncrypted) : RoomOutgoingEncryptedTextMsgWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderInfo) : RoomOutgoingEncryptedTextMsgWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitle) : RoomOutgoingEncryptedTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderName) : RoomOutgoingEncryptedTextMsgWithoutSenderNameBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : RoomOutgoingEncryptedTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncrypted) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
     };
 }
 
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
index adedaa9d7..1fe2ecf5a 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
@@ -22,6 +22,10 @@ NS_ASSUME_NONNULL_BEGIN
 
 #pragma mark - Registration
 
+- (void)registerIncomingTextMessageCellsForTableView:(UITableView*)tableView;
+
+- (void)registerOutgoingTextMessageCellsForTableView:(UITableView*)tableView;
+
 - (void)registerVoiceMessageCellsForTableView:(UITableView*)tableView;
 
 - (void)registerPollCellsForTableView:(UITableView*)tableView;
@@ -30,6 +34,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 #pragma mark - Mapping
 
+- (NSDictionary<NSNumber*, Class>*)incomingTextMessageCellsMapping;
+
 - (NSDictionary<NSNumber*, Class>*)outgoingTextMessageCellsMapping;
 
 - (NSDictionary<NSNumber*, Class>*)outgoingAttachmentCellsMapping;

From 17b8f42888265b0d54971f158e41f6d6f0a665b8 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 17:27:14 +0100
Subject: [PATCH 09/62] Create `URLPreviewViewSizer` allows to determine
 reactions view height for a given urlPreviewData and width.

---
 .../URLPreviews/URLPreviewViewSizer.swift     | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/URLPreviews/URLPreviewViewSizer.swift

diff --git a/Riot/Modules/Room/Views/URLPreviews/URLPreviewViewSizer.swift b/Riot/Modules/Room/Views/URLPreviews/URLPreviewViewSizer.swift
new file mode 100644
index 000000000..84e730d8f
--- /dev/null
+++ b/Riot/Modules/Room/Views/URLPreviews/URLPreviewViewSizer.swift
@@ -0,0 +1,43 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the Lircense.
+//
+
+import Foundation
+
+/// `URLPreviewViewSizer` allows to determine reactions view height for a given urlPreviewData and width.
+class URLPreviewViewSizer {
+    
+    // MARK: - Constants
+    
+    private static let sizingView = URLPreviewView.instantiate()    
+    
+    // MARK: - Public
+    
+    func height(for urlPreviewData: URLPreviewData, fittingWidth width: CGFloat) -> CGFloat {
+        
+        let sizingView = URLPreviewViewSizer.sizingView
+        
+        sizingView.frame.size.height = 1.0
+        sizingView.preview = urlPreviewData
+        sizingView.availableWidth = width
+        
+        sizingView.setNeedsLayout()
+        sizingView.layoutIfNeeded()
+        
+        let fittingSize = CGSize(width: width, height: UIView.layoutFittingCompressedSize.height)
+        
+        return sizingView.systemLayoutSizeFitting(fittingSize).height
+    }
+}

From d06c95d183b331a85b720edfaeb73483dd4d33be Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 17:28:07 +0100
Subject: [PATCH 10/62] SizableBaseBubbleCell: Handle handle URL preview.

---
 .../BubbleCells/SizableCell/SizableBubbleCell.swift | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
index 9c802f469..d5b1ccb4f 100644
--- a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
@@ -32,6 +32,8 @@ class SizableBaseBubbleCell: BaseBubbleCell, SizableBaseBubbleCellType {
     
     private static let reactionsViewSizer = BubbleReactionsViewSizer()
     private static let reactionsViewModelBuilder = BubbleReactionsViewModelBuilder()
+    
+    private static let urlPreviewViewSizer = URLPreviewViewSizer()
 
     private class var sizingView: SizableBaseBubbleCell {
         let sizingView: SizableBaseBubbleCell
@@ -138,6 +140,17 @@ class SizableBaseBubbleCell: BaseBubbleCell, SizableBaseBubbleCellType {
             height += RoomBubbleCellLayout.threadSummaryViewHeight
         }
         
+        // Add URL preview view height if needed
+        if sizingView is RoomCellURLPreviewDisplayable,
+            let roomBubbleCellData = cellData as? RoomBubbleCellData, let firstBubbleComponent =
+            roomBubbleCellData.getFirstBubbleComponentWithDisplay(), firstBubbleComponent.showURLPreview, let urlPreviewData = firstBubbleComponent.urlPreviewData as? URLPreviewData {
+            
+            let urlPreviewMaxWidth = sizingView.bubbleCellContentView?.urlPreviewContentView.frame.width ?? roomBubbleCellData.maxTextViewWidth
+            
+            let urlPreviewHeight = self.urlPreviewViewSizer.height(for: urlPreviewData, fittingWidth: urlPreviewMaxWidth)
+            height+=urlPreviewHeight
+        }
+        
         return height
     }         
 }

From 261603f31d7e1588a2c496e66b07459065a1ba00 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 17:28:50 +0100
Subject: [PATCH 11/62] BubbleCellContentView: Update URL preview view
 handling.

---
 .../BubbleCellContentView.swift               | 26 +++++++++++++++---
 .../BaseBubbleCell/BubbleCellContentView.xib  | 27 +++++++++++++++++++
 2 files changed, 50 insertions(+), 3 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
index b2ada1d99..208385d58 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
@@ -47,6 +47,9 @@ final class BubbleCellContentView: UIView, NibLoadable {
     @IBOutlet weak var bubbleInfoContainerTopConstraint: NSLayoutConstraint!
     
     @IBOutlet weak var urlPreviewContainerView: UIView!
+    @IBOutlet weak var urlPreviewContentView: UIView!
+    @IBOutlet weak var urlPreviewContentViewLeadingConstraint: UIView!
+    @IBOutlet weak var urlPreviewContentViewTrailingConstraint: UIView!
     
     @IBOutlet weak var readReceiptsContainerView: UIView!
     @IBOutlet weak var readReceiptsContentView: UIView!
@@ -198,13 +201,30 @@ extension BubbleCellContentView: BubbleCellThreadSummaryDisplayable {
 extension BubbleCellContentView: RoomCellURLPreviewDisplayable {
 
     func addURLPreviewView(_ urlPreviewView: UIView) {
-        self.urlPreviewContainerView.vc_removeAllSubviews()
-        self.urlPreviewContainerView.vc_addSubViewMatchingParent(urlPreviewView)
+        
+        guard let containerView = self.urlPreviewContentView else {
+            return
+        }
+        
+        self.urlPreviewContentView.vc_removeAllSubviews()
+        
+        containerView.translatesAutoresizingMaskIntoConstraints = false
+        containerView.addSubview(urlPreviewView)
+        
+        // Stick URL Preview to left content view
+        
+        NSLayoutConstraint.activate([
+            urlPreviewView.leadingAnchor.constraint(equalTo: containerView.leadingAnchor),
+            urlPreviewView.topAnchor.constraint(equalTo: containerView.topAnchor),
+            urlPreviewView.bottomAnchor.constraint(equalTo: containerView.bottomAnchor),
+            urlPreviewView.trailingAnchor.constraint(lessThanOrEqualTo: containerView.trailingAnchor)
+        ])
+        
         self.showURLPreview = true
     }
     
     func removeURLPreviewView() {
         self.showURLPreview = false
-        self.urlPreviewContainerView.vc_removeAllSubviews()
+        self.urlPreviewContentView.vc_removeAllSubviews()
     }
 }
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 76c12d077..0295dfb6b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -161,7 +161,30 @@
                         </view>
                         <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" verticalHuggingPriority="254" translatesAutoresizingMaskIntoConstraints="NO" id="57V-Sl-EmD">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
+                            <subviews>
+                                <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="vpX-Nl-AEt">
+                                    <rect key="frame" x="56" y="0.0" width="524" height="0.0"/>
+                                    <subviews>
+                                        <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" text="Label" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="HIe-iQ-d37">
+                                            <rect key="frame" x="248" y="-11" width="42" height="21"/>
+                                            <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                                            <fontDescription key="fontDescription" type="system" pointSize="17"/>
+                                            <nil key="textColor"/>
+                                            <nil key="highlightedColor"/>
+                                        </label>
+                                    </subviews>
+                                    <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                                    <constraints>
+                                        <constraint firstAttribute="height" priority="250" placeholder="YES" id="0Sv-R6-k3e"/>
+                                    </constraints>
+                                </view>
+                            </subviews>
                             <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                            <constraints>
+                                <constraint firstAttribute="trailing" secondItem="vpX-Nl-AEt" secondAttribute="trailing" constant="15" id="ZmA-Ns-chh"/>
+                                <constraint firstAttribute="bottom" secondItem="vpX-Nl-AEt" secondAttribute="bottom" id="blD-s1-b1N"/>
+                                <constraint firstItem="vpX-Nl-AEt" firstAttribute="top" secondItem="57V-Sl-EmD" secondAttribute="top" id="sFV-XK-lE4"/>
+                            </constraints>
                         </view>
                         <view hidden="YES" contentMode="scaleToFill" verticalHuggingPriority="253" translatesAutoresizingMaskIntoConstraints="NO" id="4zo-V8-CNe">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="12"/>
@@ -212,6 +235,7 @@
                         <constraint firstItem="u1e-Q2-PhY" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="KrJ-dm-TaV"/>
                         <constraint firstItem="57V-Sl-EmD" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="a2p-Bn-M5e"/>
                         <constraint firstItem="4zo-V8-CNe" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="bdq-sQ-NQy"/>
+                        <constraint firstItem="vpX-Nl-AEt" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="lTt-Qx-fuQ"/>
                         <constraint firstItem="meG-P8-61b" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="lq1-xP-tea"/>
                         <constraint firstItem="SNw-aM-ILI" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="x1n-oT-dez"/>
                     </constraints>
@@ -254,6 +278,9 @@
                 <outlet property="senderInfoContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="threadSummaryContainerView" destination="2eB-kB-m20" id="0Y4-4E-I9K"/>
                 <outlet property="urlPreviewContainerView" destination="57V-Sl-EmD" id="9c6-ai-BY8"/>
+                <outlet property="urlPreviewContentView" destination="vpX-Nl-AEt" id="P8S-Fg-VFQ"/>
+                <outlet property="urlPreviewContentViewLeadingConstraint" destination="lTt-Qx-fuQ" id="5Fc-zl-b1j"/>
+                <outlet property="urlPreviewContentViewTrailingConstraint" destination="ZmA-Ns-chh" id="EXg-Rr-cuJ"/>
                 <outlet property="userNameLabel" destination="meG-P8-61b" id="ETK-ag-WYR"/>
                 <outlet property="userNameTouchMaskView" destination="ohU-Sc-mgb" id="FwW-aL-kc5"/>
             </connections>

From a3508c10d7c285b92bf21f395c4bb88680073e83 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:24:25 +0100
Subject: [PATCH 12/62] BubbleCellContentView: Add possiblity to set decoration
 views alignment.

---
 .../BubbleCellContentView.swift               | 82 +++++++++++++++----
 .../BaseBubbleCell/BubbleCellContentView.xib  | 27 ++++--
 2 files changed, 86 insertions(+), 23 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
index 208385d58..2184eb435 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
@@ -48,8 +48,8 @@ final class BubbleCellContentView: UIView, NibLoadable {
     
     @IBOutlet weak var urlPreviewContainerView: UIView!
     @IBOutlet weak var urlPreviewContentView: UIView!
-    @IBOutlet weak var urlPreviewContentViewLeadingConstraint: UIView!
-    @IBOutlet weak var urlPreviewContentViewTrailingConstraint: UIView!
+    @IBOutlet weak var urlPreviewContentViewLeadingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var urlPreviewContentViewTrailingConstraint: NSLayoutConstraint!
     
     @IBOutlet weak var readReceiptsContainerView: UIView!
     @IBOutlet weak var readReceiptsContentView: UIView!
@@ -60,6 +60,9 @@ final class BubbleCellContentView: UIView, NibLoadable {
     @IBOutlet weak var reactionsContentViewTrailingConstraint: NSLayoutConstraint!
 
     @IBOutlet weak var threadSummaryContainerView: UIView!
+    @IBOutlet weak var threadSummaryContentView: UIView!
+    @IBOutlet weak var threadSummaryContentViewLeadingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var threadSummaryContentViewTrailingConstraint: NSLayoutConstraint!
     
     @IBOutlet weak var bubbleOverlayContainer: UIView!
     
@@ -129,6 +132,8 @@ final class BubbleCellContentView: UIView, NibLoadable {
         }
     }
     
+    var decorationViewsAlignment: RoomCellDecorationAlignment = .left
+    
     // MARK: - Setup
     
     class func instantiate() -> BubbleCellContentView {
@@ -164,7 +169,24 @@ extension BubbleCellContentView: BubbleCellReactionsDisplayable {
     
     func addReactionsView(_ reactionsView: UIView) {
         self.reactionsContentView.vc_removeAllSubviews()
-        self.reactionsContentView.vc_addSubViewMatchingParent(reactionsView) 
+        
+        // Update reactions alignment according to current decoration alignment
+        if let bubbleReactionsView = reactionsView as? BubbleReactionsView {
+            
+            let reactionsAlignment: BubbleReactionsViewAlignment
+            
+            switch self.decorationViewsAlignment {
+            case .left:
+                reactionsAlignment = .left
+            case .right:
+                reactionsAlignment = .right
+            }
+                        
+            bubbleReactionsView.alignment = reactionsAlignment
+        }
+        
+        self.reactionsContentView.vc_addSubViewMatchingParent(reactionsView)
+        
         self.showReactions = true
     }
     
@@ -176,24 +198,43 @@ extension BubbleCellContentView: BubbleCellReactionsDisplayable {
 
 // MARK: - BubbleCellThreadSummaryDisplayable
 extension BubbleCellContentView: BubbleCellThreadSummaryDisplayable {
-
+    
     func addThreadSummaryView(_ threadSummaryView: ThreadSummaryView) {
-        self.threadSummaryContainerView.vc_removeAllSubviews()
-        self.threadSummaryContainerView.addSubview(threadSummaryView)
+        
+        guard let containerView = self.threadSummaryContentView else {
+            return
+        }
+        
+        containerView.vc_removeAllSubviews()
+        
+        containerView.translatesAutoresizingMaskIntoConstraints = false
+        containerView.addSubview(threadSummaryView)
+        
+        let leadingConstraint: NSLayoutConstraint
+        let trailingConstraint: NSLayoutConstraint
+        
+        if self.decorationViewsAlignment == .right {
+            leadingConstraint = threadSummaryView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor)
+            trailingConstraint = threadSummaryView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor)
+        } else {
+            leadingConstraint = threadSummaryView.leadingAnchor.constraint(equalTo: containerView.leadingAnchor)
+            trailingConstraint =             threadSummaryView.trailingAnchor.constraint(lessThanOrEqualTo: containerView.trailingAnchor)
+        }
+        
         NSLayoutConstraint.activate([
-            threadSummaryView.leadingAnchor.constraint(equalTo: innerContentView.leadingAnchor),
+            leadingConstraint,
             threadSummaryView.topAnchor.constraint(equalTo: threadSummaryContainerView.topAnchor),
             threadSummaryView.heightAnchor.constraint(equalToConstant: RoomBubbleCellLayout.threadSummaryViewHeight),
             threadSummaryView.bottomAnchor.constraint(equalTo: threadSummaryContainerView.bottomAnchor),
-            threadSummaryView.trailingAnchor.constraint(lessThanOrEqualTo: threadSummaryContainerView.trailingAnchor,
-                                                        constant: -RoomBubbleCellLayout.reactionsViewRightMargin)
+            trailingConstraint
         ])
+        
         self.showThreadSummary = true
     }
 
     func removeThreadSummaryView() {
         self.showThreadSummary = false
-        self.threadSummaryContainerView.vc_removeAllSubviews()
+        self.threadSummaryContentView.vc_removeAllSubviews()
     }
 }
 
@@ -206,18 +247,31 @@ extension BubbleCellContentView: RoomCellURLPreviewDisplayable {
             return
         }
         
-        self.urlPreviewContentView.vc_removeAllSubviews()
+        containerView.vc_removeAllSubviews()
         
         containerView.translatesAutoresizingMaskIntoConstraints = false
         containerView.addSubview(urlPreviewView)
         
-        // Stick URL Preview to left content view
+        if let urlPreviewView = urlPreviewView as? URLPreviewView {
+            urlPreviewView.availableWidth = containerView.frame.width
+        }
+        
+        let leadingConstraint: NSLayoutConstraint
+        let trailingConstraint: NSLayoutConstraint
+        
+        if self.decorationViewsAlignment == .right {
+            leadingConstraint = urlPreviewView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor)
+            trailingConstraint = urlPreviewView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor)
+        } else {
+            leadingConstraint = urlPreviewView.leadingAnchor.constraint(equalTo: containerView.leadingAnchor)
+            trailingConstraint =             urlPreviewView.trailingAnchor.constraint(lessThanOrEqualTo: containerView.trailingAnchor)
+        }
         
         NSLayoutConstraint.activate([
-            urlPreviewView.leadingAnchor.constraint(equalTo: containerView.leadingAnchor),
+            leadingConstraint,
             urlPreviewView.topAnchor.constraint(equalTo: containerView.topAnchor),
             urlPreviewView.bottomAnchor.constraint(equalTo: containerView.bottomAnchor),
-            urlPreviewView.trailingAnchor.constraint(lessThanOrEqualTo: containerView.trailingAnchor)
+            trailingConstraint
         ])
         
         self.showURLPreview = true
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 0295dfb6b..580be3744 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -164,15 +164,6 @@
                             <subviews>
                                 <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="vpX-Nl-AEt">
                                     <rect key="frame" x="56" y="0.0" width="524" height="0.0"/>
-                                    <subviews>
-                                        <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" text="Label" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="HIe-iQ-d37">
-                                            <rect key="frame" x="248" y="-11" width="42" height="21"/>
-                                            <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
-                                            <fontDescription key="fontDescription" type="system" pointSize="17"/>
-                                            <nil key="textColor"/>
-                                            <nil key="highlightedColor"/>
-                                        </label>
-                                    </subviews>
                                     <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
                                     <constraints>
                                         <constraint firstAttribute="height" priority="250" placeholder="YES" id="0Sv-R6-k3e"/>
@@ -225,12 +216,27 @@
                         </view>
                         <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="2eB-kB-m20">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
+                            <subviews>
+                                <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="snf-Ea-To0">
+                                    <rect key="frame" x="56" y="0.0" width="524" height="0.0"/>
+                                    <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                                    <constraints>
+                                        <constraint firstAttribute="height" priority="250" placeholder="YES" id="ymW-ys-P0T"/>
+                                    </constraints>
+                                </view>
+                            </subviews>
                             <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                            <constraints>
+                                <constraint firstAttribute="bottom" secondItem="snf-Ea-To0" secondAttribute="bottom" id="4tt-w0-4JE"/>
+                                <constraint firstItem="snf-Ea-To0" firstAttribute="top" secondItem="2eB-kB-m20" secondAttribute="top" id="Im9-Z0-ieI"/>
+                                <constraint firstAttribute="trailing" secondItem="snf-Ea-To0" secondAttribute="trailing" constant="15" id="Qwm-Of-Zgc"/>
+                            </constraints>
                         </view>
                     </subviews>
                     <constraints>
                         <constraint firstItem="Dj1-m6-1Jw" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="0Px-jL-CMJ"/>
                         <constraint firstItem="meG-P8-61b" firstAttribute="trailing" secondItem="oeI-eO-mFK" secondAttribute="trailing" id="2Dy-o0-r33"/>
+                        <constraint firstItem="snf-Ea-To0" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="2lm-T3-dEu"/>
                         <constraint firstItem="w0C-6a-f5M" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="5nl-Le-VDi"/>
                         <constraint firstItem="u1e-Q2-PhY" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="KrJ-dm-TaV"/>
                         <constraint firstItem="57V-Sl-EmD" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="a2p-Bn-M5e"/>
@@ -277,6 +283,9 @@
                 <outlet property="readReceiptsContentView" destination="rQt-NH-Cb0" id="tqw-je-kp9"/>
                 <outlet property="senderInfoContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="threadSummaryContainerView" destination="2eB-kB-m20" id="0Y4-4E-I9K"/>
+                <outlet property="threadSummaryContentView" destination="snf-Ea-To0" id="6Oo-Gj-e4Z"/>
+                <outlet property="threadSummaryContentViewLeadingConstraint" destination="2lm-T3-dEu" id="jR6-sh-Nul"/>
+                <outlet property="threadSummaryContentViewTrailingConstraint" destination="Qwm-Of-Zgc" id="dfE-aR-MQQ"/>
                 <outlet property="urlPreviewContainerView" destination="57V-Sl-EmD" id="9c6-ai-BY8"/>
                 <outlet property="urlPreviewContentView" destination="vpX-Nl-AEt" id="P8S-Fg-VFQ"/>
                 <outlet property="urlPreviewContentViewLeadingConstraint" destination="lTt-Qx-fuQ" id="5Fc-zl-b1j"/>

From e80aa40b090f8aa648ec27a831682c859b5ba334 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:25:38 +0100
Subject: [PATCH 13/62] Add bubble cell protocols.

---
 .../BubbleIncomingRoomCellProtocol.swift      |  27 +++++
 .../BubbleOutgoingRoomCellProtocol.swift      | 114 ++++++++++++++++++
 .../Bubble/Cells/BubbleRoomCellProtocol.swift |  24 ++++
 ...KRoomBubbleTableViewCell+BubbleStyle.swift |   0
 4 files changed, 165 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleRoomCellProtocol.swift
 rename Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/{ => Cells}/MXKRoomBubbleTableViewCell+BubbleStyle.swift (100%)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
new file mode 100644
index 000000000..682150dfc
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
@@ -0,0 +1,27 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+protocol BubbleIncomingRoomCellProtocol: BubbleRoomCellProtocol {
+}
+
+extension BubbleIncomingRoomCellProtocol {
+    
+    func setupBubbleDecorations() {
+        
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
new file mode 100644
index 000000000..7e288ada8
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
@@ -0,0 +1,114 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+protocol BubbleOutgoingRoomCellProtocol: BubbleRoomCellProtocol {
+        
+}
+
+// MARK: - Default implementation
+extension BubbleOutgoingRoomCellProtocol {
+    
+    // MARK: - Public
+    
+    func setupBubbleDecorations() {
+        self.bubbleCellContentView?.decorationViewsAlignment = .right
+        self.setupDecorationConstraints()
+    }
+    
+    // MARK: - Private
+    
+    private func setupDecorationConstraints() {
+        
+        self.setupURLPreviewContentViewContraints()
+        self.setupReactionsContentViewContraints()
+        self.setupThreadSummaryViewContentViewContraints()
+    }
+    
+    private func setupReactionsContentViewContraints () {
+        guard let bubbleCellContentView = self.bubbleCellContentView, let reactionsContentView = bubbleCellContentView.reactionsContentView, let reactionsContainerView = bubbleCellContentView.reactionsContainerView else {
+            return
+        }
+        
+        // Remove leading constraint
+        
+        bubbleCellContentView.reactionsContentViewLeadingConstraint.isActive = false
+        bubbleCellContentView.reactionsContentViewLeadingConstraint = nil
+        
+        // Setup new leading constraint
+        
+        let leadingConstraint = self.setupDecorationViewLeadingContraint(containerView: reactionsContainerView, contentView: reactionsContentView)
+        
+        bubbleCellContentView.reactionsContentViewLeadingConstraint = leadingConstraint
+        
+        // Update trailing constraint
+                                
+        bubbleCellContentView.reactionsContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
+    }
+    
+    private func setupThreadSummaryViewContentViewContraints () {
+        
+        guard let bubbleCellContentView = self.bubbleCellContentView, let threadSummaryContentView = bubbleCellContentView.threadSummaryContentView, let threadSummaryContainerView = bubbleCellContentView.threadSummaryContainerView else {
+            return
+        }
+        
+        // Remove leading constraint
+                
+        bubbleCellContentView.threadSummaryContentViewLeadingConstraint.isActive = false
+        bubbleCellContentView.threadSummaryContentViewLeadingConstraint = nil
+        
+        // Setup new leading constraint
+        
+        let leadingConstraint = self.setupDecorationViewLeadingContraint(containerView: threadSummaryContainerView, contentView: threadSummaryContentView)
+        
+        bubbleCellContentView.threadSummaryContentViewLeadingConstraint = leadingConstraint
+        
+        // Update trailing constraint
+                                
+        bubbleCellContentView.threadSummaryContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
+    }
+    
+    private func setupURLPreviewContentViewContraints () {
+        
+        guard let bubbleCellContentView = self.bubbleCellContentView, let contentView = bubbleCellContentView.urlPreviewContentView, let containerView = bubbleCellContentView.urlPreviewContainerView else {
+            return
+        }
+        
+        // Remove leading constraint
+                
+        bubbleCellContentView.urlPreviewContentViewLeadingConstraint.isActive = false
+        bubbleCellContentView.urlPreviewContentViewLeadingConstraint = nil
+        
+        // Setup new leading constraint
+        
+        let leadingConstraint = self.setupDecorationViewLeadingContraint(containerView: containerView, contentView: contentView)
+        
+        bubbleCellContentView.urlPreviewContentViewLeadingConstraint = leadingConstraint
+        
+        // Update trailing constraint
+                                
+        bubbleCellContentView.urlPreviewContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
+    }
+    
+    private func setupDecorationViewLeadingContraint(containerView: UIView,
+                                                      contentView: UIView) -> NSLayoutConstraint {
+                                                
+        let leadingConstraint = contentView.leadingAnchor.constraint(equalTo: containerView.leadingAnchor, constant: BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.left)
+        leadingConstraint.isActive = true
+        return leadingConstraint
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleRoomCellProtocol.swift
new file mode 100644
index 000000000..8567af631
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleRoomCellProtocol.swift
@@ -0,0 +1,24 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+protocol BubbleRoomCellProtocol {
+    
+    var bubbleCellContentView: BubbleCellContentView? { get }
+    
+    func setupBubbleDecorations()
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/MXKRoomBubbleTableViewCell+BubbleStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/MXKRoomBubbleTableViewCell+BubbleStyle.swift
similarity index 100%
rename from Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/MXKRoomBubbleTableViewCell+BubbleStyle.swift
rename to Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/MXKRoomBubbleTableViewCell+BubbleStyle.swift

From 789ccfac047694b46958bed5db28d3eaaca8dcdd Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:25:54 +0100
Subject: [PATCH 14/62] Create RoomCellDecorationAlignment

---
 .../RoomCellDecorationAlignment.swift         | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellDecorationAlignment.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellDecorationAlignment.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellDecorationAlignment.swift
new file mode 100644
index 000000000..4aa7f7d53
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/RoomCellDecorationAlignment.swift
@@ -0,0 +1,23 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+/// BubbleCellContentView decoration view items alignment
+enum RoomCellDecorationAlignment {
+    case left
+    case right
+}

From 64c43cccd42bef3f0ac94e36e963cef601605bc2 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:26:40 +0100
Subject: [PATCH 15/62] Add BubbleRoomCellLayoutConstants

---
 .../BubbleRoomCellLayoutConstants.swift       | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift
new file mode 100644
index 000000000..2d6265007
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift
@@ -0,0 +1,27 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+
+
+/// Bubble style room cell layout constants
+@objcMembers
+final class BubbleRoomCellLayoutConstants: NSObject {
+    
+    static let outgoingBubbleBackgroundMargins: UIEdgeInsets = UIEdgeInsets(top: 0, left: 80, bottom: 0, right: 34)
+
+    static let incomingBubbleBackgroundMargins: UIEdgeInsets = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: 80)
+}

From be14bc1113536d005cb2a611165b2541f1dfa379 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:27:07 +0100
Subject: [PATCH 16/62] BubbleRoomTimelineCellDecorator: Handle URL preview.

---
 .../BubbleRoomTimelineCellDecorator.swift     | 71 ++++++++++---------
 1 file changed, 38 insertions(+), 33 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
index ff71c81bf..9a2decc63 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
@@ -170,44 +170,49 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
                                     cellData: RoomBubbleCellData,
                                     contentViewPositionY: CGFloat) {
         
-        cell.addTemporarySubview(urlPreviewView)
-        
-        let cellContentView = cell.contentView
-        
-        urlPreviewView.translatesAutoresizingMaskIntoConstraints = false
-        urlPreviewView.availableWidth = cellData.maxTextViewWidth
-        cellContentView.addSubview(urlPreviewView)
-        
-        let leadingOrTrailingConstraint: NSLayoutConstraint
-        
-        
-        // Incoming message
-        if cellData.isIncoming {
+        if let urlPreviewDisplayable = cell as? RoomCellURLPreviewDisplayable {
+            urlPreviewView.translatesAutoresizingMaskIntoConstraints = false
+            urlPreviewDisplayable.addURLPreviewView(urlPreviewView)
+        } else {
+            cell.addTemporarySubview(urlPreviewView)
+            
+            let cellContentView = cell.contentView
+            
+            urlPreviewView.translatesAutoresizingMaskIntoConstraints = false
+            urlPreviewView.availableWidth = cellData.maxTextViewWidth
+            cellContentView.addSubview(urlPreviewView)
+            
+            let leadingOrTrailingConstraint: NSLayoutConstraint
+            
+            
+            // Incoming message
+            if cellData.isIncoming {
 
-            var leftMargin = RoomBubbleCellLayout.reactionsViewLeftMargin
-            if cellData.containsBubbleComponentWithEncryptionBadge {
-                leftMargin += RoomBubbleCellLayout.encryptedContentLeftMargin
+                var leftMargin = RoomBubbleCellLayout.reactionsViewLeftMargin
+                if cellData.containsBubbleComponentWithEncryptionBadge {
+                    leftMargin += RoomBubbleCellLayout.encryptedContentLeftMargin
+                }
+                
+                leftMargin-=5.0
+                
+                leadingOrTrailingConstraint = urlPreviewView.leadingAnchor.constraint(equalTo: cellContentView.leadingAnchor, constant: leftMargin)
+            } else {
+                // Outgoing message
+                
+                // TODO: Use constants
+                let rightMargin: CGFloat = 34.0
+                
+                leadingOrTrailingConstraint = urlPreviewView.trailingAnchor.constraint(equalTo: cellContentView.trailingAnchor, constant: -rightMargin)
             }
             
-            leftMargin-=5.0
+            let topMargin = contentViewPositionY + RoomBubbleCellLayout.urlPreviewViewTopMargin + RoomBubbleCellLayout.reactionsViewTopMargin
             
-            leadingOrTrailingConstraint = urlPreviewView.leadingAnchor.constraint(equalTo: cellContentView.leadingAnchor, constant: leftMargin)
-        } else {
-            // Outgoing message
-            
-            // TODO: Use constants
-            let rightMargin: CGFloat = 34.0
-            
-            leadingOrTrailingConstraint = urlPreviewView.trailingAnchor.constraint(equalTo: cellContentView.trailingAnchor, constant: -rightMargin)
+            // Set the preview view's origin
+            NSLayoutConstraint.activate([
+                leadingOrTrailingConstraint,
+                urlPreviewView.topAnchor.constraint(equalTo: cellContentView.topAnchor, constant: topMargin)
+            ])
         }
-        
-        let topMargin = contentViewPositionY + RoomBubbleCellLayout.urlPreviewViewTopMargin + RoomBubbleCellLayout.reactionsViewTopMargin
-        
-        // Set the preview view's origin
-        NSLayoutConstraint.activate([
-            leadingOrTrailingConstraint,
-            urlPreviewView.topAnchor.constraint(equalTo: cellContentView.topAnchor, constant: topMargin)
-        ])
     }
     
     override func addThreadSummaryView(_ threadSummaryView: ThreadSummaryView,

From 008d48a4b13bf3132dd8a65388e4c122aa6c6e40 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:27:56 +0100
Subject: [PATCH 17/62] TextMessageOutgoingWithoutSenderInfoBubbleCell:
 Conforms to BubbleOutgoingRoomCellProtocol, handle stick to right
 decorations.

---
 ...eOutgoingWithoutSenderInfoBubbleCell.swift | 86 +++----------------
 1 file changed, 10 insertions(+), 76 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
index ba59be892..727ec0542 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
@@ -16,15 +16,7 @@
 
 import UIKit
 
-class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell {
-    
-    // MARK: - Constants
-    
-    // TODO: Use global constants
-    private enum BubbleMargins {
-        static let leading: CGFloat = 80.0
-        static let trailing: CGFloat = 34.0
-    }
+class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell, BubbleOutgoingRoomCellProtocol {    
     
     // MARK: - Overrides
     
@@ -32,9 +24,15 @@ class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell
         super.setupViews()
         
         bubbleCellContentView?.showSenderInfo = false
-                
+        
         self.setupBubbleConstraints()
-        self.setupDecorationConstraints()
+        self.setupBubbleDecorations()
+    }
+    
+    override func update(theme: Theme) {
+        super.update(theme: theme)
+        
+        self.textMessageContentView?.bubbleBackgroundView?.backgroundColor = theme.roomCellOutgoingBubbleBackgroundColor
     }
     
     // MARK: - Private
@@ -59,7 +57,7 @@ class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell
         
         // Setup new constraints
         
-        let leadingConstraint = bubbleBackgroundView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: BubbleMargins.leading)
+        let leadingConstraint = bubbleBackgroundView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: 0)
         
         let trailingConstraint = bubbleBackgroundView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor, constant: 0)
                 
@@ -72,68 +70,4 @@ class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell
         
         self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint = trailingConstraint
     }
-    
-    private func setupDecorationConstraints() {
-        
-        self.setupReactionsContentViewContraints()
-    }
-    
-    private func setupReactionsContentViewContraints () {
-        guard let bubbleCellContentView = self.bubbleCellContentView, let reactionsContentView = bubbleCellContentView.reactionsContentView, let reactionsContainerView = bubbleCellContentView.reactionsContainerView else {
-            return
-        }
-        
-        // Remove leading constraint
-        
-        bubbleCellContentView.reactionsContentViewLeadingConstraint.isActive = false
-        bubbleCellContentView.reactionsContentViewLeadingConstraint = nil
-        
-        // Setup new leading constraint
-        
-        let leadingConstraint = reactionsContentView.leadingAnchor.constraint(equalTo: reactionsContainerView.leadingAnchor, constant: BubbleMargins.leading)
-        
-        leadingConstraint.isActive = true
-        
-        bubbleCellContentView.reactionsContentViewLeadingConstraint = leadingConstraint
-        
-        // Update trailing constraint
-                                
-        bubbleCellContentView.reactionsContentViewTrailingConstraint.constant = BubbleMargins.trailing
-    }
-    
-    override func update(theme: Theme) {
-        super.update(theme: theme)
-        
-        self.textMessageContentView?.bubbleBackgroundView?.backgroundColor = theme.roomCellOutgoingBubbleBackgroundColor
-    }
-    
-    override func addReactionsView(_ reactionsView: UIView) {
-        
-        super.addReactionsView(reactionsView)
-        
-        if let bubbleReactionsView = reactionsView as? BubbleReactionsView {
-            bubbleReactionsView.alignment = .right
-        }
-    }
-    
-    override func addThreadSummaryView(_ threadSummaryView: ThreadSummaryView) {
-        
-        guard let bubbleCellContentView = self.bubbleCellContentView, let containerView = bubbleCellContentView.threadSummaryContainerView else {
-            return
-        }
-        
-        containerView.vc_removeAllSubviews()
-        
-        containerView.addSubview(threadSummaryView)
-        
-        NSLayoutConstraint.activate([
-            threadSummaryView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: BubbleMargins.trailing),
-            threadSummaryView.topAnchor.constraint(equalTo: containerView.topAnchor),
-            threadSummaryView.heightAnchor.constraint(equalToConstant: RoomBubbleCellLayout.threadSummaryViewHeight),
-            threadSummaryView.bottomAnchor.constraint(equalTo: containerView.bottomAnchor),
-            threadSummaryView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor,
-                                                        constant: -BubbleMargins.trailing)
-        ])
-        containerView.isHidden = false
-    }
 }

From d674c1693a36a8248cba31123df0159d728f67a3 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:44:47 +0100
Subject: [PATCH 18/62] BubbleIncomingRoomCellProtocol: Handle decoration
 constraints.

---
 .../BubbleIncomingRoomCellProtocol.swift      | 25 +++++++++++++++++++
 .../BubbleOutgoingRoomCellProtocol.swift      |  6 ++---
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
index 682150dfc..5f58fb65b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
@@ -21,7 +21,32 @@ protocol BubbleIncomingRoomCellProtocol: BubbleRoomCellProtocol {
 
 extension BubbleIncomingRoomCellProtocol {
     
+    // MARK: - Public
+    
     func setupBubbleDecorations() {
+        self.bubbleCellContentView?.decorationViewsAlignment = .left
+        self.setupDecorationConstraints()
+    }
+    
+    // MARK: - Private
+    
+    private func setupDecorationConstraints() {
         
+        self.setupURLPreviewContentViewContraints()
+        self.setupReactionsContentViewContraints()
+        self.setupThreadSummaryViewContentViewContraints()
+    }
+    
+    private func setupReactionsContentViewContraints() {
+        
+        self.bubbleCellContentView?.reactionsContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right
+    }
+    
+    private func setupThreadSummaryViewContentViewContraints() {
+        self.bubbleCellContentView?.threadSummaryContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right
+    }
+    
+    private func setupURLPreviewContentViewContraints() {
+        self.bubbleCellContentView?.urlPreviewContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right
     }
 }
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
index 7e288ada8..a9e5cd2bc 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
@@ -39,7 +39,7 @@ extension BubbleOutgoingRoomCellProtocol {
         self.setupThreadSummaryViewContentViewContraints()
     }
     
-    private func setupReactionsContentViewContraints () {
+    private func setupReactionsContentViewContraints() {
         guard let bubbleCellContentView = self.bubbleCellContentView, let reactionsContentView = bubbleCellContentView.reactionsContentView, let reactionsContainerView = bubbleCellContentView.reactionsContainerView else {
             return
         }
@@ -60,7 +60,7 @@ extension BubbleOutgoingRoomCellProtocol {
         bubbleCellContentView.reactionsContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
     }
     
-    private func setupThreadSummaryViewContentViewContraints () {
+    private func setupThreadSummaryViewContentViewContraints() {
         
         guard let bubbleCellContentView = self.bubbleCellContentView, let threadSummaryContentView = bubbleCellContentView.threadSummaryContentView, let threadSummaryContainerView = bubbleCellContentView.threadSummaryContainerView else {
             return
@@ -82,7 +82,7 @@ extension BubbleOutgoingRoomCellProtocol {
         bubbleCellContentView.threadSummaryContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
     }
     
-    private func setupURLPreviewContentViewContraints () {
+    private func setupURLPreviewContentViewContraints() {
         
         guard let bubbleCellContentView = self.bubbleCellContentView, let contentView = bubbleCellContentView.urlPreviewContentView, let containerView = bubbleCellContentView.urlPreviewContainerView else {
             return

From 1a5df84b07fe6a1a344d00998b6d39ceaeacac44 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:45:26 +0100
Subject: [PATCH 19/62] TextMessageOutgoingWithoutSenderInfoBubbleCell: Fix bg
 view leading constraint.

---
 .../TextMessageOutgoingWithoutSenderInfoBubbleCell.swift        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
index 727ec0542..992d83ad9 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithoutSenderInfoBubbleCell.swift
@@ -57,7 +57,7 @@ class TextMessageOutgoingWithoutSenderInfoBubbleCell: TextMessageBaseBubbleCell,
         
         // Setup new constraints
         
-        let leadingConstraint = bubbleBackgroundView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: 0)
+        let leadingConstraint = bubbleBackgroundView.leadingAnchor.constraint(greaterThanOrEqualTo: containerView.leadingAnchor, constant: BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.left)
         
         let trailingConstraint = bubbleBackgroundView.trailingAnchor.constraint(equalTo: containerView.trailingAnchor, constant: 0)
                 

From ef0a1aec06c2d2c94e5d2c010e38b8530f2fcec0 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:45:46 +0100
Subject: [PATCH 20/62] TextMessageIncomingBubbleCell: Conforms to
 BubbleIncomingRoomCellProtocol.

---
 .../TextMessageIncomingBubbleCell.swift       | 26 +++----------------
 1 file changed, 4 insertions(+), 22 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
index 082ae3e40..4f7b5ef98 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
@@ -16,15 +16,7 @@
 
 import UIKit
 
-class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell {
-    
-    // MARK: - Constants
-    
-    // TODO: Use global constants
-    private enum BubbleMargins {
-        static let leading: CGFloat = 0
-        static let trailing: CGFloat = 80
-    }
+class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell, BubbleIncomingRoomCellProtocol {
     
     // MARK: - Overrides
     
@@ -34,7 +26,7 @@ class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell {
         bubbleCellContentView?.showSenderInfo = true
 
         self.setupBubbleConstraints()
-        self.setupDecorationConstraints()
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {
@@ -47,21 +39,11 @@ class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell {
     
     private func setupBubbleConstraints() {
         
-        self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint.constant = BubbleMargins.leading
+        self.textMessageContentView?.bubbleBackgroundViewLeadingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.left
         
         let innerContentViewTrailingMargin = self.bubbleCellContentView?.innerContentViewTrailingConstraint.constant ?? 0
         
-        self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint.constant = BubbleMargins.trailing - innerContentViewTrailingMargin
+        self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right - innerContentViewTrailingMargin
         
     }
-    
-    private func setupDecorationConstraints() {
-        
-        self.setupReactionsContentViewContraints()
-    }
-    
-    private func setupReactionsContentViewContraints () {
-        
-        self.bubbleCellContentView?.reactionsContentViewTrailingConstraint.constant = BubbleMargins.trailing
-    }
 }

From 757ebde6725149f7bd7d4c8109bbc246c0bfd373 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:57:50 +0100
Subject: [PATCH 21/62] Update location bubble cells.

---
 .../Incoming/LocationIncomingBubbleCell.swift     |  2 +-
 ...ationOutgoingWithoutSenderInfoBubbleCell.swift | 15 +++++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
index b0818f550..bb8287abd 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import Foundation
 
-class LocationIncomingBubbleCell: LocationBubbleCell {
+class LocationIncomingBubbleCell: LocationBubbleCell, BubbleIncomingRoomCellProtocol {
             
     override func setupViews() {
         super.setupViews()
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Outgoing/LocationOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Outgoing/LocationOutgoingWithoutSenderInfoBubbleCell.swift
index 8c46e21de..ef2061224 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Outgoing/LocationOutgoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Outgoing/LocationOutgoingWithoutSenderInfoBubbleCell.swift
@@ -16,18 +16,17 @@
 
 import Foundation
 
-class LocationOutgoingWithoutSenderInfoBubbleCell: LocationBubbleCell {
+class LocationOutgoingWithoutSenderInfoBubbleCell: LocationBubbleCell, BubbleOutgoingRoomCellProtocol {
+    
     override func setupViews() {
         super.setupViews()
         
         bubbleCellContentView?.showSenderInfo = false
+
+        bubbleCellContentView?.innerContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
+
+        bubbleCellContentView?.innerContentViewLeadingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.left
         
-        // TODO: Use constants
-        // Same as outgoing message
-        let rightMargin: CGFloat = 34.0
-        let leftMargin: CGFloat = 80.0
-        
-        bubbleCellContentView?.innerContentViewTrailingConstraint.constant = rightMargin
-        bubbleCellContentView?.innerContentViewLeadingConstraint.constant = leftMargin
+        self.setupBubbleDecorations()
     }
 }

From ee92229ac6863df32d18ce05c8c0b01fb8a4251c Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:59:05 +0100
Subject: [PATCH 22/62] Update poll bubble cells.

---
 .../Bubble/Cells/Poll/Incoming/PollIncomingBubbleCell.swift | 6 ++++--
 .../VoiceMessageOutgoingWithoutSenderInfoBubbleCell.swift   | 4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Incoming/PollIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Incoming/PollIncomingBubbleCell.swift
index 61d11e642..c71810ef5 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Incoming/PollIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Incoming/PollIncomingBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import Foundation
 
-class PollIncomingBubbleCell: PollBaseBubbleCell {
+class PollIncomingBubbleCell: PollBaseBubbleCell, BubbleIncomingRoomCellProtocol {
 
     override func setupViews() {
         super.setupViews()
@@ -27,7 +27,9 @@ class PollIncomingBubbleCell: PollBaseBubbleCell {
         let messageLeftMargin: CGFloat = 48 + bubbleBackgroundSideMargin
         
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = messageViewMarginRight
-        bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin        
+        bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Outgoing/VoiceMessageOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Outgoing/VoiceMessageOutgoingWithoutSenderInfoBubbleCell.swift
index 1b18d861c..5b0bffd7e 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Outgoing/VoiceMessageOutgoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Outgoing/VoiceMessageOutgoingWithoutSenderInfoBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import Foundation
 
-class VoiceMessageOutgoingWithoutSenderInfoBubbleCell: VoiceMessageBubbleCell {
+class VoiceMessageOutgoingWithoutSenderInfoBubbleCell: VoiceMessageBubbleCell, BubbleOutgoingRoomCellProtocol {
         
     override func setupViews() {
         super.setupViews()
@@ -33,6 +33,8 @@ class VoiceMessageOutgoingWithoutSenderInfoBubbleCell: VoiceMessageBubbleCell {
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = leftMargin
                 
         playbackController.playbackView.stackViewTrailingContraint.constant = playbackViewRightMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {

From a1bf040151d71d430e76743df678c34364bc8d0d Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 19:59:35 +0100
Subject: [PATCH 23/62] Update poll bubble cells.

---
 .../Outgoing/PollOutgoingWithoutSenderInfoBubbleCell.swift    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Outgoing/PollOutgoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Outgoing/PollOutgoingWithoutSenderInfoBubbleCell.swift
index 9d5fba4d7..b16150d6c 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Outgoing/PollOutgoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Poll/Outgoing/PollOutgoingWithoutSenderInfoBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import Foundation
 
-class PollOutgoingWithoutSenderInfoBubbleCell: PollBaseBubbleCell {
+class PollOutgoingWithoutSenderInfoBubbleCell: PollBaseBubbleCell, BubbleOutgoingRoomCellProtocol {
         
     override func setupViews() {
         super.setupViews()
@@ -31,6 +31,8 @@ class PollOutgoingWithoutSenderInfoBubbleCell: PollBaseBubbleCell {
         
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = rightMargin
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = leftMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {

From db542fa582bb09145a880e6c202fc2660b927c71 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 20:03:41 +0100
Subject: [PATCH 24/62] Update file bubble cells.

---
 .../Incoming/FileWithoutThumbnailIncomingBubbleCell.swift     | 4 +++-
 ...leWithoutThumbnailOutoingWithoutSenderInfoBubbleCell.swift | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Incoming/FileWithoutThumbnailIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Incoming/FileWithoutThumbnailIncomingBubbleCell.swift
index bdc06c1ec..bcc52efa8 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Incoming/FileWithoutThumbnailIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Incoming/FileWithoutThumbnailIncomingBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import UIKit
 
-class FileWithoutThumbnailIncomingBubbleCell: FileWithoutThumbnailBaseBubbleCell {
+class FileWithoutThumbnailIncomingBubbleCell: FileWithoutThumbnailBaseBubbleCell, BubbleIncomingRoomCellProtocol {
     
     override func setupViews() {
         super.setupViews()
@@ -29,6 +29,8 @@ class FileWithoutThumbnailIncomingBubbleCell: FileWithoutThumbnailBaseBubbleCell
         
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = messageViewMarginRight
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Outgoing/FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Outgoing/FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell.swift
index 67cb6ac3a..4f2283770 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Outgoing/FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Outgoing/FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import UIKit
 
-class FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell: FileWithoutThumbnailBaseBubbleCell {
+class FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell: FileWithoutThumbnailBaseBubbleCell, BubbleOutgoingRoomCellProtocol {
     
     override func setupViews() {
         super.setupViews()
@@ -30,6 +30,8 @@ class FileWithoutThumbnailOutoingWithoutSenderInfoBubbleCell: FileWithoutThumbna
         
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = rightMargin
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = leftMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {

From 99179020cb72b841836caef2016f6fff68dc48a2 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 20:05:53 +0100
Subject: [PATCH 25/62] Update voice message cells.

---
 .../Location/Incoming/LocationIncomingBubbleCell.swift      | 2 ++
 .../Incoming/TextMessageIncomingBubbleCell.swift            | 1 -
 .../Incoming/VoiceMessageIncomingBubbleCell.swift           | 6 ++++--
 .../VoiceMessageIncomingWithPaginationTitleBubbleCell.swift | 1 +
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
index bb8287abd..4a7fb08b5 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/Location/Incoming/LocationIncomingBubbleCell.swift
@@ -27,5 +27,7 @@ class LocationIncomingBubbleCell: LocationBubbleCell, BubbleIncomingRoomCellProt
         
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = messageViewMarginRight
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin
+        
+        self.setupBubbleDecorations()
     }
 }
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
index 4f7b5ef98..7d133e2f2 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingBubbleCell.swift
@@ -44,6 +44,5 @@ class TextMessageIncomingBubbleCell: TextMessageBaseBubbleCell, BubbleIncomingRo
         let innerContentViewTrailingMargin = self.bubbleCellContentView?.innerContentViewTrailingConstraint.constant ?? 0
         
         self.textMessageContentView?.bubbleBackgroundViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right - innerContentViewTrailingMargin
-        
     }
 }
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingBubbleCell.swift
index f86756e9e..febaf8720 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingBubbleCell.swift
@@ -16,7 +16,7 @@
 
 import Foundation
 
-class VoiceMessageIncomingBubbleCell: VoiceMessageBubbleCell {
+class VoiceMessageIncomingBubbleCell: VoiceMessageBubbleCell, BubbleIncomingRoomCellProtocol {
         
     override func setupViews() {
         super.setupViews()
@@ -29,7 +29,9 @@ class VoiceMessageIncomingBubbleCell: VoiceMessageBubbleCell {
         bubbleCellContentView?.innerContentViewTrailingConstraint.constant = messageViewMarginRight
         bubbleCellContentView?.innerContentViewLeadingConstraint.constant = messageLeftMargin
         
-        playbackController.playbackView.stackViewTrailingContraint.constant = playbackViewRightMargin        
+        playbackController.playbackView.stackViewTrailingContraint.constant = playbackViewRightMargin
+        
+        self.setupBubbleDecorations()
     }
     
     override func update(theme: Theme) {
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingWithPaginationTitleBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingWithPaginationTitleBubbleCell.swift
index 9e8e6513f..bd6f1fb38 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingWithPaginationTitleBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/VoiceMessage/Incoming/VoiceMessageIncomingWithPaginationTitleBubbleCell.swift
@@ -17,6 +17,7 @@
 import Foundation
 
 class VoiceMessageIncomingWithPaginationTitleBubbleCell: VoiceMessageIncomingBubbleCell {
+    
     override func setupViews() {
         super.setupViews()
         

From 848f7f471e76fef7d7aa5483bd453ffe33be9fa5 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 20:57:18 +0100
Subject: [PATCH 26/62] RoomTimelineStyle: Add property to indicate to use
 vertical whitespace for text.

---
 .../BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift  | 3 +++
 .../BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift    | 5 ++++-
 .../Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift    | 3 +++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
index 137338e57..95d14de68 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
@@ -34,6 +34,8 @@ class BubbleRoomTimelineStyle: RoomTimelineStyle {
     
     let cellDecorator: RoomTimelineCellDecorator
     
+    let useVerticalWhiteSpaceForText: Bool
+    
     // MARK: - Setup
     
     init(theme: Theme) {
@@ -42,6 +44,7 @@ class BubbleRoomTimelineStyle: RoomTimelineStyle {
         self.cellLayoutUpdater = BubbleRoomCellLayoutUpdater(theme: theme)
         self.cellProvider = BubbleRoomTimelineCellProvider()
         self.cellDecorator = BubbleRoomTimelineCellDecorator()
+        self.useVerticalWhiteSpaceForText = false
     }
     
     // MARK: - Public
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
index f3fba9c4e..84d6f9430 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
@@ -32,7 +32,9 @@ class PlainRoomTimelineStyle: RoomTimelineStyle {
     
     let cellProvider: RoomTimelineCellProvider
     
-    let cellDecorator: RoomTimelineCellDecorator    
+    let cellDecorator: RoomTimelineCellDecorator
+    
+    let useVerticalWhiteSpaceForText: Bool
  
     // MARK: - Setup
     
@@ -42,6 +44,7 @@ class PlainRoomTimelineStyle: RoomTimelineStyle {
         self.cellLayoutUpdater = nil
         self.cellProvider = PlainRoomTimelineCellProvider()
         self.cellDecorator = PlainRoomTimelineCellDecorator()
+        self.useVerticalWhiteSpaceForText = true
     }
     
     // MARK: - Methods
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
index b430171b5..2a1874d3b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
@@ -35,6 +35,9 @@ protocol RoomTimelineStyle: Themable {
     /// Handle cell decorations (reactions, read receipts, URL preview, …)
     var cellDecorator: RoomTimelineCellDecorator { get }
     
+    /// Indicate true to make RoomBubbleCellData use vertical spaces for the attributedText
+    var useVerticalWhiteSpaceForText: Bool { get }
+    
     // MARK: - Methods
     
     /// Indicate to merge or not event in timeline

From 6e39884f42c62774069c2edaa1b7ab6ed5946b74 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 20:58:00 +0100
Subject: [PATCH 27/62] RoomBubbleCellData: Handle attributed text without
 vertical blank space.

---
 .../Room/CellData/RoomBubbleCellData.m        | 42 ++++++++++++++++---
 1 file changed, 37 insertions(+), 5 deletions(-)

diff --git a/Riot/Modules/Room/CellData/RoomBubbleCellData.m b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
index c58e14554..b964d01ff 100644
--- a/Riot/Modules/Room/CellData/RoomBubbleCellData.m
+++ b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
@@ -38,6 +38,9 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
 // Flags to "Show All" reactions for an event
 @property(nonatomic) NSMutableSet<NSString* /* eventId */> *eventsToShowAllReactions;
 
+@property (nonatomic, strong) NSAttributedString *currentAttributedTextMsg;
+@property (nonatomic, strong) NSAttributedString *currentAttributedTextMsgWithoutVertSpace;
+
 @end
 
 @implementation RoomBubbleCellData
@@ -252,12 +255,14 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
             {
                 MXLogDebug(@"[RoomBubbleCellData] attributedTextMessage called on wrong thread");
                 dispatch_sync(dispatch_get_main_queue(), ^{
-                    self.attributedTextMessage = [self makeAttributedString];
+                    [self buildAttributedString];
+                    self.attributedTextMessage = [self getAppropriatedAttributedString];
                 });
             }
             else
             {
-                self.attributedTextMessage = [self makeAttributedString];
+                [self buildAttributedString];
+                self.attributedTextMessage = [self getAppropriatedAttributedString];
             }
         }
     }
@@ -378,18 +383,37 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
     [self setNeedsUpdateAdditionalContentHeight];
 }
 
-- (NSAttributedString*)makeAttributedString
+- (NSAttributedString*)getAppropriatedAttributedString
+{
+    RoomTimelineConfiguration *timelineConfiguration = [RoomTimelineConfiguration shared];
+    
+    if (timelineConfiguration.currentStyle.useVerticalWhiteSpaceForText)
+    {
+        return self.currentAttributedTextMsg;
+    }
+    else
+    {
+        return self.currentAttributedTextMsgWithoutVertSpace;
+    }
+}
+
+- (void)buildAttributedString
 {
     // CAUTION: This method must be called on the main thread.
 
     // Return the collapsed string only for cells series header
     if (self.collapsed && self.collapsedAttributedTextMessage && self.nextCollapsableCellData)
     {
-        return super.collapsedAttributedTextMessage;
+        self.currentAttributedTextMsg =  super.collapsedAttributedTextMessage;
+        self.currentAttributedTextMsgWithoutVertSpace = super.collapsedAttributedTextMessage;
+        
+        return;
     }
 
     NSMutableAttributedString *currentAttributedTextMsg;
     
+    NSMutableAttributedString *currentAttributedTextMsgWithoutVertSpace = [NSMutableAttributedString new];
+    
     NSInteger selectedComponentIndex = self.selectedComponentIndex;
     NSInteger lastMessageIndex = self.containsLastMessage ? self.mostRecentComponentIndex : NSNotFound;
     
@@ -416,11 +440,15 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
             {
                 currentAttributedTextMsg = [[NSMutableAttributedString alloc] initWithAttributedString:[RoomBubbleCellData timestampVerticalWhitespace]];
                 [currentAttributedTextMsg appendAttributedString:componentString];
+                
+                [currentAttributedTextMsgWithoutVertSpace appendAttributedString:componentString];
             }
             else
             {
                 // Init attributed string with the first text component
                 currentAttributedTextMsg = [[NSMutableAttributedString alloc] initWithAttributedString:componentString];
+                
+                [currentAttributedTextMsgWithoutVertSpace appendAttributedString:componentString];
             }
 
             [self addVerticalWhitespaceToString:currentAttributedTextMsg forEvent:component.event.eventId];
@@ -456,10 +484,14 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
             [currentAttributedTextMsg appendAttributedString:componentString];
             
             [self addVerticalWhitespaceToString:currentAttributedTextMsg forEvent:component.event.eventId];
+            
+            [currentAttributedTextMsgWithoutVertSpace appendAttributedString:componentString];
         }
     }
     
-    return currentAttributedTextMsg;
+    self.currentAttributedTextMsg = currentAttributedTextMsg;
+    
+    self.currentAttributedTextMsgWithoutVertSpace = currentAttributedTextMsgWithoutVertSpace;
 }
 
 - (NSInteger)firstVisibleComponentIndex

From ba2520ac9cfa38bbd267e13c79e43d47381601d4 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 21:47:36 +0100
Subject: [PATCH 28/62] BubbleCellContentView: Update read receipts view
 height.

---
 .../BubbleCells/BaseBubbleCell/BubbleCellContentView.xib    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 580be3744..358fe461b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -178,12 +178,13 @@
                             </constraints>
                         </view>
                         <view hidden="YES" contentMode="scaleToFill" verticalHuggingPriority="253" translatesAutoresizingMaskIntoConstraints="NO" id="4zo-V8-CNe">
-                            <rect key="frame" x="0.0" y="0.0" width="595" height="12"/>
+                            <rect key="frame" x="0.0" y="0.0" width="595" height="16"/>
                             <subviews>
                                 <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="rQt-NH-Cb0">
-                                    <rect key="frame" x="439" y="0.0" width="150" height="12"/>
+                                    <rect key="frame" x="439" y="0.0" width="150" height="16"/>
                                     <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
                                     <constraints>
+                                        <constraint firstAttribute="height" constant="16" id="WZx-xk-gav"/>
                                         <constraint firstAttribute="width" constant="150" id="fsY-DK-hUg"/>
                                     </constraints>
                                 </view>
@@ -192,7 +193,6 @@
                             <constraints>
                                 <constraint firstAttribute="bottom" secondItem="rQt-NH-Cb0" secondAttribute="bottom" id="6yV-vn-doj"/>
                                 <constraint firstItem="rQt-NH-Cb0" firstAttribute="top" secondItem="4zo-V8-CNe" secondAttribute="top" id="DNc-jy-Urh"/>
-                                <constraint firstAttribute="height" constant="12" id="TxZ-dJ-UI6"/>
                                 <constraint firstAttribute="trailing" secondItem="rQt-NH-Cb0" secondAttribute="trailing" constant="6" id="lq2-AY-Lus"/>
                             </constraints>
                         </view>

From 1366a4a836f157fa03c6c38bfc08ccf9a1765c45 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Mon, 7 Feb 2022 22:22:18 +0100
Subject: [PATCH 29/62] Message bubble: Improve thread summary positioning.

---
 .../BubbleCells/BaseBubbleCell/BubbleCellContentView.swift   | 5 +++--
 .../BubbleCells/BaseBubbleCell/BubbleCellContentView.xib     | 1 +
 .../Views/BubbleCells/SizableCell/SizableBubbleCell.swift    | 4 ++++
 .../Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift | 2 ++
 .../Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift | 4 ++++
 5 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
index 2184eb435..79215fd9e 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
@@ -63,6 +63,7 @@ final class BubbleCellContentView: UIView, NibLoadable {
     @IBOutlet weak var threadSummaryContentView: UIView!
     @IBOutlet weak var threadSummaryContentViewLeadingConstraint: NSLayoutConstraint!
     @IBOutlet weak var threadSummaryContentViewTrailingConstraint: NSLayoutConstraint!
+    @IBOutlet weak var threadSummaryContentViewBottomConstraint: NSLayoutConstraint!
     
     @IBOutlet weak var bubbleOverlayContainer: UIView!
     
@@ -223,9 +224,9 @@ extension BubbleCellContentView: BubbleCellThreadSummaryDisplayable {
         
         NSLayoutConstraint.activate([
             leadingConstraint,
-            threadSummaryView.topAnchor.constraint(equalTo: threadSummaryContainerView.topAnchor),
+            threadSummaryView.topAnchor.constraint(equalTo: containerView.topAnchor),
             threadSummaryView.heightAnchor.constraint(equalToConstant: RoomBubbleCellLayout.threadSummaryViewHeight),
-            threadSummaryView.bottomAnchor.constraint(equalTo: threadSummaryContainerView.bottomAnchor),
+            threadSummaryView.bottomAnchor.constraint(equalTo: containerView.bottomAnchor),
             trailingConstraint
         ])
         
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 358fe461b..231f9dfd3 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -284,6 +284,7 @@
                 <outlet property="senderInfoContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="threadSummaryContainerView" destination="2eB-kB-m20" id="0Y4-4E-I9K"/>
                 <outlet property="threadSummaryContentView" destination="snf-Ea-To0" id="6Oo-Gj-e4Z"/>
+                <outlet property="threadSummaryContentViewBottomConstraint" destination="4tt-w0-4JE" id="6db-Jz-jys"/>
                 <outlet property="threadSummaryContentViewLeadingConstraint" destination="2lm-T3-dEu" id="jR6-sh-Nul"/>
                 <outlet property="threadSummaryContentViewTrailingConstraint" destination="Qwm-Of-Zgc" id="dfE-aR-MQQ"/>
                 <outlet property="urlPreviewContainerView" destination="57V-Sl-EmD" id="9c6-ai-BY8"/>
diff --git a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
index d5b1ccb4f..04bb6393c 100644
--- a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
@@ -137,7 +137,11 @@ class SizableBaseBubbleCell: BaseBubbleCell, SizableBaseBubbleCellType {
         if sizingView is BubbleCellThreadSummaryDisplayable,
            let roomBubbleCellData = cellData as? RoomBubbleCellData,
            roomBubbleCellData.hasThreadRoot {
+            
+            let bottomMargin = sizingView.bubbleCellContentView?.threadSummaryContentViewBottomConstraint.constant ?? 0
+            
             height += RoomBubbleCellLayout.threadSummaryViewHeight
+            height += bottomMargin
         }
         
         // Add URL preview view height if needed
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
index 5f58fb65b..32597da8e 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleIncomingRoomCellProtocol.swift
@@ -44,6 +44,8 @@ extension BubbleIncomingRoomCellProtocol {
     
     private func setupThreadSummaryViewContentViewContraints() {
         self.bubbleCellContentView?.threadSummaryContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.incomingBubbleBackgroundMargins.right
+        
+        self.bubbleCellContentView?.threadSummaryContentViewBottomConstraint.constant = BubbleRoomCellLayoutConstants.threadSummaryViewMargins.bottom
     }
     
     private func setupURLPreviewContentViewContraints() {
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
index a9e5cd2bc..2c548f80b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/BubbleOutgoingRoomCellProtocol.swift
@@ -80,6 +80,10 @@ extension BubbleOutgoingRoomCellProtocol {
         // Update trailing constraint
                                 
         bubbleCellContentView.threadSummaryContentViewTrailingConstraint.constant = BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.right
+        
+        // Update bottom constraint
+                
+        bubbleCellContentView.threadSummaryContentViewBottomConstraint.constant = BubbleRoomCellLayoutConstants.threadSummaryViewMargins.bottom
     }
     
     private func setupURLPreviewContentViewContraints() {

From 565a90c76d181b635c43d361f6e01daadd7126cd Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 07:01:58 +0100
Subject: [PATCH 30/62] BubbleCellContentView: Update decorations order.

---
 .../BaseBubbleCell/BubbleCellContentView.xib  | 36 +++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 231f9dfd3..76b03d2c5 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -177,6 +177,24 @@
                                 <constraint firstItem="vpX-Nl-AEt" firstAttribute="top" secondItem="57V-Sl-EmD" secondAttribute="top" id="sFV-XK-lE4"/>
                             </constraints>
                         </view>
+                        <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" verticalHuggingPriority="252" translatesAutoresizingMaskIntoConstraints="NO" id="Dj1-m6-1Jw">
+                            <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
+                            <subviews>
+                                <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="SNw-aM-ILI">
+                                    <rect key="frame" x="56" y="0.0" width="524" height="0.0"/>
+                                    <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                                    <constraints>
+                                        <constraint firstAttribute="height" priority="250" placeholder="YES" id="kBO-PM-cjY"/>
+                                    </constraints>
+                                </view>
+                            </subviews>
+                            <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                            <constraints>
+                                <constraint firstItem="SNw-aM-ILI" firstAttribute="top" secondItem="Dj1-m6-1Jw" secondAttribute="top" id="1PE-go-s7Z"/>
+                                <constraint firstAttribute="bottom" secondItem="SNw-aM-ILI" secondAttribute="bottom" id="SBT-1C-CPb"/>
+                                <constraint firstAttribute="trailing" secondItem="SNw-aM-ILI" secondAttribute="trailing" constant="15" id="ynR-d4-6cf"/>
+                            </constraints>
+                        </view>
                         <view hidden="YES" contentMode="scaleToFill" verticalHuggingPriority="253" translatesAutoresizingMaskIntoConstraints="NO" id="4zo-V8-CNe">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="16"/>
                             <subviews>
@@ -196,24 +214,6 @@
                                 <constraint firstAttribute="trailing" secondItem="rQt-NH-Cb0" secondAttribute="trailing" constant="6" id="lq2-AY-Lus"/>
                             </constraints>
                         </view>
-                        <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" verticalHuggingPriority="252" translatesAutoresizingMaskIntoConstraints="NO" id="Dj1-m6-1Jw">
-                            <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
-                            <subviews>
-                                <view clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="SNw-aM-ILI">
-                                    <rect key="frame" x="56" y="0.0" width="524" height="0.0"/>
-                                    <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                    <constraints>
-                                        <constraint firstAttribute="height" priority="250" placeholder="YES" id="kBO-PM-cjY"/>
-                                    </constraints>
-                                </view>
-                            </subviews>
-                            <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                            <constraints>
-                                <constraint firstItem="SNw-aM-ILI" firstAttribute="top" secondItem="Dj1-m6-1Jw" secondAttribute="top" id="1PE-go-s7Z"/>
-                                <constraint firstAttribute="bottom" secondItem="SNw-aM-ILI" secondAttribute="bottom" id="SBT-1C-CPb"/>
-                                <constraint firstAttribute="trailing" secondItem="SNw-aM-ILI" secondAttribute="trailing" constant="15" id="ynR-d4-6cf"/>
-                            </constraints>
-                        </view>
                         <view hidden="YES" clipsSubviews="YES" contentMode="scaleAspectFit" translatesAutoresizingMaskIntoConstraints="NO" id="2eB-kB-m20">
                             <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
                             <subviews>

From c9075dda57dd186e8cce25c46614e578b914c0e5 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 07:02:53 +0100
Subject: [PATCH 31/62] SizableBaseBubbleCell: Add workaround for reactions
 height miscalculation.

---
 .../Views/BubbleCells/SizableCell/SizableBubbleCell.swift    | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
index 04bb6393c..634aae019 100644
--- a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
@@ -131,6 +131,11 @@ class SizableBaseBubbleCell: BaseBubbleCell, SizableBaseBubbleCellType {
             
             let reactionsHeight = self.reactionsViewSizer.height(for: bubbleReactionsViewModel, fittingWidth: reactionWidth)
             height+=reactionsHeight
+            
+            // FIXME: Sized is always 24.0 pts too high when the reaction height is 49.0 pts high
+            if height > 48.0 {
+                height-=24
+            }
         }
 
         // Add thread summary view height if needed

From 4d1c7677dead7f275bf99b9c8c02f8218c500674 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 07:03:51 +0100
Subject: [PATCH 32/62] TextMessageBaseBubbleCell: Update add timestamp.

---
 .../Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift
index 3e1936276..f64e0d873 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Common/TextMessageBaseBubbleCell.swift
@@ -85,6 +85,7 @@ class TextMessageBaseBubbleCell: SizableBaseBubbleCell, RoomCellURLPreviewDispla
         
         self.bubbleCellContentView?.reactionsContainerView.layer.borderColor = UIColor.blue.cgColor
         self.bubbleCellContentView?.reactionsContainerView.layer.borderWidth = 1.0
+        self.bubbleCellContentView?.reactionsContentView.backgroundColor = .blue
         
         self.bubbleCellContentView?.threadSummaryContainerView.layer.borderColor = UIColor.purple.cgColor
         self.bubbleCellContentView?.threadSummaryContainerView.layer.borderWidth = 1.0
@@ -98,6 +99,7 @@ extension TextMessageBaseBubbleCell: TimestampDisplayable {
         guard let messageBubbleBackgroundView = self.textMessageContentView?.bubbleBackgroundView else {
             return
         }
+        messageBubbleBackgroundView.removeTimestampView()
         messageBubbleBackgroundView.addTimestampView(timestampView)
     }
     

From 92a5e1bddbf63f2a82af80dda28c1c7fda4dcbc6 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 07:04:33 +0100
Subject: [PATCH 33/62] BubbleRoomCellLayoutConstants: Add thread constant.

---
 .../Styles/Bubble/BubbleRoomCellLayoutConstants.swift           | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift
index 2d6265007..2a978f82d 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutConstants.swift
@@ -24,4 +24,6 @@ final class BubbleRoomCellLayoutConstants: NSObject {
     static let outgoingBubbleBackgroundMargins: UIEdgeInsets = UIEdgeInsets(top: 0, left: 80, bottom: 0, right: 34)
 
     static let incomingBubbleBackgroundMargins: UIEdgeInsets = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: 80)
+    
+    static let threadSummaryViewMargins: UIEdgeInsets = UIEdgeInsets(top: 0, left: 0, bottom: 5, right: 0)
 }

From 74a29ccfc468fc9d090defb864a815852409f24a Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 07:06:36 +0100
Subject: [PATCH 34/62] RoomDataSource: Apply theme if needed.

---
 Riot/Modules/Room/DataSources/RoomDataSource.m | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Riot/Modules/Room/DataSources/RoomDataSource.m b/Riot/Modules/Room/DataSources/RoomDataSource.m
index da550e643..f4561638f 100644
--- a/Riot/Modules/Room/DataSources/RoomDataSource.m
+++ b/Riot/Modules/Room/DataSources/RoomDataSource.m
@@ -668,6 +668,13 @@ const CGFloat kTypingCellHeight = 24;
         // Make extra cell layout updates if needed
         [self updateCellLayoutIfNeeded:bubbleCell withCellData:cellData];
     }
+    
+    if ([cell conformsToProtocol:@protocol(Themable)])
+    {
+        id<Themable> cellThemable = (id<Themable>)cell;
+
+        [cellThemable updateWithTheme:ThemeService.shared.theme];
+    }
 
     return cell;
 }

From e9ce1969c154869b305c686db1b433feb493aeab Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 09:31:52 +0100
Subject: [PATCH 35/62] FileWithoutThumbnailBaseBubbleCell: Fix text color.

---
 .../Common/FileWithoutThumbnailBaseBubbleCell.swift  |  2 +-
 .../Common/FileWithoutThumbnailCellContentView.swift | 12 +-----------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
index 65183f299..ee6d67798 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
@@ -27,7 +27,7 @@ class FileWithoutThumbnailBaseBubbleCell: SizableBaseBubbleCell, BubbleCellReact
             return
         }
         
-        self.fileAttachementView?.title = data.attributedTextMessage.string
+        self.fileAttachementView?.titleLabel.attributedText = data.attributedTextMessage
         
         self.update(theme: ThemeService.shared().theme)
     }
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailCellContentView.swift
index 14dd3c7fa..ce0471dad 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailCellContentView.swift
@@ -31,7 +31,7 @@ final class FileWithoutThumbnailCellContentView: UIView, NibLoadable {
     // MARK: Outlets
     
     @IBOutlet private weak var iconImageView: UIImageView!
-    @IBOutlet private weak var titleLabel: UILabel!
+    @IBOutlet private(set) weak var titleLabel: UILabel!
     
     // MARK: Public
     
@@ -44,15 +44,6 @@ final class FileWithoutThumbnailCellContentView: UIView, NibLoadable {
         }
     }
     
-    var title: String? {
-        get {
-            return self.titleLabel.text
-        }
-        set {
-            self.titleLabel.text = newValue
-        }
-    }
-    
     // MARK: - Setup
     
     static func instantiate() -> FileWithoutThumbnailCellContentView {
@@ -79,4 +70,3 @@ final class FileWithoutThumbnailCellContentView: UIView, NibLoadable {
         self.titleLabel.textColor = theme.textPrimaryColor
     }
 }
-

From 330a93e637ecc85077e583abe6e7e0da7c5d6b76 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 10:10:24 +0100
Subject: [PATCH 36/62] SizableBaseBubbleCell: Remove reactions height fix.

---
 .../Views/BubbleCells/SizableCell/SizableBubbleCell.swift   | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
index 634aae019..99aa2af4a 100644
--- a/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/SizableCell/SizableBubbleCell.swift
@@ -15,6 +15,7 @@
  */
 
 import UIKit
+import MatrixSDK
 
 @objc protocol SizableBaseBubbleCellType: BaseBubbleCellType {
     static func sizingViewHeightHashValue(from bubbleCellData: MXKRoomBubbleCellData) -> Int
@@ -131,11 +132,6 @@ class SizableBaseBubbleCell: BaseBubbleCell, SizableBaseBubbleCellType {
             
             let reactionsHeight = self.reactionsViewSizer.height(for: bubbleReactionsViewModel, fittingWidth: reactionWidth)
             height+=reactionsHeight
-            
-            // FIXME: Sized is always 24.0 pts too high when the reaction height is 49.0 pts high
-            if height > 48.0 {
-                height-=24
-            }
         }
 
         // Add thread summary view height if needed

From 8cd8b132626313de391ce5258b029cacc9e270ec Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 11:16:38 +0100
Subject: [PATCH 37/62] BubbleRoomTimelineCellDecorator: Update tempary views
 management.

---
 .../Styles/Bubble/BubbleRoomTimelineCellDecorator.swift   | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
index 9a2decc63..61b608910 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
@@ -96,13 +96,13 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
     override func addReactionView(_ reactionsView: BubbleReactionsView,
                                   toCell cell: MXKRoomBubbleTableViewCell, cellData: RoomBubbleCellData, contentViewPositionY: CGFloat, upperDecorationView: UIView?) {
         
-        cell.addTemporarySubview(reactionsView)
-        
         if let reactionsDisplayable = cell as? BubbleCellReactionsDisplayable {
             reactionsDisplayable.addReactionsView(reactionsView)
             return
         }
         
+        cell.addTemporarySubview(reactionsView)
+        
         reactionsView.translatesAutoresizingMaskIntoConstraints = false
         
         let cellContentView = cell.contentView
@@ -221,11 +221,11 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
                               contentViewPositionY: CGFloat,
                               upperDecorationView: UIView?) {
 
-        cell.addTemporarySubview(threadSummaryView)
-
         if let threadSummaryDisplayable = cell as? BubbleCellThreadSummaryDisplayable {
             threadSummaryDisplayable.addThreadSummaryView(threadSummaryView)
         } else {
+            
+            cell.addTemporarySubview(threadSummaryView)
             threadSummaryView.translatesAutoresizingMaskIntoConstraints = false
 
             let cellContentView = cell.contentView

From d2d3d67dbe959d85ecf00c36886cc645969d5b9f Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 11:17:06 +0100
Subject: [PATCH 38/62] RoomBubbleCellData: Fix quote for bubbles.

---
 Riot/Modules/Room/CellData/RoomBubbleCellData.m | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Riot/Modules/Room/CellData/RoomBubbleCellData.m b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
index b964d01ff..8d441d527 100644
--- a/Riot/Modules/Room/CellData/RoomBubbleCellData.m
+++ b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
@@ -489,6 +489,13 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
         }
     }
     
+    // With bubbles the text is truncated with quote messages containing vertical border view
+    // Add horizontal space to fix the issue
+    if (self.displayFix & MXKRoomBubbleComponentDisplayFixHtmlBlockquote)
+    {
+        [currentAttributedTextMsgWithoutVertSpace appendString:@"       "];
+    }
+    
     self.currentAttributedTextMsg = currentAttributedTextMsg;
     
     self.currentAttributedTextMsgWithoutVertSpace = currentAttributedTextMsgWithoutVertSpace;

From 5883d7382e5f244becf8a0f06e66f0acd3f55f17 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 11:44:52 +0100
Subject: [PATCH 39/62] RoomTimelineCellIdentifier: Add dedicated identifiers
 for emote.

---
 .../BubbleCells/RoomTimelineCellIdentifier.h  | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/RoomTimelineCellIdentifier.h b/Riot/Modules/Room/Views/BubbleCells/RoomTimelineCellIdentifier.h
index f461504de..fafce9df7 100644
--- a/Riot/Modules/Room/Views/BubbleCells/RoomTimelineCellIdentifier.h
+++ b/Riot/Modules/Room/Views/BubbleCells/RoomTimelineCellIdentifier.h
@@ -47,6 +47,34 @@ typedef NS_ENUM(NSUInteger, RoomTimelineCellIdentifier) {
     RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderName,
     RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitleWithoutSenderName,
     
+    // - Emote
+    // -- Incoming
+    // --- Clear
+    RoomTimelineCellIdentifierIncomingEmote,
+    RoomTimelineCellIdentifierIncomingEmoteWithoutSenderInfo,
+    RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitle,
+    RoomTimelineCellIdentifierIncomingEmoteWithoutSenderName,
+    RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitleWithoutSenderName,
+    // --- Encrypted
+    RoomTimelineCellIdentifierIncomingEmoteEncrypted,
+    RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderInfo,
+    RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitle,
+    RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderName,
+    RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitleWithoutSenderName,
+    // -- Outgoing
+    // --- Clear
+    RoomTimelineCellIdentifierOutgoingEmote,
+    RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderInfo,
+    RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitle,
+    RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderName,
+    RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitleWithoutSenderName,
+    // --- Encrypted
+    RoomTimelineCellIdentifierOutgoingEmoteEncrypted,
+    RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderInfo,
+    RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitle,
+    RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderName,
+    RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitleWithoutSenderName,
+    
     // - Attachment
     // -- Incoming
     // --- Clear

From f472cde90930bd86c89621ba25a70aa58b1a0214 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 11:45:20 +0100
Subject: [PATCH 40/62] PlainRoomTimelineCellProvider: Handle emote cells.

---
 .../Plain/PlainRoomTimelineCellProvider.m     | 43 +++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.m b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.m
index 6b5339bfa..0a68e6609 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.m
@@ -275,6 +275,13 @@
     NSDictionary *outgoingTextMessageCellsMapping = [self outgoingTextMessageCellsMapping];
     [cellClasses addEntriesFromDictionary:outgoingTextMessageCellsMapping];
     
+    // Emote
+    NSDictionary *incomingEmoteCellsMapping = [self incomingEmoteCellsMapping];
+    [cellClasses addEntriesFromDictionary:incomingEmoteCellsMapping];
+    
+    NSDictionary *outgoingEmoteCellsMapping = [self outgoingEmoteCellsMapping];
+    [cellClasses addEntriesFromDictionary:outgoingEmoteCellsMapping];
+    
     // Attachment
     
     NSDictionary *incomingAttachmentCellsMapping = [self incomingAttachmentCellsMapping];
@@ -360,6 +367,42 @@
     };
 }
 
+- (NSDictionary<NSNumber*, Class>*)incomingEmoteCellsMapping
+{
+    return @{
+        // Clear
+        @(RoomTimelineCellIdentifierIncomingEmote) : RoomIncomingTextMsgBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithoutSenderInfo) : RoomIncomingTextMsgWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitle) : RoomIncomingTextMsgWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithoutSenderName) : RoomIncomingTextMsgWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitleWithoutSenderName) : RoomIncomingTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+        // Encrypted
+        @(RoomTimelineCellIdentifierIncomingEmoteEncrypted) : RoomIncomingEncryptedTextMsgBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderInfo) : RoomIncomingEncryptedTextMsgWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitle) : RoomIncomingEncryptedTextMsgWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderName) : RoomIncomingEncryptedTextMsgWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitleWithoutSenderName) : RoomIncomingEncryptedTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+    };
+}
+
+- (NSDictionary<NSNumber*, Class>*)outgoingEmoteCellsMapping
+{
+    return @{
+        // Clear
+        @(RoomTimelineCellIdentifierOutgoingEmote) : RoomOutgoingTextMsgBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderInfo) : RoomOutgoingTextMsgWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitle) : RoomOutgoingTextMsgWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderName) : RoomOutgoingTextMsgWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitleWithoutSenderName) : RoomOutgoingTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+        // Encrypted
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncrypted) : RoomOutgoingEncryptedTextMsgBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderInfo) : RoomOutgoingEncryptedTextMsgWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitle) : RoomOutgoingEncryptedTextMsgWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderName) : RoomOutgoingEncryptedTextMsgWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitleWithoutSenderName) : RoomOutgoingEncryptedTextMsgWithPaginationTitleWithoutSenderNameBubbleCell.class,
+    };
+}
+
 - (NSDictionary<NSNumber*, Class>*)incomingAttachmentCellsMapping
 {
     return @{

From 8947fd654975da3de00c2cf860464ffc3caa1d57 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 11:57:45 +0100
Subject: [PATCH 41/62] RoomVC: Handle emote cell identifiers.

---
 Riot/Modules/Room/RoomViewController.m | 55 ++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/Riot/Modules/Room/RoomViewController.m b/Riot/Modules/Room/RoomViewController.m
index 2881e29cb..ce081145f 100644
--- a/Riot/Modules/Room/RoomViewController.m
+++ b/Riot/Modules/Room/RoomViewController.m
@@ -2813,6 +2813,61 @@ const NSTimeInterval kResizeComposerAnimationDuration = .05;
             }
         }
     }
+    else if (roomBubbleCellData.getFirstBubbleComponentWithDisplay.event.isEmote)
+    {
+        if (bubbleData.isIncoming)
+        {
+            if (bubbleData.isPaginationFirstBubble)
+            {
+                if (bubbleData.shouldHideSenderName)
+                {
+                    cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitleWithoutSenderName : RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitleWithoutSenderName;
+                }
+                else
+                {
+                    cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitle : RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitle;
+                }
+            }
+            else if (bubbleData.shouldHideSenderInformation)
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderInfo : RoomTimelineCellIdentifierIncomingEmoteWithoutSenderInfo;
+            }
+            else if (bubbleData.shouldHideSenderName)
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderName : RoomTimelineCellIdentifierIncomingEmoteWithoutSenderName;
+            }
+            else
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierIncomingEmoteEncrypted : RoomTimelineCellIdentifierIncomingEmote;
+            }
+        }
+        else
+        {
+            if (bubbleData.isPaginationFirstBubble)
+            {
+                if (bubbleData.shouldHideSenderName)
+                {
+                    cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitleWithoutSenderName : RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitleWithoutSenderName;
+                }
+                else
+                {
+                    cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitle : RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitle;
+                }
+            }
+            else if (bubbleData.shouldHideSenderInformation)
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderInfo : RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderInfo;
+            }
+            else if (bubbleData.shouldHideSenderName)
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderName : RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderName;
+            }
+            else
+            {
+                cellIdentifier = showEncryptionBadge ? RoomTimelineCellIdentifierOutgoingEmoteEncrypted : RoomTimelineCellIdentifierOutgoingEmote;
+            }
+        }
+    }
     else if (bubbleData.isIncoming)
     {
         if (bubbleData.isAttachmentWithThumbnail)

From a405330d682f35cfc4735a83eef5ded0f4826828 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 15:04:07 +0100
Subject: [PATCH 42/62] BubbleRoomCellLayoutUpdater: Update plain text cell
 margins and remove unused code.

---
 .../Bubble/BubbleRoomCellLayoutUpdater.swift  | 176 +-----------------
 1 file changed, 7 insertions(+), 169 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
index b4c2a1c80..ce7808314 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
@@ -50,40 +50,16 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
             
     func updateLayout(forIncomingTextMessageCell cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) {
         
-        if let messageBubbleBackgroundView = cell.messageBubbleBackgroundView {
-            
-            if self.canUseBubbleBackground(forCell: cell, withCellData: cellData) {
-                
-                messageBubbleBackgroundView.isHidden = false
-                
-                self.updateMessageBubbleBackgroundView(messageBubbleBackgroundView, withCell: cell, andCellData: cellData)
-            } else {
-                messageBubbleBackgroundView.isHidden = true
-            }
-        }
     }
     
     func updateLayout(forOutgoingTextMessageCell cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) {
 
-        if let messageBubbleBackgroundView = cell.messageBubbleBackgroundView {
-            
-            if self.canUseBubbleBackground(forCell: cell, withCellData: cellData) {
-                
-                messageBubbleBackgroundView.isHidden = false
-                
-                self.updateMessageBubbleBackgroundView(messageBubbleBackgroundView, withCell: cell, andCellData: cellData)
-            } else {
-                messageBubbleBackgroundView.isHidden = true
-            }
-        }
     }
     
     func setupLayout(forIncomingTextMessageCell cell: MXKRoomBubbleTableViewCell) {
         
         self.setupIncomingMessageTextViewMargins(for: cell)
         
-        self.addBubbleBackgroundViewToCell(cell, backgroundColor: self.incomingColor)
-        
         cell.setNeedsUpdateConstraints()
     }
     
@@ -94,8 +70,6 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         // Hide avatar view
         cell.pictureView?.isHidden = true
         
-        self.addBubbleBackgroundViewToCell(cell, backgroundColor: self.outgoingColor)
-        
         cell.setNeedsUpdateConstraints()
     }
     
@@ -131,152 +105,15 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
     
     // MARK: - Private
     
-    // MARK: Bubble background view
-    
-    private func createBubbleBackgroundView(with backgroundColor: UIColor) -> RoomMessageBubbleBackgroundView {
-        
-        let bubbleBackgroundView = RoomMessageBubbleBackgroundView()
-        bubbleBackgroundView.backgroundColor = backgroundColor
-        
-        return bubbleBackgroundView
-    }
-    
-    private func addBubbleBackgroundViewToCell(_ bubbleCell: MXKRoomBubbleTableViewCell, backgroundColor: UIColor) {
-        
-        guard let messageTextView =  bubbleCell.messageTextView else {
-            return
-        }
-        
-        let topMargin: CGFloat = 0.0
-        let leftMargin: CGFloat = 5.0
-        let rightMargin: CGFloat = 45.0 // Add extra space for timestamp
-                        
-        let bubbleBackgroundView = self.createBubbleBackgroundView(with: backgroundColor)
-        
-        bubbleCell.contentView.insertSubview(bubbleBackgroundView, at: 0)
-        
-        let topAnchor = messageTextView.topAnchor
-        let leadingAnchor = messageTextView.leadingAnchor
-        let trailingAnchor = messageTextView.trailingAnchor
-        
-        bubbleBackgroundView.updateHeight(messageTextView.frame.height)
-        
-        NSLayoutConstraint.activate([
-            bubbleBackgroundView.topAnchor.constraint(equalTo: topAnchor, constant: topMargin),
-            bubbleBackgroundView.leadingAnchor.constraint(equalTo: leadingAnchor, constant: -leftMargin),
-            bubbleBackgroundView.trailingAnchor.constraint(equalTo: trailingAnchor, constant: rightMargin)
-        ])
-    }
-    
-    private func canUseBubbleBackground(forCell cell: MXKRoomBubbleTableViewCell, withCellData cellData: MXKRoomBubbleCellData) -> Bool {
-
-        guard let firstComponent = cellData.getFirstBubbleComponentWithDisplay(), let firstEvent = firstComponent.event else {
-            return false
-        }
-        
-        switch firstEvent.eventType {
-        case .roomMessage:
-            if let messageType = firstEvent.messageType {
-                switch messageType {
-                case .text, .file:
-                    return true
-                case .emote:
-                    // Explicitely disable bubble for emotes
-                    return false                    
-                default:
-                    break
-                }
-            }
-        default:
-            break
-        }
-        
-        return false
-    }
-    
-    private func getTextMessageHeight(for cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) -> CGFloat? {
-
-        guard let roomBubbleCellData = cellData as? RoomBubbleCellData,
-                let lastBubbleComponent = cellData.getLastBubbleComponentWithDisplay(),
-                let firstComponent = roomBubbleCellData.getFirstBubbleComponentWithDisplay() else {
-            return nil
-        }
-
-        let bubbleHeight: CGFloat
-
-        let lastEventId = lastBubbleComponent.event.eventId
-        let lastMessageBottomPosition = cell.bottomPosition(ofEvent: lastEventId)
-
-        let firstEventId = firstComponent.event.eventId
-        let firstMessageTopPosition = cell.topPosition(ofEvent: firstEventId)
-
-        let additionalContentHeight = roomBubbleCellData.additionalContentHeight
-
-        bubbleHeight = lastMessageBottomPosition - firstMessageTopPosition - additionalContentHeight
-
-        guard bubbleHeight >= 0 else {
-            return nil
-        }
-
-        return bubbleHeight
-    }
-    
-    // TODO: Improve text message height calculation
-    // This method is closer to final result but lack of stability because of extra vertical space not handled here.
-//    private func getTextMessageHeight(for cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) -> CGFloat? {
-//
-//        guard let roomBubbleCellData = cellData as? RoomBubbleCellData,
-//              let firstComponent = roomBubbleCellData.getFirstBubbleComponentWithDisplay() else {
-//                  return nil
-//              }
-//
-//        let bubbleHeight: CGFloat
-//
-//        let componentIndex = cellData.bubbleComponentIndex(forEventId: firstComponent.event.eventId)
-//
-//        let componentFrame = cell.componentFrameInContentView(for: componentIndex)
-//
-//        bubbleHeight = componentFrame.height
-//
-//        guard bubbleHeight >= 0 else {
-//            return nil
-//        }
-//
-//        return bubbleHeight
-//    }
-    
-    private func getMessageBubbleBackgroundHeight(for cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) -> CGFloat? {
-
-        var finalBubbleHeight: CGFloat?
-        let extraMargin: CGFloat = 4.0
-
-        if let bubbleHeight = self.getTextMessageHeight(for: cell, andCellData: cellData) {
-            finalBubbleHeight = bubbleHeight + extraMargin
-
-        } else if let messageTextViewHeight = cell.messageTextView?.frame.height {
-
-            finalBubbleHeight = messageTextViewHeight + extraMargin
-        }
-
-        return finalBubbleHeight
-    }
-    
-    @discardableResult
-    private func updateMessageBubbleBackgroundView(_ roomMessageBubbleBackgroundView: RoomMessageBubbleBackgroundView, withCell cell: MXKRoomBubbleTableViewCell, andCellData cellData: MXKRoomBubbleCellData) -> Bool {
-        
-        if let bubbleHeight = self.getMessageBubbleBackgroundHeight(for: cell, andCellData: cellData) {
-            return roomMessageBubbleBackgroundView.updateHeight(bubbleHeight)
-        } else {
-            return false
-        }
-    }
+    // MARK: Text message
     
     private func getIncomingMessageTextViewInsets(from bubbleCell: MXKRoomBubbleTableViewCell) -> UIEdgeInsets {
         
+        let bubbleBgRightMargin: CGFloat = 45
         let messageViewMarginTop: CGFloat
         let messageViewMarginBottom: CGFloat = -2.0
         let messageViewMarginLeft: CGFloat = 3.0
-        let messageViewMarginRight: CGFloat = 80
+        let messageViewMarginRight: CGFloat = 80 + bubbleBgRightMargin
         
         if bubbleCell.userNameLabel != nil {
             messageViewMarginTop = 10.0
@@ -289,8 +126,6 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         return messageViewInsets
     }
     
-    // MARK: Text message
-    
     private func setupIncomingMessageTextViewMargins(for cell: MXKRoomBubbleTableViewCell) {
         
         guard cell.messageTextView != nil else {
@@ -313,7 +148,8 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         
         let contentView = cell.contentView
         
-        let leftMargin: CGFloat = 80.0
+        let innerContentLeftMargin: CGFloat = 57
+        let leftMargin: CGFloat = 80.0 + innerContentLeftMargin
         let rightMargin: CGFloat = 78.0
         let bottomMargin: CGFloat = -2.0
         
@@ -335,6 +171,8 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         cell.msgTextViewBottomConstraint.constant += bottomMargin
     }
     
+    // MARK: File attachment
+    
     private func setupOutgoingFileAttachViewMargins(for cell: MXKRoomBubbleTableViewCell) {
         
         guard let attachmentView = cell.attachmentView else {

From a3b9b23b3ae54166879a6fca09fdeaf349201baa Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Tue, 8 Feb 2022 15:10:34 +0100
Subject: [PATCH 43/62] BaseBubbleCell: Fix decoration touch recognition.

---
 .../BubbleCells/BaseBubbleCell/BaseBubbleCell.swift  | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
index ba750c1d4..d97c68ab5 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
@@ -243,6 +243,9 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     func addURLPreviewView(_ urlPreviewView: UIView) {
         self.bubbleCellContentView?.addURLPreviewView(urlPreviewView)
+        
+        // tmpSubviews is used for touch detection in MXKRoomBubbleTableViewCell
+        self.addTemporarySubview(urlPreviewView)
     }
     
     func removeURLPreviewView() {
@@ -254,6 +257,9 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     func addReadReceiptsView(_ readReceiptsView: UIView) {
         self.bubbleCellContentView?.addReadReceiptsView(readReceiptsView)
+        
+        // tmpSubviews is used for touch detection in MXKRoomBubbleTableViewCell
+        self.addTemporarySubview(readReceiptsView)
     }
     
     func removeReadReceiptsView() {
@@ -265,6 +271,9 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     func addReactionsView(_ reactionsView: UIView) {
         self.bubbleCellContentView?.addReactionsView(reactionsView)
+        
+        // tmpSubviews is used for touch detection in MXKRoomBubbleTableViewCell
+        self.addTemporarySubview(reactionsView)
     }
     
     func removeReactionsView() {
@@ -275,6 +284,9 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
 
     func addThreadSummaryView(_ threadSummaryView: ThreadSummaryView) {
         self.bubbleCellContentView?.addThreadSummaryView(threadSummaryView)
+        
+        // tmpSubviews is used for touch detection in MXKRoomBubbleTableViewCell
+        self.addTemporarySubview(threadSummaryView)
     }
 
     func removeThreadSummaryView() {

From d5bd037ec909fb672c1607b8afc4fe597789418a Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 08:35:00 +0100
Subject: [PATCH 44/62] BubbleRoomTimelineCellDecorator: Clean timestamp code.

---
 .../BubbleRoomTimelineCellDecorator.swift     | 27 +++++++++----------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
index 61b608910..7feac51fb 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellDecorator.swift
@@ -29,24 +29,19 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
         
     override func addTimestampLabel(toCell cell: MXKRoomBubbleTableViewCell, cellData: RoomBubbleCellData) {
         
-        if let timestampDisplayable = cell as? TimestampDisplayable, let timestampLabel = self.createTimestampLabel(for: cellData) {
+        guard let timestampLabel = self.createTimestampLabel(for: cellData) else {
+            super.addTimestampLabel(toCell: cell, cellData: cellData)
+            return
+        }
+        
+        if let timestampDisplayable = cell as? TimestampDisplayable {
             
             timestampDisplayable.addTimestampView(timestampLabel)
             
-        } else if let bubbleBackgroundView = cell.messageBubbleBackgroundView, bubbleBackgroundView.isHidden == false, let timestampLabel = self.createTimestampLabel(for: cellData) {
-            
-            // If cell contains a bubble background, add the timestamp inside of it
-            
-            self.addTimestampLabel(timestampLabel,
-                                   to: cell,
-                                   on: bubbleBackgroundView,
-                                   constrainingView: bubbleBackgroundView)
-            
         } else if cellData.isAttachmentWithThumbnail {
                                                  
             if cellData.attachment?.type == .sticker,
-               let attachmentView = cell.attachmentView,
-                let timestampLabel = self.createTimestampLabel(for: cellData) {
+               let attachmentView = cell.attachmentView {
                 
                 // Prevent overlap with send status icon
                 let bottomMargin: CGFloat = 20.0
@@ -59,9 +54,11 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
                                        rightMargin: rightMargin,
                                        bottomMargin: bottomMargin)
                 
-            } else if let attachmentView = cell.attachmentView, let timestampLabel = self.createTimestampLabel(for: cellData, textColor: self.theme.baseIconPrimaryColor) {
+            } else if let attachmentView = cell.attachmentView {
                 // For media with thumbnail cells, add timestamp inside thumbnail
                 
+                timestampLabel.textColor = self.theme.baseIconPrimaryColor
+                
                 self.addTimestampLabel(timestampLabel,
                                        to: cell,
                                        on: cell.contentView,
@@ -70,7 +67,7 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
             } else {
                 super.addTimestampLabel(toCell: cell, cellData: cellData)
             }
-        } else if let voiceMessageCell = cell as? VoiceMessageBubbleCell, let playbackView = voiceMessageCell.playbackController?.playbackView, let timestampLabel = self.createTimestampLabel(for: cellData) {
+        } else if let voiceMessageCell = cell as? VoiceMessageBubbleCell, let playbackView = voiceMessageCell.playbackController?.playbackView {
             
             // Add timestamp on cell inherting from VoiceMessageBubbleCell
             
@@ -79,7 +76,7 @@ class BubbleRoomTimelineCellDecorator: PlainRoomTimelineCellDecorator {
                                    on: cell.contentView,
                                    constrainingView: playbackView)
             
-        } else if let fileWithoutThumbnailCell = cell as? FileWithoutThumbnailBaseBubbleCell, let fileAttachementView = fileWithoutThumbnailCell.fileAttachementView, let timestampLabel = self.createTimestampLabel(for: cellData) {
+        } else if let fileWithoutThumbnailCell = cell as? FileWithoutThumbnailBaseBubbleCell, let fileAttachementView = fileWithoutThumbnailCell.fileAttachementView {
             
             // Add timestamp on cell inherting from VoiceMessageBubbleCell
             

From 68514fb2cdf3160d3a7fa984649f39d8cfaf68d0 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 08:36:39 +0100
Subject: [PATCH 45/62] BaseBubbleCell: Fix decoration disappear issues.

---
 .../BaseBubbleCell/BaseBubbleCell.swift       | 42 ++++++++++---------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
index d97c68ab5..78e646ece 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
@@ -144,25 +144,7 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     // MARK: - Public
     
-    // MARK: - Overrides
-    
-    override func setupViews() {
-        super.setupViews()
-        
-        let showEncryptionStatus = bubbleCellContentView?.showEncryptionStatus ?? false
-        
-        if showEncryptionStatus {
-            self.setupEncryptionStatusViewTapGestureRecognizer()
-        }
-    }
-    
-    override class func defaultReuseIdentifier() -> String! {
-        return String(describing: self)
-    }
-    
-    override func didEndDisplay() {
-        super.didEndDisplay()
-        
+    func removeDecorationViews() {
         if let bubbleCellReadReceiptsDisplayable = self as? BubbleCellReadReceiptsDisplayable {
             bubbleCellReadReceiptsDisplayable.removeReadReceiptsView()
         }
@@ -184,6 +166,28 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
         }
     }
     
+    // MARK: - Overrides
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        let showEncryptionStatus = bubbleCellContentView?.showEncryptionStatus ?? false
+        
+        if showEncryptionStatus {
+            self.setupEncryptionStatusViewTapGestureRecognizer()
+        }
+    }
+    
+    override class func defaultReuseIdentifier() -> String! {
+        return String(describing: self)
+    }
+    
+    override func prepareForReuse() {
+        super.prepareForReuse()
+        
+        self.removeDecorationViews()
+    }
+    
     override func render(_ cellData: MXKCellData!) {
         // In `MXKRoomBubbleTableViewCell` setupViews() is called in awakeFromNib() that is not called here, so call it only on first render() call
         self.setupViewsIfNeeded()

From f9e953c96640d8c2630157eff2f5cdaa1663b9c1 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 08:37:17 +0100
Subject: [PATCH 46/62] RoomMessageBubbleBackgroundView: Update timestamp
 management.

---
 .../Styles/Bubble/RoomMessageBubbleBackgroundView.swift       | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/RoomMessageBubbleBackgroundView.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/RoomMessageBubbleBackgroundView.swift
index 496cd0a4a..da79211b2 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/RoomMessageBubbleBackgroundView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/RoomMessageBubbleBackgroundView.swift
@@ -77,7 +77,11 @@ class RoomMessageBubbleBackgroundView: UIView {
 
 // MARK: - TimestampDisplayable
 extension RoomMessageBubbleBackgroundView: TimestampDisplayable {
+    
     func addTimestampView(_ timestampView: UIView) {
+        
+        self.removeTimestampView()
+        
         self.addTimestampView(timestampView, rightMargin: 8.0, bottomMargin: 4.0)
         self.timestampView = timestampView
     }

From 3d82ef9e422e0e1557a79cae90d47f62fdbcc5a4 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 08:40:24 +0100
Subject: [PATCH 47/62] MXKRoomBubbleTableViewCell: Fix view disappearing on
 didendisplay.

---
 .../MatrixKit/Views/MXKCellRendering.h        |   6 +-
 .../Common/MXKRoomBubbleTableViewCell.m       | 214 ++++++++++--------
 2 files changed, 127 insertions(+), 93 deletions(-)

diff --git a/Riot/Modules/MatrixKit/Views/MXKCellRendering.h b/Riot/Modules/MatrixKit/Views/MXKCellRendering.h
index 60d712910..22ebca772 100644
--- a/Riot/Modules/MatrixKit/Views/MXKCellRendering.h
+++ b/Riot/Modules/MatrixKit/Views/MXKCellRendering.h
@@ -75,11 +75,9 @@
 - (MXKCellData*)renderedCellData;
 
 /**
- Reset the cell.
+ Stop processes no more needed when cell is not visible.
 
- The cell is no more displayed. This is time to release resources and removing listeners.
- In case of UITableViewCell or UIContentViewCell object, the cell must reset in a state
- that it can be reusable.
+ The cell is no more displayed but still recycled. This is time to stop animation.
  */
 - (void)didEndDisplay;
 
diff --git a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
index fff04b59a..eacf94737 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
@@ -950,101 +950,32 @@ static BOOL _disableLongPressGestureOnEvent;
 {
     [super prepareForReuse];
     
+    bubbleData = nil;
+    delegate = nil;
+    
+    [[NSNotificationCenter defaultCenter] removeObserver:self];
+    
+    self.readReceiptsAlignment = ReadReceiptAlignmentLeft;
+    
+    _allTextHighlighted = NO;
+    _isAutoAnimatedGif = NO;
+    
+    [self removeHTMLBlockquoteSideBorderViews];
+    [self removeTemporarySubviews];
+    [self cleanAttachmentView];
+    [self clearBubbleInfoContainer];
+    [self clearBubbleOverlayContainer];
+    [self resetConstraintsConstantToDefault];
+    
     [self didEndDisplay];
 }
 
 - (void)didEndDisplay
 {
-    bubbleData = nil;
-
-    for (UIView *sideBorder in htmlBlockquoteSideBorderViews)
-    {
-        [sideBorder removeFromSuperview];
-    }
-    [htmlBlockquoteSideBorderViews removeAllObjects];
-    htmlBlockquoteSideBorderViews = nil;
-
-    if (_attachmentWebView)
-    {
-        [_attachmentWebView removeFromSuperview];
-        _attachmentWebView.navigationDelegate = nil;
-        _attachmentWebView = nil;
-    }
+    [self removeReadMarkerView];
+    [self cleanProgressView];
     
-    if (_readMarkerView)
-    {
-        [_readMarkerView removeFromSuperview];
-        _readMarkerView = nil;
-        _readMarkerViewTopConstraint = nil;
-        _readMarkerViewLeadingConstraint = nil;
-        _readMarkerViewTrailingConstraint = nil;
-        _readMarkerViewHeightConstraint = nil;
-    }
-    
-    if (self.attachmentView)
-    {
-        // Remove all gesture recognizer
-        while (self.attachmentView.gestureRecognizers.count)
-        {
-            [self.attachmentView removeGestureRecognizer:self.attachmentView.gestureRecognizers[0]];
-        }
-        
-        // Prevent the cell from displaying again the image in case of reuse.
-        self.attachmentView.image = nil;
-    }
-    
-    // Remove potential dateTime (or unsent) label(s)
-    if (self.bubbleInfoContainer && self.bubbleInfoContainer.subviews.count > 0)
-    {
-        NSArray* subviews = self.bubbleInfoContainer.subviews;
-             
-        for (UIView *view in subviews)
-        {
-            [view removeFromSuperview];
-        }
-    }
-    self.bubbleInfoContainer.hidden = YES;
-    
-    // Remove temporary subviews
-    for (UIView *view in self.tmpSubviews)
-    {
-        [view removeFromSuperview];
-    }
-    [self.tmpSubviews removeAllObjects];
-    
-    // Remove potential overlay subviews
-    if (self.bubbleOverlayContainer)
-    {
-        NSArray* subviews = self.bubbleOverlayContainer.subviews;
-        
-        for (UIView *view in subviews)
-        {
-            [view removeFromSuperview];
-        }
-        
-        self.bubbleOverlayContainer.hidden = YES;
-    }
-    
-    if (self.progressView)
-    {
-        [self stopProgressUI];
-        
-        // Remove long tap gesture on the progressView
-        while (self.progressView.gestureRecognizers.count)
-        {
-            [self.progressView removeGestureRecognizer:self.progressView.gestureRecognizers[0]];
-        }
-    }
-    
-    [[NSNotificationCenter defaultCenter] removeObserver:self];
-    
-    delegate = nil;
-    
-    self.readReceiptsAlignment = ReadReceiptAlignmentLeft;
-    _allTextHighlighted = NO;
-    _isAutoAnimatedGif = NO;
-    
-    [self resetConstraintsConstantToDefault];
+    // TODO: Stop gif animation
 }
 
 - (BOOL)shouldInteractWithURL:(NSURL *)URL urlItemInteraction:(UITextItemInteraction)urlItemInteraction associatedEvent:(MXEvent*)associatedEvent
@@ -1135,6 +1066,111 @@ static BOOL _disableLongPressGestureOnEvent;
     [self.tmpSubviews addObject:subview];
 }
 
+#pragma mark - Cleaning
+
+- (void)removeHTMLBlockquoteSideBorderViews
+{
+    for (UIView *sideBorder in htmlBlockquoteSideBorderViews)
+    {
+        [sideBorder removeFromSuperview];
+    }
+    [htmlBlockquoteSideBorderViews removeAllObjects];
+    htmlBlockquoteSideBorderViews = nil;
+}
+
+- (void)removeReadMarkerView
+{
+    if (_readMarkerView)
+    {
+        [_readMarkerView removeFromSuperview];
+        _readMarkerView = nil;
+        _readMarkerViewTopConstraint = nil;
+        _readMarkerViewLeadingConstraint = nil;
+        _readMarkerViewTrailingConstraint = nil;
+        _readMarkerViewHeightConstraint = nil;
+    }
+}
+
+- (void)removeTemporarySubviews
+{
+    // Remove temporary subviews
+    for (UIView *view in self.tmpSubviews)
+    {
+        [view removeFromSuperview];
+    }
+    [self.tmpSubviews removeAllObjects];
+}
+
+- (void)cleanAttachmentView
+{
+    if (self.attachmentView)
+    {
+        // Remove all gesture recognizer
+        while (self.attachmentView.gestureRecognizers.count)
+        {
+            [self.attachmentView removeGestureRecognizer:self.attachmentView.gestureRecognizers[0]];
+        }
+        
+        // Prevent the cell from displaying again the image in case of reuse.
+        self.attachmentView.image = nil;
+    }
+}
+
+- (void)clearBubbleInfoContainer
+{
+    // Remove potential dateTime (or unsent) label(s)
+    if (self.bubbleInfoContainer && self.bubbleInfoContainer.subviews.count > 0)
+    {
+        NSArray* subviews = self.bubbleInfoContainer.subviews;
+             
+        for (UIView *view in subviews)
+        {
+            [view removeFromSuperview];
+        }
+    }
+    self.bubbleInfoContainer.hidden = YES;
+}
+
+- (void)clearBubbleOverlayContainer
+{
+    // Remove potential overlay subviews
+    if (self.bubbleOverlayContainer)
+    {
+        NSArray* subviews = self.bubbleOverlayContainer.subviews;
+        
+        for (UIView *view in subviews)
+        {
+            [view removeFromSuperview];
+        }
+        
+        self.bubbleOverlayContainer.hidden = YES;
+    }
+}
+
+- (void)cleanProgressView
+{
+    if (self.progressView)
+    {
+        [self stopProgressUI];
+        
+        // Remove long tap gesture on the progressView
+        while (self.progressView.gestureRecognizers.count)
+        {
+            [self.progressView removeGestureRecognizer:self.progressView.gestureRecognizers[0]];
+        }
+    }
+}
+
+- (void)clearAttachmentWebView
+{
+    if (_attachmentWebView)
+    {
+        [_attachmentWebView removeFromSuperview];
+        _attachmentWebView.navigationDelegate = nil;
+        _attachmentWebView = nil;
+    }
+}
+
 #pragma mark - Attachment progress handling
 
 - (void)updateProgressUI:(NSDictionary*)statisticsDict

From cec8f9197d640f5d94552b21550738170c0debcb Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 10:50:33 +0100
Subject: [PATCH 48/62] BubbleRoomCellLayoutUpdater: Update legacy text
 incoming layout.

---
 .../Styles/Bubble/BubbleRoomCellLayoutUpdater.swift  | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
index ce7808314..3ce0e6708 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
@@ -110,17 +110,11 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
     private func getIncomingMessageTextViewInsets(from bubbleCell: MXKRoomBubbleTableViewCell) -> UIEdgeInsets {
         
         let bubbleBgRightMargin: CGFloat = 45
-        let messageViewMarginTop: CGFloat
-        let messageViewMarginBottom: CGFloat = -2.0
-        let messageViewMarginLeft: CGFloat = 3.0
+        let messageViewMarginTop: CGFloat = 0
+        let messageViewMarginBottom: CGFloat = -0
+        let messageViewMarginLeft: CGFloat = 0
         let messageViewMarginRight: CGFloat = 80 + bubbleBgRightMargin
         
-        if bubbleCell.userNameLabel != nil {
-            messageViewMarginTop = 10.0
-        } else {
-            messageViewMarginTop = 0.0
-        }
-        
         let messageViewInsets = UIEdgeInsets(top: messageViewMarginTop, left: messageViewMarginLeft, bottom: messageViewMarginBottom, right: messageViewMarginRight)
         
         return messageViewInsets

From 4ce8b1ad148e6a397cf2a0aeed63cee0af1ec603 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 10:51:31 +0100
Subject: [PATCH 49/62] MXKRoomBubbleTableViewCell: Clear attachmentWebView on
 reuse.

---
 .../Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
index eacf94737..5b1497f8c 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
@@ -966,6 +966,7 @@ static BOOL _disableLongPressGestureOnEvent;
     [self clearBubbleInfoContainer];
     [self clearBubbleOverlayContainer];
     [self resetConstraintsConstantToDefault];
+    [self clearAttachmentWebView];
     
     [self didEndDisplay];
 }

From 2c5a930b085f0c2ffdf9118b018c49b2dab7b073 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 12:33:24 +0100
Subject: [PATCH 50/62] RoomCellLayoutUpdating: Add maximum text width
 calculation.

---
 .../Room/Views/BubbleCells/Styles/RoomCellLayoutUpdating.swift  | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomCellLayoutUpdating.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomCellLayoutUpdating.swift
index 78f5330f1..2c8b85e83 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomCellLayoutUpdating.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomCellLayoutUpdating.swift
@@ -29,4 +29,6 @@ protocol RoomCellLayoutUpdating: Themable {
     func setupLayout(forOutgoingFileAttachmentCell cell: MXKRoomBubbleTableViewCell)
     
     func updateLayout(forSelectedStickerCell cell: RoomSelectedStickerBubbleCell)
+    
+    func maximumTextViewWidth(for cell: MXKRoomBubbleTableViewCell, cellData: MXKCellData, maximumCellWidth: CGFloat) -> CGFloat
 }

From 130acc4387ae054669b9a383ae2763f76be919be Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 12:34:05 +0100
Subject: [PATCH 51/62] BubbleRoomCellLayoutUpdater: Update legacy text message
 cells layout.

---
 .../Bubble/BubbleRoomCellLayoutUpdater.swift  | 72 ++++++++++++++++---
 1 file changed, 64 insertions(+), 8 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
index 3ce0e6708..0fff0b76f 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
@@ -97,6 +97,49 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         }
     }
     
+    func maximumTextViewWidth(for cell: MXKRoomBubbleTableViewCell, cellData: MXKCellData, maximumCellWidth: CGFloat) -> CGFloat {
+        
+        guard cell.messageTextView != nil else {
+            return 0
+        }
+        
+        let maxTextViewWidth: CGFloat
+        
+        let textViewleftMargin: CGFloat
+        let textViewRightMargin: CGFloat
+        
+        if let roomBubbleCellData = cellData as? RoomBubbleCellData, cell is MXKRoomIncomingTextMsgBubbleCell || cell is MXKRoomOutgoingTextMsgBubbleCell {
+            
+            if roomBubbleCellData.isIncoming {
+                let textViewInsets = self.getIncomingMessageTextViewInsets(from: cell)
+                
+                textViewleftMargin = cell.msgTextViewLeadingConstraint.constant + textViewInsets.left
+                // Right inset is in fact margin in this case
+                textViewRightMargin = textViewInsets.right
+            } else {
+                let textViewMargins = self.getOutgoingMessageTextViewMargins(from: cell)
+                
+                textViewleftMargin = textViewMargins.left
+                textViewRightMargin = textViewMargins.right
+            }
+        } else {
+            textViewleftMargin = cell.msgTextViewLeadingConstraint.constant
+            textViewRightMargin = cell.msgTextViewTrailingConstraint.constant
+        }
+        
+        maxTextViewWidth = maximumCellWidth - (textViewleftMargin + textViewRightMargin)
+        
+        guard maxTextViewWidth >= 0 else {
+            return 0
+        }
+        
+        guard maxTextViewWidth <= maximumCellWidth else {
+            return maxTextViewWidth
+        }
+        
+        return maxTextViewWidth
+    }
+    
     // MARK: Themable
     
     func update(theme: Theme) {
@@ -131,7 +174,23 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         cell.msgTextViewBottomConstraint.constant += messageViewInsets.bottom
         cell.msgTextViewTopConstraint.constant += messageViewInsets.top
         cell.msgTextViewLeadingConstraint.constant += messageViewInsets.left
-        cell.msgTextViewTrailingConstraint.constant += messageViewInsets.right
+        
+        // Right inset is in fact margin in this case
+        cell.msgTextViewTrailingConstraint.constant = messageViewInsets.right
+    }
+    
+    private func getOutgoingMessageTextViewMargins(from bubbleCell: MXKRoomBubbleTableViewCell) -> UIEdgeInsets {
+            
+        let innerContentLeftMargin: CGFloat = 57
+        
+        let messageViewMarginTop: CGFloat = 0
+        let messageViewMarginBottom: CGFloat = 0
+        let messageViewMarginLeft: CGFloat = 80.0 + innerContentLeftMargin
+        let messageViewMarginRight: CGFloat = 78.0
+            
+        let messageViewInsets = UIEdgeInsets(top: messageViewMarginTop, left: messageViewMarginLeft, bottom: messageViewMarginBottom, right: messageViewMarginRight)
+                
+        return messageViewInsets
     }
     
     private func setupOutgoingMessageTextViewMargins(for cell: MXKRoomBubbleTableViewCell) {
@@ -142,17 +201,14 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         
         let contentView = cell.contentView
         
-        let innerContentLeftMargin: CGFloat = 57
-        let leftMargin: CGFloat = 80.0 + innerContentLeftMargin
-        let rightMargin: CGFloat = 78.0
-        let bottomMargin: CGFloat = -2.0
+        let messageViewMargins = self.getOutgoingMessageTextViewMargins(from: cell)
         
         cell.msgTextViewLeadingConstraint.isActive = false
         cell.msgTextViewTrailingConstraint.isActive = false
         
-        let leftConstraint = messageTextView.leadingAnchor.constraint(greaterThanOrEqualTo: contentView.leadingAnchor, constant: leftMargin)
+        let leftConstraint = messageTextView.leadingAnchor.constraint(greaterThanOrEqualTo: contentView.leadingAnchor, constant: messageViewMargins.left)
         
-        let rightConstraint = messageTextView.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -rightMargin)
+        let rightConstraint = messageTextView.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -messageViewMargins.right)
         
         NSLayoutConstraint.activate([
             leftConstraint,
@@ -162,7 +218,7 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         cell.msgTextViewLeadingConstraint = leftConstraint
         cell.msgTextViewTrailingConstraint = rightConstraint
         
-        cell.msgTextViewBottomConstraint.constant += bottomMargin
+        cell.msgTextViewBottomConstraint.constant = messageViewMargins.bottom
     }
     
     // MARK: File attachment

From fcced28069ec4ccb7b95275d5e329fa9e7a0a0db Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:12:42 +0100
Subject: [PATCH 52/62] BubbleCellContentView: Separate avatar and user name in
 different containers.

---
 .../BaseBubbleCell/BaseBubbleCell.swift       |  7 ++---
 .../BubbleCellContentView.swift               | 29 ++++++++++++++++---
 .../BaseBubbleCell/BubbleCellContentView.xib  | 24 +++++++++++----
 3 files changed, 47 insertions(+), 13 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
index 78e646ece..892aa2f0f 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
@@ -77,7 +77,7 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     override var pictureView: MXKImageView! {
         get {
             guard let bubbleCellContentView = self.bubbleCellContentView,
-                bubbleCellContentView.showSenderInfo else {
+                bubbleCellContentView.showSenderAvatar else {
                 return nil
             }
             
@@ -93,8 +93,7 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     override var userNameLabel: UILabel! {
         get {
-            guard let bubbleCellContentView = self.bubbleCellContentView,
-                bubbleCellContentView.showSenderInfo else {
+            guard let bubbleCellContentView = self.bubbleCellContentView, bubbleCellContentView.showSenderName  else {
                 return nil
             }
             
@@ -111,7 +110,7 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     override var userNameTapGestureMaskView: UIView! {
         get {
             guard let bubbleCellContentView = self.bubbleCellContentView,
-                bubbleCellContentView.showSenderInfo else {
+                bubbleCellContentView.showSenderName else {
                 return nil
             }
             
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
index 79215fd9e..a0f7fbd22 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.swift
@@ -29,11 +29,13 @@ final class BubbleCellContentView: UIView, NibLoadable {
     @IBOutlet weak var paginationLabel: UILabel!
     @IBOutlet weak var paginationSeparatorView: UIView!
     
-    @IBOutlet weak var senderInfoContainerView: UIView!
-    @IBOutlet weak var avatarImageView: MXKImageView!
+    @IBOutlet weak var userNameContainerView: UIView!
     @IBOutlet weak var userNameLabel: UILabel!
     @IBOutlet weak var userNameTouchMaskView: UIView!
     
+    @IBOutlet weak var avatarContainerView: UIView!
+    @IBOutlet weak var avatarImageView: MXKImageView!
+    
     @IBOutlet weak var innerContentView: UIView!
     
     @IBOutlet weak var innerContentViewLeadingConstraint: NSLayoutConstraint!
@@ -117,10 +119,29 @@ final class BubbleCellContentView: UIView, NibLoadable {
     
     var showSenderInfo: Bool {
         get {
-            return !self.senderInfoContainerView.isHidden
+            return self.showSenderAvatar && self.showSenderName
         }
         set {
-            self.senderInfoContainerView.isHidden = !newValue
+            self.showSenderAvatar = newValue
+            self.showSenderName = newValue
+        }
+    }
+    
+    var showSenderAvatar: Bool {
+        get {
+            return !self.avatarContainerView.isHidden
+        }
+        set {
+            self.avatarContainerView.isHidden = !newValue
+        }
+    }
+    
+    var showSenderName: Bool {
+        get {
+            return !self.userNameContainerView.isHidden
+        }
+        set {
+            self.userNameContainerView.isHidden = !newValue
         }
     }
     
diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
index 76b03d2c5..cdaf09edd 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BubbleCellContentView.xib
@@ -4,6 +4,7 @@
     <dependencies>
         <deployment identifier="iOS"/>
         <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="19519"/>
+        <capability name="System colors in document resources" minToolsVersion="11.0"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
     <objects>
@@ -62,8 +63,8 @@
                                 <constraint firstAttribute="bottom" secondItem="Ro1-vP-6Ha" secondAttribute="bottom" constant="10" id="UcW-P4-rQv"/>
                             </constraints>
                         </view>
-                        <view hidden="YES" contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="w0C-6a-f5M">
-                            <rect key="frame" x="0.0" y="0.0" width="595" height="31"/>
+                        <view hidden="YES" contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="1cK-e6-Mg5">
+                            <rect key="frame" x="0.0" y="0.0" width="595" height="0.0"/>
                             <subviews>
                                 <view clipsSubviews="YES" contentMode="scaleAspectFill" translatesAutoresizingMaskIntoConstraints="NO" id="yXz-Za-4yR" customClass="MXKImageView">
                                     <rect key="frame" x="13" y="10" width="30" height="30"/>
@@ -74,6 +75,16 @@
                                         <constraint firstAttribute="width" constant="30" id="y7F-jl-kEF"/>
                                     </constraints>
                                 </view>
+                            </subviews>
+                            <color key="backgroundColor" systemColor="systemBackgroundColor"/>
+                            <constraints>
+                                <constraint firstItem="yXz-Za-4yR" firstAttribute="leading" secondItem="1cK-e6-Mg5" secondAttribute="leading" constant="13" id="UjU-eY-ARJ"/>
+                                <constraint firstItem="yXz-Za-4yR" firstAttribute="top" secondItem="1cK-e6-Mg5" secondAttribute="top" constant="10" id="jlf-dg-fp0"/>
+                            </constraints>
+                        </view>
+                        <view hidden="YES" contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="w0C-6a-f5M">
+                            <rect key="frame" x="0.0" y="0.0" width="595" height="31"/>
+                            <subviews>
                                 <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="ohU-Sc-mgb">
                                     <rect key="frame" x="46" y="4" width="534" height="30"/>
                                     <color key="backgroundColor" red="0.0" green="0.0" blue="0.0" alpha="0.0" colorSpace="custom" customColorSpace="sRGB"/>
@@ -94,9 +105,7 @@
                             <constraints>
                                 <constraint firstAttribute="bottom" secondItem="meG-P8-61b" secondAttribute="bottom" constant="3" id="HDT-eS-UWo"/>
                                 <constraint firstItem="ohU-Sc-mgb" firstAttribute="trailing" secondItem="meG-P8-61b" secondAttribute="trailing" id="Lbz-vD-hax"/>
-                                <constraint firstItem="yXz-Za-4yR" firstAttribute="leading" secondItem="w0C-6a-f5M" secondAttribute="leading" constant="13" id="QlM-xG-bob"/>
                                 <constraint firstItem="ohU-Sc-mgb" firstAttribute="bottom" secondItem="meG-P8-61b" secondAttribute="bottom" constant="6" id="U50-ZB-dRG"/>
-                                <constraint firstItem="yXz-Za-4yR" firstAttribute="top" secondItem="w0C-6a-f5M" secondAttribute="top" constant="10" id="UMP-G3-iPN"/>
                                 <constraint firstItem="meG-P8-61b" firstAttribute="top" secondItem="w0C-6a-f5M" secondAttribute="top" constant="10" id="baE-tR-0Ck"/>
                                 <constraint firstItem="ohU-Sc-mgb" firstAttribute="leading" secondItem="meG-P8-61b" secondAttribute="leading" constant="-10" id="ktD-JC-hfG"/>
                                 <constraint firstItem="ohU-Sc-mgb" firstAttribute="top" secondItem="meG-P8-61b" secondAttribute="top" constant="-6" id="s5V-Fj-iNL"/>
@@ -235,6 +244,7 @@
                     </subviews>
                     <constraints>
                         <constraint firstItem="Dj1-m6-1Jw" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="0Px-jL-CMJ"/>
+                        <constraint firstItem="1cK-e6-Mg5" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="2De-xT-k5e"/>
                         <constraint firstItem="meG-P8-61b" firstAttribute="trailing" secondItem="oeI-eO-mFK" secondAttribute="trailing" id="2Dy-o0-r33"/>
                         <constraint firstItem="snf-Ea-To0" firstAttribute="leading" secondItem="oeI-eO-mFK" secondAttribute="leading" id="2lm-T3-dEu"/>
                         <constraint firstItem="w0C-6a-f5M" firstAttribute="width" secondItem="5GX-gn-bK1" secondAttribute="width" id="5nl-Le-VDi"/>
@@ -262,6 +272,7 @@
             <nil key="simulatedBottomBarMetrics"/>
             <freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
             <connections>
+                <outlet property="avatarContainerView" destination="1cK-e6-Mg5" id="8j5-Km-Jfj"/>
                 <outlet property="avatarImageView" destination="yXz-Za-4yR" id="f56-93-gxa"/>
                 <outlet property="bubbleInfoContainer" destination="7Y6-Py-paB" id="uLv-MM-HIL"/>
                 <outlet property="bubbleInfoContainerTopConstraint" destination="Wx9-0o-vzm" id="nLG-nC-lwV"/>
@@ -281,7 +292,6 @@
                 <outlet property="reactionsContentViewTrailingConstraint" destination="ynR-d4-6cf" id="Sy0-o9-vAC"/>
                 <outlet property="readReceiptsContainerView" destination="4zo-V8-CNe" id="7ek-u4-CX8"/>
                 <outlet property="readReceiptsContentView" destination="rQt-NH-Cb0" id="tqw-je-kp9"/>
-                <outlet property="senderInfoContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="threadSummaryContainerView" destination="2eB-kB-m20" id="0Y4-4E-I9K"/>
                 <outlet property="threadSummaryContentView" destination="snf-Ea-To0" id="6Oo-Gj-e4Z"/>
                 <outlet property="threadSummaryContentViewBottomConstraint" destination="4tt-w0-4JE" id="6db-Jz-jys"/>
@@ -291,6 +301,7 @@
                 <outlet property="urlPreviewContentView" destination="vpX-Nl-AEt" id="P8S-Fg-VFQ"/>
                 <outlet property="urlPreviewContentViewLeadingConstraint" destination="lTt-Qx-fuQ" id="5Fc-zl-b1j"/>
                 <outlet property="urlPreviewContentViewTrailingConstraint" destination="ZmA-Ns-chh" id="EXg-Rr-cuJ"/>
+                <outlet property="userNameContainerView" destination="w0C-6a-f5M" id="fZE-vY-0nR"/>
                 <outlet property="userNameLabel" destination="meG-P8-61b" id="ETK-ag-WYR"/>
                 <outlet property="userNameTouchMaskView" destination="ohU-Sc-mgb" id="FwW-aL-kc5"/>
             </connections>
@@ -299,5 +310,8 @@
     </objects>
     <resources>
         <image name="encryption_warning" width="12" height="12"/>
+        <systemColor name="systemBackgroundColor">
+            <color white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+        </systemColor>
     </resources>
 </document>

From 290c2b4a83f5047faff2f430a69ac3411b7ecab7 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:13:35 +0100
Subject: [PATCH 53/62] Add text message bubble cells without sender name
 variants.

---
 ...tionTitleWithoutSenderNameBubbleCell.swift | 26 +++++++++++++++++++
 ...eIncomingWithoutSenderNameBubbleCell.swift | 26 +++++++++++++++++++
 ...tionTitleWithoutSenderNameBubbleCell.swift | 24 +++++++++++++++++
 3 files changed, 76 insertions(+)
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderNameBubbleCell.swift
 create mode 100644 Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.swift

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.swift
new file mode 100644
index 000000000..8f2c5fcc6
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.swift
@@ -0,0 +1,26 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell: TextMessageIncomingWithPaginationTitleBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderName = false
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderNameBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderNameBubbleCell.swift
new file mode 100644
index 000000000..15bbacf0c
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Incoming/TextMessageIncomingWithoutSenderNameBubbleCell.swift
@@ -0,0 +1,26 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import UIKit
+
+class TextMessageIncomingWithoutSenderNameBubbleCell: TextMessageIncomingBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderName = false
+    }
+}
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.swift
new file mode 100644
index 000000000..dd9a345e3
--- /dev/null
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/TextMessage/Outgoing/TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.swift
@@ -0,0 +1,24 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+class TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell: TextMessageOutgoingWithPaginationTitleBubbleCell {
+    
+    override func setupViews() {
+        super.setupViews()
+        
+        bubbleCellContentView?.showSenderName = false
+    }
+}

From be259d4392f5a603968b42fddde7d1e1472e95ae Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:14:34 +0100
Subject: [PATCH 54/62] BubbleRoomTimelineCellProvider: Handle text message
 cells without sender name and use bubbles for emotes.

---
 .../Bubble/BubbleRoomTimelineCellProvider.m   | 52 ++++++++++++++++---
 .../Plain/PlainRoomTimelineCellProvider.h     |  4 ++
 2 files changed, 50 insertions(+), 6 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
index 0378c7d3f..2a9626796 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineCellProvider.m
@@ -71,7 +71,9 @@
     
     [tableView registerClass:TextMessageIncomingBubbleCell.class forCellReuseIdentifier:TextMessageIncomingBubbleCell.defaultReuseIdentifier];
     [tableView registerClass:TextMessageIncomingWithoutSenderInfoBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithoutSenderInfoBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageIncomingWithoutSenderNameBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithoutSenderNameBubbleCell.defaultReuseIdentifier];
     [tableView registerClass:TextMessageIncomingWithPaginationTitleBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithPaginationTitleBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.class forCellReuseIdentifier:TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.defaultReuseIdentifier];
 }
 
 - (void)registerOutgoingTextMessageCellsForTableView:(UITableView*)tableView
@@ -81,6 +83,7 @@
     
     [tableView registerClass:TextMessageOutgoingWithoutSenderInfoBubbleCell.class forCellReuseIdentifier:TextMessageOutgoingWithoutSenderInfoBubbleCell.defaultReuseIdentifier];
     [tableView registerClass:TextMessageOutgoingWithPaginationTitleBubbleCell.class forCellReuseIdentifier:TextMessageOutgoingWithPaginationTitleBubbleCell.defaultReuseIdentifier];
+    [tableView registerClass:TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.class forCellReuseIdentifier:TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.defaultReuseIdentifier];
 }
 
 - (void)registerVoiceMessageCellsForTableView:(UITableView*)tableView
@@ -138,14 +141,14 @@
         @(RoomTimelineCellIdentifierIncomingTextMessage) : TextMessageIncomingBubbleCell.class,
         @(RoomTimelineCellIdentifierIncomingTextMessageWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
         @(RoomTimelineCellIdentifierIncomingTextMessageWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
-        @(RoomTimelineCellIdentifierIncomingTextMessageWithoutSenderName) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierIncomingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithoutSenderName) : TextMessageIncomingWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.class,
         // Encrypted
         @(RoomTimelineCellIdentifierIncomingTextMessageEncrypted) : TextMessageIncomingBubbleCell.class,
         @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
         @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
-        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithoutSenderName) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithoutSenderName) : TextMessageIncomingWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.class,
     };
 }
 
@@ -158,13 +161,50 @@
         @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
         @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
         @(RoomTimelineCellIdentifierOutgoingTextMessageWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.class,
         // Encrypted
         @(RoomTimelineCellIdentifierOutgoingTextMessageEncrypted) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
         @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
         @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
         @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
-        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingTextMessageEncryptedWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleWithoutSenderNameBubbleCell.class,
+    };
+}
+
+- (NSDictionary<NSNumber*, Class>*)incomingEmoteCellsMapping
+{
+    return @{
+        // Clear
+        @(RoomTimelineCellIdentifierIncomingEmote) : TextMessageIncomingBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithoutSenderName) : TextMessageIncomingWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.class,
+        // Encrypted
+        @(RoomTimelineCellIdentifierIncomingEmoteEncrypted) : TextMessageIncomingBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderInfo) : TextMessageIncomingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitle) : TextMessageIncomingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithoutSenderName) : TextMessageIncomingWithoutSenderNameBubbleCell.class,
+        @(RoomTimelineCellIdentifierIncomingEmoteEncryptedWithPaginationTitleWithoutSenderName) : TextMessageIncomingWithPaginationTitleWithoutSenderNameBubbleCell.class,
+    };
+}
+
+- (NSDictionary<NSNumber*, Class>*)outgoingEmoteCellsMapping
+{
+    // Hide sender info and avatar for bubble outgoing messages
+    return @{
+        // Clear
+        @(RoomTimelineCellIdentifierOutgoingEmote) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        // Encrypted
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncrypted) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderInfo) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitle) : TextMessageOutgoingWithPaginationTitleBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithoutSenderName) : TextMessageOutgoingWithoutSenderInfoBubbleCell.class,
+        @(RoomTimelineCellIdentifierOutgoingEmoteEncryptedWithPaginationTitleWithoutSenderName) : TextMessageOutgoingWithPaginationTitleBubbleCell.class
     };
 }
 
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
index 1fe2ecf5a..73f0d8f8b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineCellProvider.h
@@ -38,6 +38,10 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (NSDictionary<NSNumber*, Class>*)outgoingTextMessageCellsMapping;
 
+- (NSDictionary<NSNumber*, Class>*)incomingEmoteCellsMapping;
+
+- (NSDictionary<NSNumber*, Class>*)outgoingEmoteCellsMapping;
+
 - (NSDictionary<NSNumber*, Class>*)outgoingAttachmentCellsMapping;
 
 - (NSDictionary<NSNumber*, Class>*)incomingAttachmentWithoutThumbnailCellsMapping;

From 19323d0508858bafdf2e5d15a52f090b0d015e19 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:19:36 +0100
Subject: [PATCH 55/62] MXKRoomBubbleCellData: Add new attributed text message
 property.

---
 Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h   | 5 +++++
 .../MatrixKit/Models/Room/MXKRoomBubbleCellDataStoring.h     | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
index eba99595c..e094e13e5 100644
--- a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
+++ b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
@@ -46,6 +46,11 @@
      */
     NSAttributedString *attributedTextMessage;
     
+    /**
+     Same as attributedTextMessage but without vertical positioning vertical spaces.
+     */
+    NSAttributedString *attributedTextMessageWithoutPositioningSpace;
+    
     /**
      The optional text pattern to be highlighted in the body of the message.
      */
diff --git a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellDataStoring.h b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellDataStoring.h
index 9f227b79a..5ec4b9cb7 100644
--- a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellDataStoring.h
+++ b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellDataStoring.h
@@ -163,6 +163,10 @@
  */
 @property (nonatomic) NSAttributedString *attributedTextMessage;
 
+/**
+ Same as attributedTextMessage but without vertical positioning blank space
+ */
+@property (nonatomic) NSAttributedString *attributedTextMessageWithoutPositioningSpace;
 /**
  The raw text message (without attributes)
  */

From 3d6fb8da37e48b16251e61eeb3a2625adbf29c75 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:19:49 +0100
Subject: [PATCH 56/62] MXKRoomBubbleCellData: Add new attributed text message
 property.

---
 Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h | 2 +-
 Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
index e094e13e5..275c25f7f 100644
--- a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
+++ b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.h
@@ -47,7 +47,7 @@
     NSAttributedString *attributedTextMessage;
     
     /**
-     Same as attributedTextMessage but without vertical positioning vertical spaces.
+     Same as attributedTextMessage but without vertical positioning vertical blank space.
      */
     NSAttributedString *attributedTextMessageWithoutPositioningSpace;
     
diff --git a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m
index dc658e680..4eefae18d 100644
--- a/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m
+++ b/Riot/Modules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m
@@ -28,7 +28,7 @@
 
 @implementation MXKRoomBubbleCellData
 @synthesize senderId, targetId, roomId, senderDisplayName, senderAvatarUrl, senderAvatarPlaceholder, targetDisplayName, targetAvatarUrl, targetAvatarPlaceholder, isEncryptedRoom, isPaginationFirstBubble, shouldHideSenderInformation, date, isIncoming, isAttachmentWithThumbnail, isAttachmentWithIcon, attachment, senderFlair;
-@synthesize textMessage, attributedTextMessage;
+@synthesize textMessage, attributedTextMessage, attributedTextMessageWithoutPositioningSpace;
 @synthesize shouldHideSenderName, isTyping, showBubbleDateTime, showBubbleReceipts, useCustomDateTimeLabel, useCustomReceipts, useCustomUnsentButton, hasNoDisplay;
 @synthesize tag;
 @synthesize collapsable, collapsed, collapsedAttributedTextMessage, prevCollapsableCellData, nextCollapsableCellData, collapseState;

From 7255cefdc460f0995591e461799b3fb9e46296b2 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:27:30 +0100
Subject: [PATCH 57/62] RoomBubbleCellData: Handle atttributed text message
 without vert space.

---
 .../Room/CellData/RoomBubbleCellData.m        | 83 +++++++++----------
 1 file changed, 39 insertions(+), 44 deletions(-)

diff --git a/Riot/Modules/Room/CellData/RoomBubbleCellData.m b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
index 8d441d527..3ba7dab34 100644
--- a/Riot/Modules/Room/CellData/RoomBubbleCellData.m
+++ b/Riot/Modules/Room/CellData/RoomBubbleCellData.m
@@ -38,9 +38,6 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
 // Flags to "Show All" reactions for an event
 @property(nonatomic) NSMutableSet<NSString* /* eventId */> *eventsToShowAllReactions;
 
-@property (nonatomic, strong) NSAttributedString *currentAttributedTextMsg;
-@property (nonatomic, strong) NSAttributedString *currentAttributedTextMsgWithoutVertSpace;
-
 @end
 
 @implementation RoomBubbleCellData
@@ -244,32 +241,18 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
 
 - (NSAttributedString*)attributedTextMessage
 {
-    @synchronized(bubbleComponents)
-    {
-        if (self.hasAttributedTextMessage && !attributedTextMessage.length)
-        {
-            // Attributed text message depends on the room read receipts which must be retrieved on the main thread to prevent us from race conditions.
-            // Check here the current thread, this is just a sanity check because the attributed text message
-            // is requested during the rendering step which takes place on the main thread.
-            if ([NSThread currentThread] != [NSThread mainThread])
-            {
-                MXLogDebug(@"[RoomBubbleCellData] attributedTextMessage called on wrong thread");
-                dispatch_sync(dispatch_get_main_queue(), ^{
-                    [self buildAttributedString];
-                    self.attributedTextMessage = [self getAppropriatedAttributedString];
-                });
-            }
-            else
-            {
-                [self buildAttributedString];
-                self.attributedTextMessage = [self getAppropriatedAttributedString];
-            }
-        }
-    }
+    [self buildAttributedStringIfNeeded];
     
     return attributedTextMessage;
 }
 
+- (NSAttributedString*)attributedTextMessageWithoutPositioningSpace
+{
+    [self buildAttributedStringIfNeeded];
+    
+    return attributedTextMessageWithoutPositioningSpace;
+}
+
 - (BOOL)hasNoDisplay
 {
     if (self.tag == RoomBubbleCellDataTagKeyVerificationNoDisplay)
@@ -383,20 +366,6 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
     [self setNeedsUpdateAdditionalContentHeight];
 }
 
-- (NSAttributedString*)getAppropriatedAttributedString
-{
-    RoomTimelineConfiguration *timelineConfiguration = [RoomTimelineConfiguration shared];
-    
-    if (timelineConfiguration.currentStyle.useVerticalWhiteSpaceForText)
-    {
-        return self.currentAttributedTextMsg;
-    }
-    else
-    {
-        return self.currentAttributedTextMsgWithoutVertSpace;
-    }
-}
-
 - (void)buildAttributedString
 {
     // CAUTION: This method must be called on the main thread.
@@ -404,8 +373,10 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
     // Return the collapsed string only for cells series header
     if (self.collapsed && self.collapsedAttributedTextMessage && self.nextCollapsableCellData)
     {
-        self.currentAttributedTextMsg =  super.collapsedAttributedTextMessage;
-        self.currentAttributedTextMsgWithoutVertSpace = super.collapsedAttributedTextMessage;
+        NSAttributedString *attributedString = super.collapsedAttributedTextMessage;
+        
+        self.attributedTextMessage = attributedString;
+        self.attributedTextMessageWithoutPositioningSpace = attributedString;
         
         return;
     }
@@ -495,10 +466,34 @@ NSString *const URLPreviewDidUpdateNotification = @"URLPreviewDidUpdateNotificat
     {
         [currentAttributedTextMsgWithoutVertSpace appendString:@"       "];
     }
+        
+    self.attributedTextMessage = currentAttributedTextMsg;
     
-    self.currentAttributedTextMsg = currentAttributedTextMsg;
-    
-    self.currentAttributedTextMsgWithoutVertSpace = currentAttributedTextMsgWithoutVertSpace;
+    self.attributedTextMessageWithoutPositioningSpace = currentAttributedTextMsgWithoutVertSpace;
+}
+
+- (void)buildAttributedStringIfNeeded
+{
+    @synchronized(bubbleComponents)
+    {
+        if (self.hasAttributedTextMessage && !attributedTextMessage.length)
+        {
+            // Attributed text message depends on the room read receipts which must be retrieved on the main thread to prevent us from race conditions.
+            // Check here the current thread, this is just a sanity check because the attributed text message
+            // is requested during the rendering step which takes place on the main thread.
+            if ([NSThread currentThread] != [NSThread mainThread])
+            {
+                MXLogDebug(@"[RoomBubbleCellData] attributedTextMessage called on wrong thread");
+                dispatch_sync(dispatch_get_main_queue(), ^{
+                    [self buildAttributedString];
+                });
+            }
+            else
+            {
+                [self buildAttributedString];
+            }
+        }
+    }
 }
 
 - (NSInteger)firstVisibleComponentIndex

From 6aa005d145b08f67492ca18ac410c41ccb6efb82 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:32:07 +0100
Subject: [PATCH 58/62] MXKRoomBubbleTableViewCell: Add properties regarding
 attributed text blank space positioning.

---
 .../Common/MXKRoomBubbleTableViewCell.h       | 10 ++++++
 .../Common/MXKRoomBubbleTableViewCell.m       | 36 +++++++++++++++----
 2 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.h b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.h
index 27efc0c4a..baf53c7ba 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.h
+++ b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.h
@@ -239,6 +239,16 @@ extern NSString *const kMXKRoomBubbleCellUrlItemInteraction;
  */
 @property (nonatomic) WKWebView *attachmentWebView;
 
+/**
+ Indicate true if the cell needs vertical space in the text to position UI components.
+ */
+@property (nonatomic, readonly) BOOL isTextViewNeedsPositioningVerticalSpace;
+
+/**
+ Use bubbleData.attributedTextMessage or bubbleData.attributedTextMessageWithoutPositioningSpace according to isTextViewNeedsPositioningVerticalSpace value.
+ */
+@property (nonatomic, readonly) NSAttributedString *suitableAttributedTextMessage;
+
 /**
  Called during the designated initializer of the UITableViewCell class to set the default
  properties values.
diff --git a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
index 5b1497f8c..b0a2fba49 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
+++ b/Riot/Modules/Room/Views/BubbleCells/Common/MXKRoomBubbleTableViewCell.m
@@ -30,6 +30,8 @@
 #import "MXKMessageTextView.h"
 #import "UITextView+MatrixKit.h"
 
+#import "GeneratedInterface-Swift.h"
+
 #pragma mark - Constant definitions
 NSString *const kMXKRoomBubbleCellTapOnMessageTextView = @"kMXKRoomBubbleCellTapOnMessageTextView";
 NSString *const kMXKRoomBubbleCellTapOnSenderNameLabel = @"kMXKRoomBubbleCellTapOnSenderNameLabel";
@@ -122,6 +124,7 @@ static BOOL _disableLongPressGestureOnEvent;
     _allTextHighlighted = NO;
     _isAutoAnimatedGif = NO;
     _tmpSubviews = [NSMutableArray array];
+    _isTextViewNeedsPositioningVerticalSpace = YES;
 }
 
 - (void)awakeFromNib
@@ -366,18 +369,23 @@ static BOOL _disableLongPressGestureOnEvent;
     {
         if (_allTextHighlighted)
         {
-            NSMutableAttributedString *highlightedString = [[NSMutableAttributedString alloc] initWithAttributedString:bubbleData.attributedTextMessage];
+            NSMutableAttributedString *highlightedString = [[NSMutableAttributedString alloc] initWithAttributedString:self.suitableAttributedTextMessage];
             UIColor *color = self.tintColor ? self.tintColor : [UIColor lightGrayColor];
             [highlightedString addAttribute:NSBackgroundColorAttributeName value:color range:NSMakeRange(0, highlightedString.length)];
             self.messageTextView.attributedText = highlightedString;
         }
         else
         {
-            self.messageTextView.attributedText = bubbleData.attributedTextMessage;
+            self.messageTextView.attributedText = self.suitableAttributedTextMessage;
         }
     }
 }
 
+- (NSAttributedString *)suitableAttributedTextMessage
+{
+    return self.isTextViewNeedsPositioningVerticalSpace ? bubbleData.attributedTextMessage : bubbleData.attributedTextMessageWithoutPositioningSpace;
+}
+
 - (void)highlightTextMessageForEvent:(NSString*)eventId
 {
     if (self.messageTextView)
@@ -389,7 +397,7 @@ static BOOL _disableLongPressGestureOnEvent;
         else
         {
             // Restore original string
-            self.messageTextView.attributedText = bubbleData.attributedTextMessage;
+            self.messageTextView.attributedText = self.suitableAttributedTextMessage;
         }
     }
 }
@@ -559,14 +567,14 @@ static BOOL _disableLongPressGestureOnEvent;
             // Underline attached file name
             if (self.isBubbleDataContainsFileAttachment)
             {
-                NSMutableAttributedString *updatedText = [[NSMutableAttributedString alloc] initWithAttributedString:bubbleData.attributedTextMessage];
+                NSMutableAttributedString *updatedText = [[NSMutableAttributedString alloc] initWithAttributedString:self.suitableAttributedTextMessage];
                 [updatedText addAttribute:NSUnderlineStyleAttributeName value:[NSNumber numberWithInteger:NSUnderlineStyleSingle] range:NSMakeRange(0, updatedText.length)];
                 
                 newText = updatedText;
             }
             else
             {
-                newText = bubbleData.attributedTextMessage;
+                newText = self.suitableAttributedTextMessage;
             }
             
             // update the text only if it is required
@@ -927,8 +935,24 @@ static BOOL _disableLongPressGestureOnEvent;
     }
     else if (cell.messageTextView)
     {
+        CGFloat maxTextViewWidth;
+        
+        RoomTimelineConfiguration *timelineConfiguration = [RoomTimelineConfiguration shared];
+        
+        id<RoomCellLayoutUpdating> cellLayoutUpdater = timelineConfiguration.currentStyle.cellLayoutUpdater;
+        
+        // Handle updated text view layout if needed
+        if (cellLayoutUpdater)
+        {
+            maxTextViewWidth = [cellLayoutUpdater maximumTextViewWidthFor:cell cellData:cellData maximumCellWidth:maxWidth];
+        }
+        else
+        {
+            maxTextViewWidth = maxWidth - (cell.msgTextViewLeadingConstraint.constant + cell.msgTextViewTrailingConstraint.constant);
+        }
+        
         // Update maximum width available for the textview
-        bubbleData.maxTextViewWidth = maxWidth - (cell.msgTextViewLeadingConstraint.constant + cell.msgTextViewTrailingConstraint.constant);
+        bubbleData.maxTextViewWidth = maxTextViewWidth;
         
         // Retrieve the suggested height of the message content
         rowHeight = bubbleData.contentSize.height;

From aacf38820aa2e92863ef13dcd7620ebed14cb534 Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:32:36 +0100
Subject: [PATCH 59/62] BaseBubbleCell: Update
 isTextViewNeedsPositioningVerticalSpace value.

---
 .../Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
index 892aa2f0f..1365d0e18 100644
--- a/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/BaseBubbleCell/BaseBubbleCell.swift
@@ -167,6 +167,10 @@ class BaseBubbleCell: MXKRoomBubbleTableViewCell, BaseBubbleCellType {
     
     // MARK: - Overrides
     
+    override var isTextViewNeedsPositioningVerticalSpace: Bool {
+        return false
+    }
+    
     override func setupViews() {
         super.setupViews()
         

From 3ae07474d71588bea35b46fe521814c75e6c604f Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:32:58 +0100
Subject: [PATCH 60/62] FileWithoutThumbnailBaseBubbleCell: Update attributed
 text usage.

---
 .../Common/FileWithoutThumbnailBaseBubbleCell.swift       | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
index ee6d67798..32dfe9612 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/Cells/FileWithoutThumbnail/Common/FileWithoutThumbnailBaseBubbleCell.swift
@@ -22,12 +22,8 @@ class FileWithoutThumbnailBaseBubbleCell: SizableBaseBubbleCell, BubbleCellReact
     
     override func render(_ cellData: MXKCellData!) {
         super.render(cellData)
-        
-        guard let data = cellData as? RoomBubbleCellData else {
-            return
-        }
-        
-        self.fileAttachementView?.titleLabel.attributedText = data.attributedTextMessage
+                
+        self.fileAttachementView?.titleLabel.attributedText = self.suitableAttributedTextMessage
         
         self.update(theme: ThemeService.shared().theme)
     }

From a9fc0fc4aef13ea91a55ade4071cdb5e5916d27e Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:34:05 +0100
Subject: [PATCH 61/62] RoomTimelineStyle: Remove useless property.

---
 .../BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift  | 3 ---
 .../BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift    | 5 +----
 .../Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift    | 3 ---
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
index 95d14de68..137338e57 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomTimelineStyle.swift
@@ -34,8 +34,6 @@ class BubbleRoomTimelineStyle: RoomTimelineStyle {
     
     let cellDecorator: RoomTimelineCellDecorator
     
-    let useVerticalWhiteSpaceForText: Bool
-    
     // MARK: - Setup
     
     init(theme: Theme) {
@@ -44,7 +42,6 @@ class BubbleRoomTimelineStyle: RoomTimelineStyle {
         self.cellLayoutUpdater = BubbleRoomCellLayoutUpdater(theme: theme)
         self.cellProvider = BubbleRoomTimelineCellProvider()
         self.cellDecorator = BubbleRoomTimelineCellDecorator()
-        self.useVerticalWhiteSpaceForText = false
     }
     
     // MARK: - Public
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
index 84d6f9430..e72ce51fb 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Plain/PlainRoomTimelineStyle.swift
@@ -33,9 +33,7 @@ class PlainRoomTimelineStyle: RoomTimelineStyle {
     let cellProvider: RoomTimelineCellProvider
     
     let cellDecorator: RoomTimelineCellDecorator
-    
-    let useVerticalWhiteSpaceForText: Bool
- 
+     
     // MARK: - Setup
     
     init(theme: Theme) {
@@ -44,7 +42,6 @@ class PlainRoomTimelineStyle: RoomTimelineStyle {
         self.cellLayoutUpdater = nil
         self.cellProvider = PlainRoomTimelineCellProvider()
         self.cellDecorator = PlainRoomTimelineCellDecorator()
-        self.useVerticalWhiteSpaceForText = true
     }
     
     // MARK: - Methods
diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
index 2a1874d3b..b430171b5 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/RoomTimelineStyle.swift
@@ -35,9 +35,6 @@ protocol RoomTimelineStyle: Themable {
     /// Handle cell decorations (reactions, read receipts, URL preview, …)
     var cellDecorator: RoomTimelineCellDecorator { get }
     
-    /// Indicate true to make RoomBubbleCellData use vertical spaces for the attributedText
-    var useVerticalWhiteSpaceForText: Bool { get }
-    
     // MARK: - Methods
     
     /// Indicate to merge or not event in timeline

From 58b249ccd4261dab7a2aa6f20488d9881d34d42b Mon Sep 17 00:00:00 2001
From: SBiOSoftWhare <steveb@matrix.org>
Date: Wed, 9 Feb 2022 16:34:41 +0100
Subject: [PATCH 62/62] BubbleRoomCellLayoutUpdater: Fix outgoing layout.

---
 .../BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
index 0fff0b76f..4cd22c10b 100644
--- a/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
+++ b/Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift
@@ -218,7 +218,7 @@ class BubbleRoomCellLayoutUpdater: RoomCellLayoutUpdating {
         cell.msgTextViewLeadingConstraint = leftConstraint
         cell.msgTextViewTrailingConstraint = rightConstraint
         
-        cell.msgTextViewBottomConstraint.constant = messageViewMargins.bottom
+        cell.msgTextViewBottomConstraint.constant += messageViewMargins.bottom
     }
     
     // MARK: File attachment