felixfoertsch/bundesmessenger-ios
1
0
Fork 0
mirror of https://gitlab.opencode.de/bwi/bundesmessenger/clients/bundesmessenger-ios.git synced 2026-04-29 20:56:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Adopt consolidated logging mechanism (#4370)

Browse Source 
* Adopted the new MXLog and replaced NSLog throughout the application - vector-im/element-ios/issues/4351
* Replaced NSLog() and print() usages with MXLog.debug()
* Added swiftlint rules for NSLog(), print(), println() and os_log()
* Escape paths used to run script build phases for swiftlint and swiftgen
This commit is contained in:
Stefan Ceriu
2021-06-03 11:30:07 +03:00
committed by GitHub
parent f70b6df6c9
commit 43f6c44c78
94 changed files with 689 additions and 630 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Riot/Modules/Room/Views/BubbleCells/Call/Group/RoomGroupCallStatusBubbleCell.swift
+1 -1
View File
@@ -201,7 +201,7 @@ class RoomGroupCallStatusBubbleCell: RoomBaseCallBubbleCell {
let events = bubbleCellData.allLinkedEvents()
NSLog("[RoomGroupCallStatusBubbleCell] render: \(events.count) events: \(events)")
MXLog.debug("[RoomGroupCallStatusBubbleCell] render: \(events.count) events: \(events)")
guard let widgetEvent = events
.first(where: {
Riot/Modules/Room/Views/BubbleCells/KeyVerification/KeyVerificationConclusionBubbleCell.swift
+1 -1
View File
@@ -49,7 +49,7 @@ class KeyVerificationConclusionBubbleCell: KeyVerificationBaseBubbleCell {
guard let keyVerificationCellInnerContentView = self.keyVerificationCellInnerContentView,
let bubbleData = self.bubbleData as? RoomBubbleCellData,
let viewData = self.viewData(from: bubbleData) else {
NSLog("[KeyVerificationConclusionBubbleCell] Fail to render \(String(describing: cellData))")
MXLog.debug("[KeyVerificationConclusionBubbleCell] Fail to render \(String(describing: cellData))")
return
}
Riot/Modules/Room/Views/BubbleCells/KeyVerification/KeyVerificationIncomingRequestApprovalBubbleCell.swift
+1 -1
View File
@@ -61,7 +61,7 @@ class KeyVerificationIncomingRequestApprovalBubbleCell: KeyVerificationBaseBubbl
guard let keyVerificationCellInnerContentView = self.keyVerificationCellInnerContentView,
let bubbleData = self.bubbleData,
let viewData = self.viewData(from: bubbleData) else {
NSLog("[KeyVerificationIncomingRequestApprovalBubbleCell] Fail to render \(String(describing: cellData))")
MXLog.debug("[KeyVerificationIncomingRequestApprovalBubbleCell] Fail to render \(String(describing: cellData))")
return
}
Riot/Modules/Room/Views/BubbleCells/KeyVerification/KeyVerificationRequestStatusBubbleCell.swift
+4 -4
View File
@@ -52,10 +52,10 @@ class KeyVerificationRequestStatusBubbleCell: KeyVerificationBaseBubbleCell {
super.render(cellData)
guard let keyVerificationCellInnerContentView = self.keyVerificationCellInnerContentView,
let roomBubbleCellData = self.bubbleData as? RoomBubbleCellData,
let viewData = self.viewData(from: roomBubbleCellData) else {
NSLog("[KeyVerificationRequestStatusBubbleCell] Fail to render \(String(describing: cellData))")
return
let roomBubbleCellData = self.bubbleData as? RoomBubbleCellData,
let viewData = self.viewData(from: roomBubbleCellData) else {
MXLog.debug("[KeyVerificationRequestStatusBubbleCell] Fail to render \(String(describing: cellData))")
return
}
keyVerificationCellInnerContentView.title = viewData.title
Riot/Modules/Room/Views/BubbleCells/RoomCreationIntro/RoomCreationIntroCell.swift
+4 -4
View File
@@ -93,14 +93,14 @@ class RoomCreationIntroCell: MXKRoomBubbleTableViewCell {
super.render(cellData)
guard let bubbleCellContentView = self.bubbleCellContentView else {
NSLog("[RoomCreationIntroCell] Fail to load content view")
MXLog.debug("[RoomCreationIntroCell] Fail to load content view")
return
}
guard let bubbleData = self.bubbleData,
let viewData = self.viewData(from: bubbleData) else {
NSLog("[RoomCreationIntroCell] Fail to render \(String(describing: cellData))")
return
let viewData = self.viewData(from: bubbleData) else {
MXLog.debug("[RoomCreationIntroCell] Fail to render \(String(describing: cellData))")
return
}
bubbleCellContentView.fill(with: viewData)
Riot/Modules/Room/Views/Title/Expanded/ExpandedRoomTitleView.m
+1 -1
View File
@@ -101,7 +101,7 @@
} lazyLoadedMembers:^(MXRoomMembers *lazyLoadedMembers) {
onRoomMembers(lazyLoadedMembers, NO);
} failure:^(NSError *error) {
NSLog(@"[ExpandedRoomTitleView] refreshDisplay: Cannot get all room members");
MXLogDebug(@"[ExpandedRoomTitleView] refreshDisplay: Cannot get all room members");
}];
}
else
Riot/Modules/Room/Views/Title/Preview/PreviewRoomTitleView.m
+1 -1
View File
@@ -226,7 +226,7 @@
}lazyLoadedMembers:^(MXRoomMembers *lazyLoadedMembers) {
onRoomMembers(lazyLoadedMembers, NO);
} failure:^(NSError *error) {
NSLog(@"[PreviewRoomTitleView] refreshDisplay: Cannot get all room members");
MXLogDebug(@"[PreviewRoomTitleView] refreshDisplay: Cannot get all room members");
}];
}
else