vector-im/element-ios/issues/5009 - Refactored away the NSExtensionContext dependency from the ShareManager. Introduced different ShareItemProviders for the share extension and the main application. Improved item loading error handling.

2026-04-18 23:48:29 +02:00 · 2021-10-15 13:09:11 +03:00
parent 9fffe41fdd
commit 4329040d36
21 changed files with 525 additions and 274 deletions
--- a/RiotShareExtension/Sources/ShareExtensionRootViewController.m
+++ b/RiotShareExtension/Sources/ShareExtensionRootViewController.m
@@ -0,0 +1,83 @@
+/*
+ Copyright 2017 Aram Sargsyan
+ 
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ 
+ http://www.apache.org/licenses/LICENSE-2.0
+ 
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+
+#import "ShareExtensionRootViewController.h"
+#import "ShareManager.h"
+#import "ThemeService.h"
+
+#ifdef IS_SHARE_EXTENSION
+#import "RiotShareExtension-Swift.h"
+#else
+#import "Riot-Swift.h"
+#endif
+
+@interface ShareExtensionRootViewController ()
+
+@property (nonatomic, strong, readonly) ShareManager *shareManager;
+
+@end
+
+@implementation ShareExtensionRootViewController
+
+- (void)viewDidLoad
+{
+    [super viewDidLoad];
+    
+    [ThemeService.shared setThemeId:RiotSettings.shared.userInterfaceTheme];
+    
+    ShareExtensionShareItemProvider *provider = [[ShareExtensionShareItemProvider alloc] initWithExtensionContext:self.extensionContext];
+    _shareManager = [[ShareManager alloc] initWithShareItemProvider:provider];
+    
+    MXWeakify(self);
+    [_shareManager setCompletionCallback:^(ShareManagerResult result) {
+        MXStrongifyAndReturnIfNil(self);
+        
+        switch (result)
+        {
+            case ShareManagerResultFinished:
+                [self.extensionContext completeRequestReturningItems:nil completionHandler:nil];
+                [self _dismiss];
+                break;
+            case ShareManagerResultCancelled:
+                [self.extensionContext cancelRequestWithError:[NSError errorWithDomain:@"MXUserCancelErrorDomain" code:4201 userInfo:nil]];
+                [self _dismiss];
+                break;
+            case ShareManagerResultFailed:
+                [self.extensionContext cancelRequestWithError:[NSError errorWithDomain:@"MXFailureErrorDomain" code:500 userInfo:nil]];
+                [self _dismiss];
+                break;
+            default:
+                break;
+        }
+    }];
+    
+    [self presentViewController:self.shareManager.mainViewController animated:YES completion:nil];
+}
+
+#pragma mark - Private
+
+- (void)_dismiss
+{
+    [self dismissViewControllerAnimated:true completion:^{
+        [self.presentingViewController dismissViewControllerAnimated:false completion:nil];
+        
+        // FIXME: Share extension memory usage increase when launched several times and then crash due to some memory leaks.
+        // For now, we force the share extension to exit and free memory.
+        [NSException raise:@"Kill the app extension" format:@"Free memory used by share extension"];
+    }];
+}
+
+@end