Refactor sections as enum types

2026-04-21 00:52:43 +02:00 · 2022-04-04 09:24:22 +01:00
parent 6cde2f4461
commit 3f34fd655a
10 changed files with 454 additions and 296 deletions
@@ -0,0 +1,115 @@
+// 
+// Copyright 2022 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import Foundation
+import XCTest
+@testable import Riot
+
+class RecentsDataSourceSectionsTests: XCTestCase {
+    func test_canCreateWithNSNumbers() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            NSNumber(value: -1),
+            NSNumber(value: 0),
+            NSNumber(value: 2),
+            NSNumber(value: 100),
+        ])
+        
+        XCTAssertEqual(sections.count, 2)
+        XCTAssertTrue(sections.contains(.crossSigningBanner))
+        XCTAssertTrue(sections.contains(.directory))
+    }
+    
+    func test_hasCorrectCount() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            .invites,
+            .favorites,
+            .searchedRoom,
+            .lowPriority,
+            .serverNotice
+        ])
+        
+        XCTAssertEqual(sections.count, 5)
+    }
+    
+    func test_containsCorrectTypes() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            .favorites,
+            .directory,
+            .lowPriority,
+            .serverNotice
+        ])
+        
+        XCTAssertTrue(sections.contains(.favorites))
+        XCTAssertTrue(sections.contains(.directory))
+        XCTAssertTrue(sections.contains(.lowPriority))
+        XCTAssertTrue(sections.contains(.serverNotice))
+        
+        XCTAssertFalse(sections.contains(.invites))
+        XCTAssertFalse(sections.contains(.searchedRoom))
+    }
+    
+    func test_hasCorrectSectionIndices() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            .invites,
+            .favorites,
+            .searchedRoom,
+            .lowPriority
+        ])
+        
+        XCTAssertEqual(sections.sectionIndex(forSectionType: .invites), 0)
+        XCTAssertEqual(sections.sectionIndex(forSectionType: .favorites), 1)
+        XCTAssertEqual(sections.sectionIndex(forSectionType: .searchedRoom), 2)
+        XCTAssertEqual(sections.sectionIndex(forSectionType: .lowPriority), 3)
+        
+        XCTAssertEqual(sections.sectionIndex(forSectionType: .suggestedRooms), -1)
+    }
+    
+    func test_indicesMatchCorrectTypes() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            .favorites,
+            .invites,
+            .lowPriority,
+            .searchedRoom,
+        ])
+        
+        XCTAssertEqual(sections.sectionType(forSectionIndex: 0), .favorites)
+        XCTAssertEqual(sections.sectionType(forSectionIndex: 1), .invites)
+        XCTAssertEqual(sections.sectionType(forSectionIndex: 2), .lowPriority)
+        XCTAssertEqual(sections.sectionType(forSectionIndex: 3), .searchedRoom)
+        
+        XCTAssertEqual(sections.sectionType(forSectionIndex: -1), .unknown)
+        XCTAssertEqual(sections.sectionType(forSectionIndex: 100), .unknown)
+    }
+    
+    func test_returnsSectionTypesAsNSNumbers() {
+        let sections = RecentsDataSourceSections(sectionTypes: [
+            .favorites,
+            .invites,
+            .lowPriority,
+            .searchedRoom,
+        ])
+        
+        XCTAssertEqual(
+            sections.sectionTypes,
+            [
+                NSNumber(value: RecentsDataSourceSectionType.favorites.rawValue),
+                NSNumber(value: RecentsDataSourceSectionType.invites.rawValue),
+                NSNumber(value: RecentsDataSourceSectionType.lowPriority.rawValue),
+                NSNumber(value: RecentsDataSourceSectionType.searchedRoom.rawValue),
+            ]
+        )
+    }
+}