Code review fixes

2026-04-20 00:24:43 +02:00 · 2022-09-22 11:52:42 +03:00
parent 29220f0be8
commit 1d84f992bb
14 changed files with 178 additions and 218 deletions
@@ -0,0 +1,112 @@
+// 
+// Copyright 2021 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import XCTest
+
+@testable import RiotSwiftUI
+
+class UserSessionDetailsViewModelTests: XCTestCase {
+    
+    func test_whenSessionNameAndLastSeenIPNil_viewStateCorrect() {
+        let userSessionInfo = createUserSessionInfo(sessionId: "session",
+                                                    sessionName: nil,
+                                                    lastSeenIP: nil)
+        
+        var sessionItems = [UserSessionDetailsSectionItemViewData]()
+        sessionItems.append(sessionIdItem(sessionId: userSessionInfo.sessionId))
+        
+        var sections = [UserSessionDetailsSectionViewData]()
+        sections.append(UserSessionDetailsSectionViewData(header: VectorL10n.userSessionDetailsSessionSectionHeader,
+                                                          footer: VectorL10n.userSessionDetailsSessionSectionFooter,
+                                                          items: sessionItems))
+        let expectedModel = UserSessionDetailsViewState(sections: sections)
+        let sut = UserSessionDetailsViewModel(userSessionInfo: userSessionInfo)
+        
+        XCTAssertEqual(sut.state, expectedModel)
+    }
+    
+    func test_whenSessionNameNotNilLastSeenIPNil_viewStateCorrect() {
+        let userSessionInfo = createUserSessionInfo(sessionId: "session",
+                                                    sessionName: "session name",
+                                                    lastSeenIP: nil)
+        
+        var sessionItems = [UserSessionDetailsSectionItemViewData]()
+        sessionItems.append(sessionNameItem(sessionName: "session name"))
+        sessionItems.append(sessionIdItem(sessionId: userSessionInfo.sessionId))
+        
+        var sections = [UserSessionDetailsSectionViewData]()
+        sections.append(UserSessionDetailsSectionViewData(header: VectorL10n.userSessionDetailsSessionSectionHeader,
+                                                          footer: VectorL10n.userSessionDetailsSessionSectionFooter,
+                                                          items: sessionItems))
+        
+        let expectedModel = UserSessionDetailsViewState(sections: sections)
+        let sut = UserSessionDetailsViewModel(userSessionInfo: userSessionInfo)
+        
+        XCTAssertEqual(sut.state, expectedModel)
+    }
+    
+    func test_whenUserSessionInfoContainsAllValues_viewStateCorrect() {
+        let userSessionInfo = createUserSessionInfo(sessionId: "session",
+                                                    sessionName: "session name",
+                                                    lastSeenIP: "0.0.0.0")
+        
+        var sessionItems = [UserSessionDetailsSectionItemViewData]()
+        sessionItems.append(sessionNameItem(sessionName: "session name"))
+        sessionItems.append(sessionIdItem(sessionId: userSessionInfo.sessionId))
+        
+        var sections = [UserSessionDetailsSectionViewData]()
+        sections.append(UserSessionDetailsSectionViewData(header: VectorL10n.userSessionDetailsSessionSectionHeader,
+                                                          footer: VectorL10n.userSessionDetailsSessionSectionFooter,
+                                                          items: sessionItems))
+        
+        var deviceSectionItems = [UserSessionDetailsSectionItemViewData]()
+        deviceSectionItems.append(UserSessionDetailsSectionItemViewData(title: VectorL10n.userSessionDetailsDeviceIpAddress,
+                                                                        value: "0.0.0.0"))
+        sections.append(UserSessionDetailsSectionViewData(header: VectorL10n.userSessionDetailsDeviceSectionHeader,
+                                                          footer: nil,
+                                                          items: deviceSectionItems))
+        
+        let expectedModel = UserSessionDetailsViewState(sections: sections)
+        let sut = UserSessionDetailsViewModel(userSessionInfo: userSessionInfo)
+        
+        XCTAssertEqual(sut.state, expectedModel)
+    }
+    
+    private func createUserSessionInfo(sessionId: String,
+                                       sessionName: String?,
+                                       deviceType: DeviceType = .mobile,
+                                       isVerified: Bool = false,
+                                       lastSeenIP: String?,
+                                       lastSeenTimestamp: TimeInterval = Date().timeIntervalSince1970) -> UserSessionInfo {
+        UserSessionInfo(sessionId: sessionId,
+                        sessionName: sessionName,
+                        deviceType: deviceType,
+                        isVerified: isVerified,
+                        lastSeenIP: lastSeenIP,
+                        lastSeenTimestamp: lastSeenTimestamp)
+        
+    }
+    
+    private func sessionNameItem(sessionName: String) -> UserSessionDetailsSectionItemViewData {
+        UserSessionDetailsSectionItemViewData(title: VectorL10n.userSessionDetailsSessionName,
+                                              value: sessionName)
+    }
+    
+    private func sessionIdItem(sessionId: String) -> UserSessionDetailsSectionItemViewData {
+        UserSessionDetailsSectionItemViewData(title: VectorL10n.keyVerificationManuallyVerifyDeviceIdTitle,
+                                              value: sessionId)
+    }
+}