From 9b7357e0e17641a6980205884ed2ff3114503ba0 Mon Sep 17 00:00:00 2001 From: Doug Date: Mon, 5 Jul 2021 11:59:35 +0100 Subject: [PATCH 1/3] Remove background colour from RoomsLiveViewController. --- .../Modules/Share/Listing/RoomsListViewController.xib | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.xib b/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.xib index 630d940a3..bc77d3275 100644 --- a/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.xib +++ b/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.xib @@ -1,11 +1,9 @@ - - - - + + - + @@ -39,7 +37,6 @@ - @@ -49,6 +46,7 @@ + From 7f0f419d675885d654c06a6e4b2df9e4a320b0d2 Mon Sep 17 00:00:00 2001 From: Doug Date: Tue, 13 Jul 2021 16:54:30 +0100 Subject: [PATCH 2/3] Fix layout bug in the share extension. --- .../Modules/Share/Listing/RoomsListViewController.m | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.m b/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.m index 777249a6e..94acaa453 100644 --- a/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.m +++ b/RiotShareExtension/Modules/Share/Listing/RoomsListViewController.m @@ -129,6 +129,13 @@ } } +- (void)setKeyboardHeight:(CGFloat)keyboardHeight +{ + // Bypass inherited keyboard handling to fix layout when searching. + // There are no sticky headers to worry about updating. + return; +} + #pragma mark - Private - (void)showShareAlertForRoomPath:(NSIndexPath *)indexPath @@ -289,6 +296,12 @@ // Refresh display [self refreshRecentsTable]; } + + // Dismiss the keyboard when scrolling to match the behaviour of the main app. + if (self.recentsSearchBar.isFirstResponder) + { + [self.recentsSearchBar resignFirstResponder]; + } } } } From 3d900e3068c65b06f9e5c1c1409dbda183208948 Mon Sep 17 00:00:00 2001 From: Doug Date: Tue, 13 Jul 2021 17:08:48 +0100 Subject: [PATCH 3/3] Update CHANGES.rst. --- CHANGES.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index 2e72d9c8e..75dccc3c1 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -8,7 +8,7 @@ Changes to be released in next version * 🐛 Bugfix - * + * Share Extension: Fix layout when searching (#4258). ⚠️ API Changes *