* DNET: Remove packet capture as an API tool; add the mechanic as part of the logs in the Open Web Access Point puzzle
* DNET: Make harder version of the packet capture puzzle just have alphanumeric noise instead of lore data and stuff
* DNET: Make harder version of the packet capture puzzle just have alphanumeric noise instead of lore data and stuff
* PR feedback
There were two large holes in the existing offline server handling:
1. It didn't include IPs, so scripts that used IPs instead of hostnames
would get exceptions thrown for "server not found."
2. Coverage was very low for non-Darknet APIs. Maybe most of them don't
need to be covered, but many obvious ones like "ps", "killall" and
"hasRootAccess" were missing. IMO the only reliable answer is one
that enforces *all* are covered via the type system.
To accomplish the second part, helpers.getServer() was changed to return
null when a server is offline. This intentionally breaks a lot of its
utility, which was to return a server unconditionally. To compensate,
its utility was increased - it now also does unknown argument
processing, allowing it to subsume a common line that all callers were
repeating.
Some callers switched to ctx.workerScript.getServer(), because they
didn't actually need to be using helpers.getServer(). Similarly, a few
callsites switched to GetServerOrThrow(), for the cases where it should
be guaranteed that the server is valid. The rest are returning a
default/failure response when the server is offline. (Except for
contracts, which threw on failure already anyway.)
* REFACTOR: Move Result to the public API
This refactors Result<T> to be part of the public NetscriptDefinitions.
It is not used by anything in this PR, but it is planned to be used in
the autoinfil APIs, or lacking that, future APIs, so this should not be
exposing anything prematurely.
* Add @public as api-extractor suggested and generate docs
* Use import type
---------
Co-authored-by: CatLover <152669316+catloversg@users.noreply.github.com>
* Convert purchased server functions to cloud API
- Create `ns.cloud`
- Change `bitnode multipliers` and `server constants` wording for consistency
- change `server`, `ram` and `getting started` docs for consistency
- Added changes to 3.0.0 API Break and `setRemovedFunctions` in NetscriptFunctions.js
Tested by
- running tutorial `purchase-server-8gb.js`, and a more typical player one
- buying manually using vendor (Alpha Ent in Sector 12)
- deleting them all using script, and checked all deleted functions gave correct error
- Imported completed save to ensure auto-transfer of function work
* Revision in line with comments
- changed more `purchased` to `cloud` references
- Added BN mults auto-conversion
* Update getting_started.md
- Corrected function names for new `cloud API`
* Don't show `cloud API` warning
v3.0.0 API break auto-replaces `cloud` functions, not warning suggested.
* API Break correction
- `cloud` affected API break replacement changed to be more descriptive and functional
* Fix typo and add empty lines
* Update many things (check commit's description)
- Comments
- Terminal message
- UI Text
- TSDoc
- md docs
- Improve error messages in src\NetscriptFunctions\Cloud.ts
The primary parts are changing the way stats affect infiltration difficulty, to make rewards more intuitive and balanced, and adding a "market demand" mechanism, which kicks in when doing lots of infils quickly. With current parameters, market demand shouldn't affect manual play at all, and won't affect most auto-infil terribly (it depends how they're implemented).
This was a complex change, see PR #2210 for the full context
catloversg
Michael Ficocelli
David Walker
TheAimMan
Adam Weeden
gmcew
Paul Setzer
Femboy Fireball
Ante