Commit Graph

5369 Commits

Author SHA1 Message Date
hydroflame c930487c21 Merge pull request #4215 from borisflagell/crime-sleeve
SLEEVE: Fixes 2 issues in Sleeve's implementation of crime work
2022-10-09 00:25:13 -04:00
hydroflame a5b2512269 Merge pull request #4205 from Snarling/ramTestFix
TESTS: Refined ram calculation tests
2022-10-09 00:23:04 -04:00
hydroflame b4d6ead5d2 Merge pull request #4206 from quacksouls/doc-exec
DOC: `ns.exec()`: typo fixes and clean presentation
2022-10-09 00:22:54 -04:00
hydroflame ed0a28d292 Merge pull request #4207 from quacksouls/doc-prettier
DOC: no trailing whitespace
2022-10-09 00:22:25 -04:00
borisflagell 6d86852969 FIX crime by sleeve
Bitnode multiplier was applied twice in th UI.
Sleeve's multiplier weren't applied (neither in UI, nor engine).
2022-10-08 17:19:20 +03:00
borisflagell 08b6c7a177 Fix #4195
Whenever StanekGift updated Sleeve's mult,
all mult were reset to default value (1.0 usually).
then stanek mult were merged.
but aug's mults never were.

=> Added a small loop to StanekGift updateMults() which reapply Aug's mult.
2022-10-08 15:28:51 +03:00
Duck McSouls 1d739f295c DOC: gang task: typo fix
The current version `black mail` should be `blackmail` because the description is referring to the crime of blackmail.
2022-10-08 14:21:30 +11:00
Fabian Dellwing ea39e5e1f4 Include BN multiplier in faction donation 2022-10-07 21:28:19 +02:00
Duck McSouls 351d769122 DOC: no trailing whitespace
Remove some trailing whitespaces in `src/ScriptEditor/NetscriptDefinitions.d.ts` because `npm run format` complains about them.  The trailing whitespaces were introduced in one of my earlier patches.  Sorry about this :-(
2022-10-06 23:29:06 +11:00
Duck McSouls e3ace9f6d5 DOC: ns.exec(): break example comments into multiple lines
The comment of each example is so long that, in the generated documentation for `ns.exec()` shown at

https://github.com/danielyxie/bitburner/blob/dev/markdown/bitburner.ns.exec.md

you must use the horizontal scrollbar to read the whole comment.  Even if you maximize the browser window, you must still use the horizontal scrollbar to read the whole comment.  Tested on Brave, Chrome, Firefox, and Opera.  Fix this by limiting each line of comment to at most 90 characters.
2022-10-06 22:56:01 +11:00
Duck McSouls 5edcdaad81 DOC: ns.exec(): typo fixes
Some typographical fixes in the documentation of `ns.exec()`.  Link to the function `ns.run()`.  Currently, the line `* * @example` causes API Extractor to output an asterisk (i.e. `*`) between the two code examples.  The function `ns.exec()` calls the function `runScriptFromScript()` from `src/NetscriptWorker.ts`, which uses the floor function to round down the number of threads.
2022-10-06 22:34:00 +11:00
Snarling 0310a98237 Lint+format fix? 2022-10-05 15:29:56 -04:00
Snarling 068533cd2f format, lint, more enums, revert fn rename 2022-10-05 14:52:48 -04:00
Snarling 8bb88a5080 Better RamCost testing (see desc)
* RamCostGenerator will have an error if ramcosts are defined for nonexistent functions, in addition to error if not all functions have ram costs defined
* Removed a few random blank comment lines in NetscriptDefinitions.d.ts
* RamCalculation.test.ts checks exact expected static and dynamic ram usage from (almost) every function, based on defined RamCosts in RamCostGenerator.
2022-10-05 10:42:07 -04:00
Staszek Welsh ad8c7b7ffe Fix change in behaviour of person.hasAugmentation 2022-10-04 22:55:35 +01:00
Conner Tennery 40e8e82b6d Merge branch 'dev' into 4125 2022-10-04 09:39:12 -07:00
hydroflame 4d1e72bf7a Merge pull request #4172 from Snarling/IPs-fix
CCT: Generate IPs contract type accepts properly formatted js array
2022-10-04 11:58:26 -04:00
hydroflame 075daf6fac Merge pull request #4175 from mycroftjr/patch-2
BLADEBURNER: Make Datamancer apply to Tracking
2022-10-04 11:47:46 -04:00
hydroflame 5b699fa19f Merge pull request #4188 from quacksouls/doc-stock
DOC: `stock.getPrice()`: typo fixes and update examples
2022-10-04 11:47:24 -04:00
hydroflame 2b8ced4fff Merge pull request #4182 from OverlordQ/patch-1
MISC: Remove spurious console spam
2022-10-04 11:45:09 -04:00
hydroflame 774c3ef402 Merge pull request #4185 from quacksouls/doc-print
DOC: `print()` and friends: typo fixes and examples
2022-10-04 11:45:01 -04:00
Snarling 361466b7fa unasync trywriteport 2022-10-04 07:59:50 -04:00
Snarling aa80cf6451 See description
Reverted ToastVariant back to an enum internally. Still exposed to player as just possible strings.
Changed all 1-line documentation comments to actually be 1-line. Moved some because they were not providing documentation for the thing they were trying to.
2022-10-04 06:40:10 -04:00
Snarling 50f14b4f58 Commit1 2022-10-03 12:12:16 -04:00
Conner Tennery 0d6b6b404d fix "Slash when his guard is down!" actually means "Slash when he's attacking!" Also the Might of Ares timer is wrong. #4125
- Added ignoreAugment_WKSharmonizer to GameTimer to allow for strict, unmodified timers
- Changed SlashGame failure check
- Changed `timeUntilAttacking` value so the progress bar in SlashGame is accurate
2022-10-03 01:42:17 -07:00
Duck McSouls 01e7ce2a05 DOC: stock.getPrice(): a simple example
Fixes #4184. The hard-coded stock symbol `"FISG"` should be `"FSIG"`.
2022-10-02 11:39:54 +11:00
Snarling ab56d18e1e group initializers 2022-10-01 15:49:23 -04:00
Snarling 3addda7173 format and lint 2022-10-01 15:15:36 -04:00
Snarling 9774235404 initial test fix attempt 2022-10-01 15:03:47 -04:00
Duck McSouls 4cf270138d DOC: stock.getPrice(): typo fix in examples
Fixes #4184.  The hard-coded stock symbol `"FISG"` should be `"FSIG"`.  The updated examples do not use a hard-coded stock symbol.  The documentation is updated to explain under which circumstances a player can run the function `stock.getPrice()`.
2022-10-01 10:07:20 +10:00
Duck McSouls 5e14d07d9a DOC: stock.getPrice(): typo fixes
Some typographical fixes for the documentation of `stock.getPrice()`.  The line for RAM cost should be separated by a blank line from the sentence about the definition of a stock's price.  Otherwise `npm run doc` would cram those information together onto one line.
2022-10-01 09:59:44 +10:00
Duck McSouls 0488f6e7b3 DOC: print() and friends: some examples
Some examples for how to use `print()` and related functions.  Use cross-referencing to reduce duplicate examples.
2022-09-30 14:22:49 +10:00
Duck McSouls ebdeb15d5a DOC: print() and friends: typo fixes
Some typographical fixes.  In the generated documentation for `tprintf()`, the documentation for the parameter `values` is missing because `@param msg` should be `@param values`.
2022-09-30 14:19:19 +10:00
OverlordQ 046ba80935 Update killWorkerScript.ts
Remove spurious console debugging line
2022-09-29 08:20:49 -04:00
hydroflame 5e4a393495 Merge pull request #4180 from Snarling/growthAnalyzeSecurityFix
NETSCRIPT: growthAnalyzeSecurity no longer fails if the optional cores parameter was omitted
2022-09-29 01:09:21 -03:00
Snarling b682d441e3 better fix for cores check 2022-09-29 00:02:33 -04:00
Snarling 17be0911b2 fix growthAnalyzeSecurity 2022-09-28 23:59:58 -04:00
Olivier Gagnon cb064ce8d7 fix new save file not loading 2022-09-28 23:35:01 -04:00
MycroftJr c7d85e1d42 Make Datamancer apply to Tracking
Makes the Datamancer skill for Bladeburner apply to the Population Estimate change of the Tracking contract. If this was not desired, then the description of Datamancer needs to be made more accurate :D
2022-09-27 22:08:14 -07:00
Snarling a1f90d77ce Prettier fix 2022-09-27 19:58:14 -04:00
Snarling 73e314aa31 Add quotation marks to expected answer
Matches the way an array of strings is denoted in js
2022-09-27 19:52:25 -04:00
Snarling aba6de1514 Allow IPs to have quotes around them 2022-09-27 19:41:00 -04:00
Olivier Gagnon 444c74ccd9 Merge branch 'dev' of github.com:danielyxie/bitburner into dev 2022-09-27 17:37:36 -04:00
Olivier Gagnon fbf5009cdb comment out unnamedaug2 2022-09-27 17:37:32 -04:00
hydroflame 7ce1adddce Merge pull request #4151 from LJNeon/script-editor-fix
UI: Remove extra / from open script tab when files are in a folder
2022-09-27 17:50:32 -03:00
hydroflame a1df9db493 Merge pull request #4160 from quacksouls/cct-name
CCT: no special characters in file names of Coding Contracts
2022-09-27 17:50:08 -03:00
hydroflame 30363e0280 Merge pull request #4155 from Mughur/corp
CORP: fixed wrongly named division type
2022-09-27 17:49:09 -03:00
hydroflame 49a460af00 Merge pull request #4161 from Snarling/cityFix
UI: Fix possible React error 300 in ASCII version of city screen
2022-09-27 17:47:54 -03:00
Snarling 582c9f40e2 Merge branch 'dev' into cityFix 2022-09-27 16:38:39 -04:00
Snarling a4b7128e6c Sleeve bladeburner fix 2022-09-27 16:36:37 -04:00