* DNET: Remove packet capture as an API tool; add the mechanic as part of the logs in the Open Web Access Point puzzle
* DNET: Make harder version of the packet capture puzzle just have alphanumeric noise instead of lore data and stuff
* DNET: Make harder version of the packet capture puzzle just have alphanumeric noise instead of lore data and stuff
* PR feedback
There were two large holes in the existing offline server handling:
1. It didn't include IPs, so scripts that used IPs instead of hostnames
would get exceptions thrown for "server not found."
2. Coverage was very low for non-Darknet APIs. Maybe most of them don't
need to be covered, but many obvious ones like "ps", "killall" and
"hasRootAccess" were missing. IMO the only reliable answer is one
that enforces *all* are covered via the type system.
To accomplish the second part, helpers.getServer() was changed to return
null when a server is offline. This intentionally breaks a lot of its
utility, which was to return a server unconditionally. To compensate,
its utility was increased - it now also does unknown argument
processing, allowing it to subsume a common line that all callers were
repeating.
Some callers switched to ctx.workerScript.getServer(), because they
didn't actually need to be using helpers.getServer(). Similarly, a few
callsites switched to GetServerOrThrow(), for the cases where it should
be guaranteed that the server is valid. The rest are returning a
default/failure response when the server is offline. (Except for
contracts, which threw on failure already anyway.)
* Add some re-rendering improvements to avoid the canvas and visual servers getting desynched
* removed underlevelled nerf to low-level servers; improved charisma level docs
* Remove offscreen dynamic culling
* PR feedback; add cache file names to tooltip
* Ensure stasis link servers get loaded properly; ensure darkweb has neighbors to prevent unit tests from failing; remove extra optional chaining accessors
There was duplicated code, and more importantly, were were handling
certain things subtly differently in exec() and scp() as a result. This
notably causes a behavior change in exec() and scp() where failure to
authenticate now returns failure instead of throwing, which I believe is
the proper response.
This also makes it easier to see in the code exactly which functions
require what (auth, session, etc.)
