felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-17 23:08:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

BUGFIX: Wrong success range of Bladeburner general action (#1552)

Browse Source
This commit is contained in:
catloversg
2024-08-09 07:37:22 +07:00
committed by GitHub
parent 75cacc36bc
commit ed01fb8e9e
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Bladeburner/Actions/GeneralAction.ts
View File

@@ -4,6 +4,7 @@ import type { ActionIdentifier } from "../Types";
import { BladeActionType, BladeGeneralActionName } from "@enums"; import { BladeActionType, BladeGeneralActionName } from "@enums";
import { ActionClass, ActionParams } from "./Action"; import { ActionClass, ActionParams } from "./Action";
import { clampNumber } from "../../utils/helpers/clampNumber";
type GeneralActionParams = ActionParams & { type GeneralActionParams = ActionParams & {
name: BladeGeneralActionName; name: BladeGeneralActionName;
@@ -28,8 +29,9 @@ export class GeneralAction extends ActionClass {
getSuccessChance(__bladeburner: Bladeburner, __person: Person): number { getSuccessChance(__bladeburner: Bladeburner, __person: Person): number {
return 1; return 1;
} }
getSuccessRange(bladeburner: Bladeburner, person: Person): [minChance: number, maxChance: number] { getSuccessRange(bladeburner: Bladeburner, person: Person): [minChance: number, maxChance: number] {
const chance = this.getSuccessChance(bladeburner, person); const chance = clampNumber(this.getSuccessChance(bladeburner, person), 0, 1);
return [chance, chance]; return [chance, chance];
} }
} }

1
src/NetscriptFunctions/Bladeburner.ts
View File

@@ -129,7 +129,6 @@ export function NetscriptBladeburner(): InternalAPI<INetscriptBladeburner> {
checkSleeveNumber(ctx, sleeveNumber); checkSleeveNumber(ctx, sleeveNumber);
switch (action.type) { switch (action.type) {
case BladeActionType.general: case BladeActionType.general:
return [1, 1];
case BladeActionType.contract: { case BladeActionType.contract: {
const sleevePerson = Player.sleeves[sleeveNumber]; const sleevePerson = Player.sleeves[sleeveNumber];
return action.getSuccessRange(bladeburner, sleevePerson); return action.getSuccessRange(bladeburner, sleevePerson);