CODEBASE: Expand lint rules, and Aliases are stored as maps (#501)

src/Hacknet/HacknetServer.ts

@@ -12,6 +12,7 @@ import {
   calculateCacheUpgradeCost,
 } from "./formulas/HacknetServers";
 
+import { IPAddress } from "../Types/strings";
 import { createRandomIp } from "../utils/IPAddress";
 
 import { IReviverValue, constructorsForReviver } from "../utils/JSONReviver";
@@ -20,7 +21,7 @@ import { Player } from "@player";
 interface IConstructorParams {
   adminRights?: boolean;
   hostname: string;
-  ip?: string;
+  ip?: IPAddress;
   isConnectedTo?: boolean;
   maxRam?: number;
   organizationName?: string;

src/Hacknet/ui/HacknetServerElem.tsx

@@ -232,9 +232,6 @@ export function HacknetServerElem(props: IProps): React.ReactElement {
         </Button>
       </Tooltip>
     );
-    if (Player.money < upgradeCacheCost) {
-    } else {
-    }
   }
   function upgradeCacheOnClick(): void {
     let numUpgrades = purchaseMult;

src/Hacknet/ui/HacknetUpgradeElem.tsx

@@ -24,21 +24,21 @@ interface IProps {
   rerender: () => void;
 }
 
-const serversMap: { [key: string]: string } = {};
-const companiesMap: { [key: string]: string } = {};
+const serversMap: Record<string, string> = {};
+const companiesMap: Record<string, string> = {};
 
 export function HacknetUpgradeElem(props: IProps): React.ReactElement {
   const [selectedServer, setSelectedServer] = useState(
     serversMap[props.upg.name] ? serversMap[props.upg.name] : FactionNames.ECorp.toLowerCase(),
   );
-  function changeTargetServer(event: SelectChangeEvent<string>): void {
+  function changeTargetServer(event: SelectChangeEvent): void {
     setSelectedServer(event.target.value);
     serversMap[props.upg.name] = event.target.value;
   }
   const [selectedCompany, setSelectedCompany] = useState(
     companiesMap[props.upg.name] ? companiesMap[props.upg.name] : companiesMetadata[0].name,
   );
-  function changeTargetCompany(event: SelectChangeEvent<string>): void {
+  function changeTargetCompany(event: SelectChangeEvent): void {
     setSelectedCompany(event.target.value);
     companiesMap[props.upg.name] = event.target.value;
   }