CODEBASE: Expand lint rules, and Aliases are stored as maps (#501)

src/DevMenu/ui/Augmentations.tsx

@@ -17,7 +17,7 @@ import { Player } from "@player";
 export function Augmentations(): React.ReactElement {
   const [augmentation, setAugmentation] = useState("Augmented Targeting I");
 
-  function setAugmentationDropdown(event: SelectChangeEvent<string>): void {
+  function setAugmentationDropdown(event: SelectChangeEvent): void {
     setAugmentation(event.target.value);
   }
   function queueAug(): void {

src/DevMenu/ui/Bladeburner.tsx

@@ -59,8 +59,8 @@ export function Bladeburner(): React.ReactElement {
   };
 
   // Skill functions
-  const [skill, setSkill] = useState(SkillNames.BladesIntuition as string);
-  function setSkillDropdown(event: SelectChangeEvent<string>): void {
+  const [skill, setSkill] = useState(SkillNames.BladesIntuition);
+  function setSkillDropdown(event: SelectChangeEvent): void {
     setSkill(event.target.value);
   }
   const modifySkill = (modifier: number) => (levelchange: number) => {
@@ -82,8 +82,8 @@ export function Bladeburner(): React.ReactElement {
 
   // Contract functions
   const AllContracts = bladeburner.contracts;
-  const [contractTarget, setContract] = useState(AllContracts.Tracking.name as string);
-  function setContractDropdown(event: SelectChangeEvent<string>): void {
+  const [contractTarget, setContract] = useState(AllContracts.Tracking.name);
+  function setContractDropdown(event: SelectChangeEvent): void {
     setContract(event.target.value);
   }
   const modifyContractLevel = (modifier: number) => (levelchange: number) => {
@@ -117,8 +117,8 @@ export function Bladeburner(): React.ReactElement {
 
   // Operation functions
   const AllOperations = bladeburner.operations;
-  const [operationTarget, setOperation] = useState(AllOperations.Investigation.name as string);
-  function setOperationDropdown(event: SelectChangeEvent<string>): void {
+  const [operationTarget, setOperation] = useState(AllOperations.Investigation.name);
+  function setOperationDropdown(event: SelectChangeEvent): void {
     setOperation(event.target.value);
   }
   const modifyOperationLevel = (modifier: number) => (levelchange: number) => {

src/DevMenu/ui/CodingContracts.tsx

@@ -14,7 +14,7 @@ import { CodingContractTypes } from "../../CodingContracts";
 
 export function CodingContracts(): React.ReactElement {
   const [codingcontract, setCodingcontract] = useState("Find Largest Prime Factor");
-  function setCodingcontractDropdown(event: SelectChangeEvent<string>): void {
+  function setCodingcontractDropdown(event: SelectChangeEvent): void {
     setCodingcontract(event.target.value);
   }
 

src/DevMenu/ui/Companies.tsx

@@ -17,7 +17,7 @@ const bigNumber = 1e12;
 
 export function Companies(): React.ReactElement {
   const [company, setCompany] = useState(FactionNames.ECorp as string);
-  function setCompanyDropdown(event: SelectChangeEvent<string>): void {
+  function setCompanyDropdown(event: SelectChangeEvent): void {
     setCompany(event.target.value);
   }
   function resetCompanyRep(): void {

src/DevMenu/ui/Factions.tsx

@@ -24,7 +24,7 @@ const bigNumber = 1e12;
 export function Factions(): React.ReactElement {
   const [faction, setFaction] = useState(FactionNames.Illuminati as string);
 
-  function setFactionDropdown(event: SelectChangeEvent<string>): void {
+  function setFactionDropdown(event: SelectChangeEvent): void {
     setFaction(event.target.value);
   }
 

src/DevMenu/ui/General.tsx

@@ -71,7 +71,7 @@ export function General(): React.ReactElement {
     // Rerender so the gang menu option will be removed immediately on the devmenu page selection
     ThemeEvents.emit();
   };
-  const setGangFactionDropdown = (event: SelectChangeEvent<string>) => setGangFaction(event.target.value);
+  const setGangFactionDropdown = (event: SelectChangeEvent) => setGangFaction(event.target.value);
 
   // Misc functions
   const checkMessages = () => checkForMessagesToSend();

src/DevMenu/ui/Programs.tsx

@@ -14,7 +14,7 @@ import { CompletedProgramName } from "../../Programs/Programs";
 
 export function Programs(): React.ReactElement {
   const [program, setProgram] = useState(CompletedProgramName.bruteSsh);
-  function setProgramDropdown(event: SelectChangeEvent<string>): void {
+  function setProgramDropdown(event: SelectChangeEvent): void {
     setProgram(event.target.value as CompletedProgramName);
   }
   function addProgram(): void {

src/DevMenu/ui/Servers.tsx

@@ -14,7 +14,7 @@ import MenuItem from "@mui/material/MenuItem";
 
 export function Servers(): React.ReactElement {
   const [server, setServer] = useState("home");
-  function setServerDropdown(event: SelectChangeEvent<string>): void {
+  function setServerDropdown(event: SelectChangeEvent): void {
     setServer(event.target.value);
   }
   function rootServer(): void {

src/DevMenu/ui/StockMarket.tsx

@@ -39,7 +39,7 @@ export function StockMarket(): React.ReactElement {
     }
 
     for (const name of Object.keys(SM)) {
-      if (SM.hasOwnProperty(name)) {
+      if (Object.hasOwn(SM, name)) {
         const stock = SM[name];
         if (stock instanceof Stock && match(stock.symbol)) {
           sub(stock);