diff --git a/electron/achievements.js b/electron/achievements.js index 5905f3912..ad2fb8dcc 100644 --- a/electron/achievements.js +++ b/electron/achievements.js @@ -2,19 +2,25 @@ const greenworks = require("./greenworks"); const log = require("electron-log"); -function enableAchievementsInterval(window) { +async function enableAchievementsInterval(window) { // If the Steam API could not be initialized on game start, we'll abort this. if (global.greenworksError) return; // This is backward but the game fills in an array called `document.achievements` and we retrieve it from // here. Hey if it works it works. const steamAchievements = greenworks.getAchievementNames(); + log.debug(`All Steam achievements ${JSON.stringify(steamAchievements)}`); + const playerAchieved = (await Promise.all(steamAchievements.map(checkSteamAchievement))).filter(name => !!name); + log.debug(`Player has Steam achievements ${JSON.stringify(playerAchieved)}`); const intervalID = setInterval(async () => { try { const playerAchievements = await window.webContents.executeJavaScript("document.achievements"); for (const ach of playerAchievements) { - if (!steamAchievements.includes(ach)) continue; + if (!steamAchievements.includes(ach)) continue; // Don't try activating achievements that don't exist Steam-side + if (playerAchieved.includes(ach)) continue; // Don't spam achievements that have already been recorded + log.info(`Granting Steam achievement ${ach}`); greenworks.activateAchievement(ach, () => undefined); + playerAchieved.push(ach); } } catch (error) { log.error(error); @@ -28,6 +34,15 @@ function enableAchievementsInterval(window) { window.achievementsIntervalID = intervalID; } +function checkSteamAchievement(name) { + return new Promise((resolve) => { + greenworks.getAchievement(name, playerHas => resolve(playerHas ? name : ""), err => { + log.warn(`Failed to get Steam achievement ${name} status: ${err}`); + resolve(""); + }); + }); +} + function disableAchievementsInterval(window) { if (window.achievementsIntervalID) { clearInterval(window.achievementsIntervalID);