MISC: Fix typos and duplicating ms per cycle constant (#2436)

src/NetscriptFunctions/Bladeburner.ts

@@ -20,6 +20,7 @@ import { BlackOperations, blackOpsArray } from "../Bladeburner/data/BlackOperati
 import { checkSleeveAPIAccess, checkSleeveNumber } from "../NetscriptFunctions/Sleeve";
 import { canAccessBitNodeFeature } from "../BitNode/BitNodeUtils";
 import { calculateActionRankGain, calculateActionReputationGain } from "../Bladeburner/Formulas";
+import { CONSTANTS } from "../Constants";
 
 export function NetscriptBladeburner(): InternalAPI<INetscriptBladeburner> {
   const checkBladeburnerAccess = function (ctx: NetscriptContext): void {
@@ -348,7 +349,7 @@ export function NetscriptBladeburner(): InternalAPI<INetscriptBladeburner> {
     },
     getBonusTime: (ctx) => () => {
       const bladeburner = getBladeburner(ctx);
-      return bladeburner.storedCycles * 200;
+      return bladeburner.storedCycles * CONSTANTS.MilliPerCycle;
     },
     nextUpdate: (ctx) => () => {
       checkBladeburnerAccess(ctx);

src/NetscriptFunctions/Corporation.ts

@@ -72,6 +72,7 @@ import {
 import { PositiveInteger } from "../types";
 import { getRecordKeys } from "../Types/Record";
 import { setDeprecatedProperties } from "../utils/DeprecationHelper";
+import { CONSTANTS } from "../Constants";
 
 export function NetscriptCorporation(): InternalAPI<NSCorporation> {
   function hasUnlock(unlockName: CorpUnlockName): boolean {
@@ -802,7 +803,7 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
     },
     getBonusTime: (ctx) => () => {
       checkAccess(ctx);
-      return getCorporation().storedCycles * 200;
+      return getCorporation().storedCycles * CONSTANTS.MilliPerCycle;
     },
     nextUpdate: (ctx) => () => {
       checkAccess(ctx);

src/NetscriptFunctions/Gang.ts

@@ -13,6 +13,7 @@ import { GangMemberTasks } from "../Gang/GangMemberTasks";
 import { GangMemberUpgrades } from "../Gang/GangMemberUpgrades";
 import { helpers } from "../Netscript/NetscriptHelpers";
 import { getEnumHelper } from "../utils/EnumHelper";
+import { CONSTANTS } from "../Constants";
 
 export function NetscriptGang(): InternalAPI<IGang> {
   /** Functions as an API check and also returns the gang object */
@@ -353,7 +354,7 @@ export function NetscriptGang(): InternalAPI<IGang> {
     },
     getBonusTime: (ctx) => () => {
       const gang = getGang(ctx);
-      return gang.storedCycles * 200;
+      return gang.storedCycles * CONSTANTS.MilliPerCycle;
     },
     nextUpdate: (ctx) => () => {
       getGang(ctx);

src/NetscriptFunctions/StockMarket.ts

@@ -23,6 +23,7 @@ import { setRemovedFunctions, type InternalAPI, type NetscriptContext } from "..
 import { helpers } from "../Netscript/NetscriptHelpers";
 import { StockMarketConstants } from "../StockMarket/data/Constants";
 import { getEnumHelper } from "../utils/EnumHelper";
+import { CONSTANTS } from "../Constants";
 
 export function NetscriptStockMarket(): InternalAPI<StockAPI> {
   /** Checks if the player has TIX API access. Throws an error if the player does not */
@@ -332,7 +333,7 @@ export function NetscriptStockMarket(): InternalAPI<StockAPI> {
     },
     getBonusTime: (ctx) => () => {
       checkTixApiAccess(ctx);
-      return StockMarket.storedCycles * 200;
+      return StockMarket.storedCycles * CONSTANTS.MilliPerCycle;
     },
     nextUpdate: (ctx) => () => {
       checkTixApiAccess(ctx);