From c3dc275d34c19def11474661b552fc6abb1f9bc7 Mon Sep 17 00:00:00 2001
From: Tom Prince <tom.prince@hocat.ca>
Date: Fri, 26 Jul 2024 02:56:09 -0600
Subject: [PATCH] MISC: Show values of constants in type hints. (#1515)

---
 src/Bladeburner/data/Constants.ts  |  2 +-
 src/Constants.ts                   |  2 +-
 src/CotMG/data/Constants.ts        |  2 +-
 src/Gang/data/Constants.ts         |  2 +-
 src/Hacknet/data/Constants.ts      |  4 ++--
 src/Server/data/Constants.ts       | 14 ++------------
 src/utils/StringHelperFunctions.ts |  2 +-
 7 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/src/Bladeburner/data/Constants.ts b/src/Bladeburner/data/Constants.ts
index a89050e45..1fa0bf3b6 100644
--- a/src/Bladeburner/data/Constants.ts
+++ b/src/Bladeburner/data/Constants.ts
@@ -50,4 +50,4 @@ export const BladeburnerConstants = {
 
   HrcHpGain: 2, // HP Gained from Hyperbolic Regeneration chamber
   HrcStaminaGain: 1, // Percentage Stamina gained from Hyperbolic Regeneration Chamber
-};
+} as const;
diff --git a/src/Constants.ts b/src/Constants.ts
index d2489a1ab..d5c70acfc 100644
--- a/src/Constants.ts
+++ b/src/Constants.ts
@@ -119,4 +119,4 @@ See 2.6.2 changelog at https://github.com/bitburner-official/bitburner-src/blob/
 
 - Nerf noodle bar
 `,
-};
+} as const;
diff --git a/src/CotMG/data/Constants.ts b/src/CotMG/data/Constants.ts
index 578aac1e1..f48321e69 100644
--- a/src/CotMG/data/Constants.ts
+++ b/src/CotMG/data/Constants.ts
@@ -2,4 +2,4 @@ export const StanekConstants = {
   RAMBonus: 0.1,
   BaseSize: 9,
   MaxSize: 25,
-};
+} as const;
diff --git a/src/Gang/data/Constants.ts b/src/Gang/data/Constants.ts
index 365ba3b06..6c9e7e9cc 100644
--- a/src/Gang/data/Constants.ts
+++ b/src/Gang/data/Constants.ts
@@ -29,4 +29,4 @@ export const GangConstants = {
   minCyclesToProcess: 2000 / CONSTANTS.MilliPerCycle,
   /** Maximum number of cycles to process at once during bonus time (5 seconds) */
   maxCyclesToProcess: 5000 / CONSTANTS.MilliPerCycle,
-};
+} as const;
diff --git a/src/Hacknet/data/Constants.ts b/src/Hacknet/data/Constants.ts
index 140e72edc..f76480875 100644
--- a/src/Hacknet/data/Constants.ts
+++ b/src/Hacknet/data/Constants.ts
@@ -14,7 +14,7 @@ export const HacknetNodeConstants = {
   MaxLevel: 200,
   MaxRam: 64,
   MaxCores: 16,
-};
+} as const;
 
 export const PurchaseMultipliers: {
   [key: string]: number | "MAX" | undefined;
@@ -49,4 +49,4 @@ export const HacknetServerConstants = {
   MaxRam: 8192,
   MaxCores: 128,
   MaxCache: 15,
-};
+} as const;
diff --git a/src/Server/data/Constants.ts b/src/Server/data/Constants.ts
index ce2ee7a86..d0af87668 100644
--- a/src/Server/data/Constants.ts
+++ b/src/Server/data/Constants.ts
@@ -1,14 +1,4 @@
-export const ServerConstants: {
-  BaseCostFor1GBOfRamHome: number;
-  BaseCostFor1GBOfRamServer: number;
-  HomeComputerMaxRam: number;
-  ServerBaseGrowthIncr: number;
-  ServerMaxGrowthLog: number;
-  ServerFortifyAmount: number;
-  ServerWeakenAmount: number;
-  PurchasedServerLimit: number;
-  PurchasedServerMaxRam: number;
-} = {
+export const ServerConstants = {
   // Base RAM costs
   BaseCostFor1GBOfRamHome: 32000,
   BaseCostFor1GBOfRamServer: 55000, //1 GB of RAM
@@ -21,4 +11,4 @@ export const ServerConstants: {
 
   PurchasedServerLimit: 25,
   PurchasedServerMaxRam: 1048576, // 2^20
-};
+} as const;
diff --git a/src/utils/StringHelperFunctions.ts b/src/utils/StringHelperFunctions.ts
index 792f27395..f0a4e7b00 100644
--- a/src/utils/StringHelperFunctions.ts
+++ b/src/utils/StringHelperFunctions.ts
@@ -120,7 +120,7 @@ export function capitalizeEachWord(s: string): string {
     .join(" ");
 }
 
-export function getNsApiDocumentationUrl(isDevBranch = CONSTANTS.isDevBranch): string {
+export function getNsApiDocumentationUrl(isDevBranch: boolean = CONSTANTS.isDevBranch): string {
   return `https://github.com/bitburner-official/bitburner-src/blob/${
     isDevBranch ? "dev" : "stable"
   }/markdown/bitburner.ns.md`;