Fixed numerous reported bugs. Refactored some of the directory-related code. Added documentation for MasonDs changes to hack/grow/weaken

src/Script/RamCalculationErrorCodes.ts

@@ -0,0 +1,5 @@
+export enum RamCalculationErrorCode {
+    SyntaxError = -1,
+    ImportError = -2,
+    URLImportError = -3,
+}

src/Script/RamCalculations.js

@@ -1,6 +1,8 @@
 // Calculate a script's RAM usage
 import * as walk from "acorn-walk";
 
+import { RamCalculationErrorCode } from "./RamCalculationErrorCodes";
+
 import { RamCosts, RamCostConstants } from "../Netscript/RamCostGenerator";
 import { parse, Node } from "../../utils/acorn";
 
@@ -71,12 +73,12 @@ async function parseOnlyRamCalculate(otherScripts, code, workerScript) {
                     }
                 } catch(e) {
                     console.error(`Error dynamically importing module from ${nextModule} for RAM calculations: ${e}`);
-                    return -1;
+                    return RamCalculationErrorCode.URLImportError;
                 }
             } else {
                 if (!Array.isArray(otherScripts)) {
                     console.warn(`parseOnlyRamCalculate() not called with array of scripts`);
-                    return -1;
+                    return RamCalculationErrorCode.ImportError;
                 }
 
                 let script = null;
@@ -89,8 +91,7 @@ async function parseOnlyRamCalculate(otherScripts, code, workerScript) {
                 }
 
                 if (script == null) {
-                    console.warn("Invalid script");
-                    return -1;  // No such script on the server.
+                    return RamCalculationErrorCode.ImportError;  // No such script on the server
                 }
 
                 code = script.code;
@@ -191,7 +192,7 @@ async function parseOnlyRamCalculate(otherScripts, code, workerScript) {
         // console.info("parse or eval error: ", error);
         // This is not unexpected. The user may be editing a script, and it may be in
         // a transitory invalid state.
-        return -1;
+        return RamCalculationErrorCode.SyntaxError;
     }
 }
 
@@ -310,8 +311,8 @@ export async function calculateRamUsage(codeCopy, otherScripts) {
 	} catch (e) {
         console.error(`Failed to parse script for RAM calculations:`);
         console.error(e);
-        return -1;
+        return RamCalculationErrorCode.SyntaxError;
 	}
 
-    return -1;
+    return RamCalculationErrorCode.SyntaxError;
 }

src/Script/Script.ts

@@ -89,7 +89,7 @@ export class Script {
     // Updates the script's RAM usage based on its code
     async updateRamUsage(otherScripts: Script[]) {
         var res = await calculateRamUsage(this.code, otherScripts);
-        if (res !== -1) {
+        if (res > 0) {
             this.ramUsage = roundToTwo(res);
         }
     }

src/Script/ScriptHelpers.js

@@ -1,5 +1,6 @@
 import { Script } from "./Script";
 
+import { RamCalculationErrorCode } from "./RamCalculationErrorCodes";
 import { calculateRamUsage } from "./RamCalculations";
 import { isScriptFilename } from "./ScriptHelpersTS";
 
@@ -190,10 +191,22 @@ export async function updateScriptEditorContent() {
 
     var codeCopy = code.repeat(1);
     var ramUsage = await calculateRamUsage(codeCopy, Player.getCurrentServer().scripts);
-    if (ramUsage !== -1) {
+    if (ramUsage > 0) {
         scriptEditorRamText.innerText = "RAM: " + numeralWrapper.format(ramUsage, '0.00') + " GB";
     } else {
-        scriptEditorRamText.innerText = "RAM: Syntax Error";
+        switch (ramUsage) {
+            case RamCalculationErrorCode.ImportError:
+                scriptEditorRamText.innerText = "RAM: Import Error";
+                break;
+            case RamCalculationErrorCode.URLImportError:
+                scriptEditorRamText.innerText = "RAM: HTTP Import Error";
+                break;
+            case RamCalculationErrorCode.SyntaxError:
+            default:
+                scriptEditorRamText.innerText = "RAM: Syntax Error";
+                break;
+        }
+
     }
 }