Refactor for ... in loops

src/PersonObjects/Person.ts

@@ -112,7 +112,7 @@ export abstract class Person {
    * Updates this object's multipliers for the given augmentation
    */
   applyAugmentation(aug: Augmentation): void {
-    for (const mult in aug.mults) {
+    for (const mult of Object.keys(aug.mults)) {
       if ((this as any)[mult] == null) {
         console.warn(`Augmentation has unrecognized multiplier property: ${mult}`);
       } else {

src/PersonObjects/Player/PlayerObjectGeneralMethods.tsx

@@ -1484,7 +1484,7 @@ export function finishCrime(this: IPlayer, cancelled: boolean): string {
     if (determineCrimeSuccess(this, this.crimeType)) {
       //Handle Karma and crime statistics
       let crime = null;
-      for (const i in Crimes) {
+      for (const i of Object.keys(Crimes)) {
         if (Crimes[i].type == this.crimeType) {
           crime = Crimes[i];
           break;
@@ -2556,15 +2556,15 @@ export function setBitNodeNumber(this: IPlayer, n: number): void {
 }
 
 export function queueAugmentation(this: IPlayer, name: string): void {
-  for (const i in this.queuedAugmentations) {
-    if (this.queuedAugmentations[i].name == name) {
+  for (const aug of this.queuedAugmentations) {
+    if (aug.name == name) {
       console.warn(`tried to queue ${name} twice, this may be a bug`);
       return;
     }
   }
 
-  for (const i in this.augmentations) {
-    if (this.augmentations[i].name == name) {
+  for (const aug of this.augmentations) {
+    if (aug.name == name) {
       console.warn(`tried to queue ${name} twice, this may be a bug`);
       return;
     }

src/PersonObjects/Resleeving/Resleeving.ts

@@ -37,7 +37,7 @@ export function purchaseResleeve(r: Resleeve, p: IPlayer): boolean {
   p.charisma_exp = r.charisma_exp;
 
   // Reset Augmentation "owned" data
-  for (const augKey in Augmentations) {
+  for (const augKey of Object.keys(Augmentations)) {
     Augmentations[augKey].owned = false;
   }
 

src/PersonObjects/Sleeve/SleeveHelpers.ts

@@ -42,7 +42,7 @@ export function findSleevePurchasableAugs(sleeve: Sleeve, p: IPlayer): Augmentat
   if (p.inGang()) {
     const fac = p.getGangFaction();
 
-    for (const augName in Augmentations) {
+    for (const augName of Object.keys(Augmentations)) {
       const aug = Augmentations[augName];
       if (!isAvailableForSleeve(aug)) {
         continue;