CORPORATION: Rename division.type to division.industry (#2152)

This commit is contained in:
catloversg
2025-05-28 18:47:26 +07:00
committed by GitHub
parent e31b174137
commit 9824166dbf
11 changed files with 61 additions and 45 deletions
+13 -4
View File
@@ -71,6 +71,7 @@ import {
} from "../Corporation/helpers";
import { PositiveInteger } from "../types";
import { getRecordKeys } from "../Types/Record";
import { setDeprecatedProperties } from "../utils/DeprecationHelper";
export function NetscriptCorporation(): InternalAPI<NSCorporation> {
function hasUnlock(unlockName: CorpUnlockName): boolean {
@@ -94,8 +95,8 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
}
function getResearchCost(division: Division, researchName: CorpResearchName): number {
const researchTree = IndustryResearchTrees[division.type];
if (researchTree === undefined) throw new Error(`No research tree for industry '${division.type}'`);
const researchTree = IndustryResearchTrees[division.industry];
if (researchTree === undefined) throw new Error(`No research tree for industry '${division.industry}'`);
const allResearch = researchTree.getAllNodes();
if (!allResearch.includes(researchName)) throw new Error(`No research named '${researchName}'`);
const research = ResearchMap[researchName];
@@ -157,9 +158,9 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
function getSafeDivision(division: Division): NSDivision {
const cities = getRecordKeys(division.offices);
return {
const data = {
name: division.name,
type: division.type,
industry: division.industry,
awareness: division.awareness,
popularity: division.popularity,
productionMult: division.productionMult,
@@ -174,6 +175,14 @@ export function NetscriptCorporation(): InternalAPI<NSCorporation> {
makesProducts: division.makesProducts,
maxProducts: division.maxProducts,
};
setDeprecatedProperties(data, {
type: {
identifier: "ns.corporation.getDivision().type",
message: "Use ns.corporation.getDivision().industry instead.",
value: data.industry,
},
});
return data;
}
const warehouseAPI: InternalAPI<WarehouseAPI> = {