felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-05-03 22:37:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

BUGFIX: Wrong success chance in ns.bladeburner.getActionEstimatedSuccessChance (#1450)

Browse Source
This commit is contained in:
catloversg
2024-07-03 05:07:56 +07:00
committed by GitHub
parent 922f0bfcc5
commit 960fe5aa8b
5 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NetscriptFunctions/Bladeburner.ts
+13 -8
View File
@@ -120,16 +120,21 @@ export function NetscriptBladeburner(): InternalAPI<INetscriptBladeburner> {
getActionEstimatedSuccessChance: (ctx) => (type, name, _sleeve) => {
const bladeburner = getBladeburner(ctx);
const action = getAction(ctx, type, name);
if (_sleeve != null) {
checkSleeveAPIAccess(ctx);
const sleeveNumber = helpers.number(ctx, "sleeve", _sleeve);
checkSleeveNumber(ctx, sleeveNumber);
if (action.type === BladeActionType.contract) {
if (_sleeve == null) {
return action.getSuccessRange(bladeburner, Player);
}
checkSleeveAPIAccess(ctx);
const sleeveNumber = helpers.number(ctx, "sleeve", _sleeve);
checkSleeveNumber(ctx, sleeveNumber);
switch (action.type) {
case BladeActionType.general:
return [1, 1];
case BladeActionType.contract: {
const sleevePerson = Player.sleeves[sleeveNumber];
return action.getSuccessRange(bladeburner, sleevePerson);
} else return [0, 0];
} else {
return action.getSuccessRange(bladeburner, Player);
}
default:
return [0, 0];
}
},
getActionRepGain: (ctx) => (type, name, _level) => {
src/NetscriptFunctions/Sleeve.ts
-1
View File
@@ -28,7 +28,6 @@ export const checkSleeveAPIAccess = function (ctx: NetscriptContext) {
export const checkSleeveNumber = function (ctx: NetscriptContext, sleeveNumber: number) {
if (sleeveNumber >= Player.sleeves.length || sleeveNumber < 0) {
const msg = `Invalid sleeve number: ${sleeveNumber}`;
helpers.log(ctx, () => msg);
throw helpers.errorMessage(ctx, msg);
}
};