From 9308301b12c70cd93c4d96c3a07af162f7ddd726 Mon Sep 17 00:00:00 2001
From: catloversg <152669316+catloversg@users.noreply.github.com>
Date: Fri, 2 Aug 2024 12:44:03 +0700
Subject: [PATCH] UI: Fix misleading favor numbers (#1530)

---
 src/Faction/ui/AugmentationsPage.tsx | 2 +-
 src/Faction/ui/FactionsRoot.tsx      | 4 +---
 src/Faction/ui/Info.tsx              | 2 +-
 src/ui/formatNumber.ts               | 2 +-
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/Faction/ui/AugmentationsPage.tsx b/src/Faction/ui/AugmentationsPage.tsx
index c1b9c0c9f..1dbc2f5af 100644
--- a/src/Faction/ui/AugmentationsPage.tsx
+++ b/src/Faction/ui/AugmentationsPage.tsx
@@ -207,7 +207,7 @@ export function AugmentationsPage({ faction }: { faction: Faction }): React.Reac
             <Typography>
               <b>Reputation:</b> <Reputation reputation={faction.playerReputation} />
               <br />
-              <b>Favor:</b> <Favor favor={Math.floor(faction.favor)} />
+              <b>Favor:</b> <Favor favor={faction.favor} />
             </Typography>
           </Box>
           <Box sx={{ display: "grid", gridTemplateColumns: "repeat(4, 1fr)" }}>
diff --git a/src/Faction/ui/FactionsRoot.tsx b/src/Faction/ui/FactionsRoot.tsx
index ad13f0698..694f35cee 100644
--- a/src/Faction/ui/FactionsRoot.tsx
+++ b/src/Faction/ui/FactionsRoot.tsx
@@ -193,9 +193,7 @@ const FactionElement = (props: FactionElementProps): React.ReactElement => {
 
       {props.faction.isMember && (
         <Box display="grid" sx={{ alignItems: "center", justifyItems: "left", gridAutoFlow: "row" }}>
-          <Typography sx={{ color: Settings.theme.rep }}>
-            {formatFavor(Math.floor(props.faction.favor))} favor
-          </Typography>
+          <Typography sx={{ color: Settings.theme.rep }}>{formatFavor(props.faction.favor)} favor</Typography>
           <Typography sx={{ color: Settings.theme.rep }}>
             {formatReputation(props.faction.playerReputation)} rep
           </Typography>
diff --git a/src/Faction/ui/Info.tsx b/src/Faction/ui/Info.tsx
index df54f4cc7..82804f9ef 100644
--- a/src/Faction/ui/Info.tsx
+++ b/src/Faction/ui/Info.tsx
@@ -91,7 +91,7 @@ export function Info(props: IProps): React.ReactElement {
           }
         >
           <Typography>
-            Faction Favor: <Favor favor={Math.floor(props.faction.favor)} />
+            Faction Favor: <Favor favor={props.faction.favor} />
           </Typography>
         </Tooltip>
       </Box>
diff --git a/src/ui/formatNumber.ts b/src/ui/formatNumber.ts
index 1c642d72f..1de501ce0 100644
--- a/src/ui/formatNumber.ts
+++ b/src/ui/formatNumber.ts
@@ -143,7 +143,7 @@ export function formatNumber(n: number, fractionalDigits = 3, suffixStart = 1000
 export const formatNumberNoSuffix = (n: number, fractionalDigits = 0) => {
   return formatNumber(n, fractionalDigits, 1e33);
 };
-export const formatFavor = formatNumberNoSuffix;
+export const formatFavor = (n: number) => formatNumberNoSuffix(n, 3);
 
 /** Standard noninteger formatting with no options set. Collapses to suffix at 1000 and shows 3 fractional digits. */
 export const formatBigNumber = (n: number) => formatNumber(n);