Merge pull request #2046 from MartinFournier/fix/tests

Fix jest unit tests & add a github action workflow to build, test & lint

src/Electron.tsx

@@ -32,6 +32,7 @@ function bitNodeFinishedState(): boolean {
   return Player.bladeburner !== null && Player.bladeburner.blackops.hasOwnProperty("Operation Daedalus");
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function sfAchievement(): Achievement[] {
   const achs: Achievement[] = [];
   for (let i = 0; i <= 11; i++) {

src/NetscriptFunctions/toNative.ts

@@ -4,6 +4,7 @@ const defaultInterpreter = new Interpreter("", () => undefined);
 
 // the acorn interpreter has a bug where it doesn't convert arrays correctly.
 // so we have to more or less copy it here.
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function toNative(pseudoObj: any): any {
   if (pseudoObj == null) return null;
   if (

src/PersonObjects/Player/PlayerObjectGeneralMethods.tsx

@@ -26,7 +26,7 @@ import { Locations } from "../../Locations/Locations";
 import { CityName } from "../../Locations/data/CityNames";
 import { LocationName } from "../../Locations/data/LocationNames";
 import { Sleeve } from "../../PersonObjects/Sleeve/Sleeve";
-import { calculateSkill as calculateSkillF, calculateSkillProgress as calculateSkillProgressF, getEmptySkillProgress, ISkillProgress } from "../formulas/skill";
+import { calculateSkill as calculateSkillF, calculateSkillProgress as calculateSkillProgressF, ISkillProgress } from "../formulas/skill";
 import { calculateIntelligenceBonus } from "../formulas/intelligence";
 import {
   getHackingWorkRepGain,

src/ScriptEditor/ui/ScriptEditorRoot.tsx

@@ -104,8 +104,8 @@ let currentScript = {} as openScript; // Script currently being viewed
 export function Root(props: IProps): React.ReactElement {
   const editorRef = useRef<IStandaloneCodeEditor | null>(null);
   const monacoRef = useRef<Monaco | null>(null);
-  const [filename, setFilename] = useState(props.filename);
-  const [code, setCode] = useState<string>(props.code);
+  const [filename] = useState(props.filename);
+  const [code] = useState<string>(props.code);
   const [decorations, setDecorations] = useState<string[]>([]);
   const [ram, setRAM] = useState("RAM: ???");
   const [updatingRam, setUpdatingRam] = useState(false);

src/Server/BaseServer.ts

@@ -246,6 +246,7 @@ export class BaseServer {
     this.maxRam = ram;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   updateRamUsed(ram: number, player: IPlayer): void {
     this.ramUsed = ram;
   }

src/Terminal/DirectoryHelpers.ts

@@ -35,7 +35,7 @@ export function removeTrailingSlash(s: string): string {
  * Checks whether a string is a valid filename. Only used for the filename itself,
  * not the entire filepath
  */
-function isValidFilename(filename: string): boolean {
+export function isValidFilename(filename: string): boolean {
   // Allows alphanumerics, hyphens, underscores, and percentage signs
   // Must have a file extension
   const regex = /^[.a-zA-Z0-9_-]+[.][a-zA-Z0-9]+(?:-\d+(?:\.\d*)?%-INC)?$/;
@@ -48,7 +48,7 @@ function isValidFilename(filename: string): boolean {
  * Checks whether a string is a valid directory name. Only used for the directory itself,
  * not an entire path
  */
-function isValidDirectoryName(name: string): boolean {
+ export function isValidDirectoryName(name: string): boolean {
   // Allows alphanumerics, hyphens, underscores, and percentage signs.
   // Name can begin with a single period, but otherwise cannot have any
   const regex = /^.?[a-zA-Z0-9_-]+$/;
@@ -178,14 +178,14 @@ export function getAllParentDirectories(path: string): string {
  * @param cwd The current working directory
  * @returns A file path which may be absolute or relative
  */
-export function getDestinationFilepath(destination: string, source: string, cwd: string) {
+export function getDestinationFilepath(destination: string, source: string, cwd: string): string {
   const dstDir = evaluateDirectoryPath(destination, cwd);
   // If evaluating the directory for this destination fails, we have a filename or full path.
   if (dstDir === null) {
     return destination;
   } else {
     // Append the filename to the directory provided.
-    let t_path = removeTrailingSlash(dstDir);
+    const t_path = removeTrailingSlash(dstDir);
     const fileName = getFileName(source);
     return t_path + "/" + fileName;
   }

src/Terminal/commands/download.ts

@@ -24,7 +24,7 @@ export function download(
       const matchEnding = fn.length == 1 || fn === "*.*" ? null : fn.slice(1); // Treat *.* the same as *
       const zip = new JSZip();
       // Helper function to zip any file contents whose name matches the pattern
-      const zipFiles = (fileNames: string[], fileContents: string[]) => {
+      const zipFiles = (fileNames: string[], fileContents: string[]): void => {
         for (let i = 0; i < fileContents.length; ++i) {
           let name = fileNames[i];
           if (name.startsWith("/")) name = name.slice(1);