felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-22 17:23:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

CODEBASE: Remove redundant check in getServer utility function and serverExists API (#2357)

Browse Source
This commit is contained in:
catloversg
2025-10-20 01:45:30 +07:00
committed by GitHub
parent b495deb458
commit 6837f334fd
4 changed files with 160 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/jest/Netscript/DisableLog.test.ts
+75 -80
View File
@@ -1,92 +1,87 @@
import type { Script } from "../../../src/Script/Script";
import type { ScriptFilePath } from "../../../src/Paths/ScriptFilePath";
import { FormatsNeedToChange } from "../../../src/ui/formatNumber";
import { Server } from "../../../src/Server/Server";
import { RunningScript } from "../../../src/Script/RunningScript";
import { CompletedProgramName } from "../../../src/Programs/Enums";
import { WorkerScript } from "../../../src/Netscript/WorkerScript";
import { NetscriptFunctions } from "../../../src/NetscriptFunctions";
import { AddToAllServers, DeleteServer } from "../../../src/Server/AllServers";
import { initGameEnvironment, setupBasicTestingEnvironment } from "../Utilities";
import { Player } from "@player";
initGameEnvironment();
beforeEach(() => {
setupBasicTestingEnvironment();
});
test("Edge cases of disableLog", function () {
// Ensure that formatting functions work properly
FormatsNeedToChange.emit();
let server;
try {
server = new Server({ hostname: "home", adminRights: true, maxRam: 8 });
server.programs.push(CompletedProgramName.bruteSsh, CompletedProgramName.ftpCrack);
AddToAllServers(server);
// We don't need this script to be runnable, it just needs to exist so that
// we can create a RunningScript and WorkerScript object.
expect(server.writeToScriptFile("test.js" as ScriptFilePath, "")).toEqual({ overwritten: false });
const script = server.scripts.get("test.js" as ScriptFilePath) as Script;
const server = Player.getHomeComputer();
server.programs.push(CompletedProgramName.bruteSsh, CompletedProgramName.ftpCrack);
// We don't need this script to be runnable, it just needs to exist so that
// we can create a RunningScript and WorkerScript object.
expect(server.writeToScriptFile("test.js" as ScriptFilePath, "")).toEqual({ overwritten: false });
const script = server.scripts.get("test.js" as ScriptFilePath) as Script;
const runningScript = new RunningScript(script, 2);
const ws = new WorkerScript(runningScript, 1, NetscriptFunctions);
const runningScript = new RunningScript(script, 2);
const ws = new WorkerScript(runningScript, 1, NetscriptFunctions);
const ns = ws.env.vars;
if (!ns) {
throw new Error("Invalid ws.env.vars");
}
// Generate logs in a specific pattern that checks edge cases in
// disableLog. We want to check various combinations of things that
// are/aren't disabled, as well as previously disabled.
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("before disableLog ALL");
expect(() => ns.disableLog("all")).toThrow("Invalid argument: all.");
ns.disableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after disableLog ALL");
ns.enableLog("brutessh");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after enableLog brutessh");
ns.disableLog("brutessh");
ns.enableLog("ftpcrack");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after enableLog ftpcrack");
ns.enableLog("ftpcrack");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after redundant enable");
ns.disableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.enableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("end");
expect(runningScript.logs).toEqual([
"brutessh: Executed BruteSSH.exe on 'home' to open SSH port (22).",
"ftpcrack: Executed FTPCrack.exe on 'home' to open FTP port (21).",
"before disableLog ALL",
"disableLog: Invalid argument: all.",
"after disableLog ALL",
"brutessh: SSH Port (22) already opened on 'home'.",
"after enableLog brutessh",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"after enableLog ftpcrack",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"after redundant enable",
"enableLog: Enabled logging for all functions",
"brutessh: SSH Port (22) already opened on 'home'.",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"end",
]);
} finally {
if (server) {
DeleteServer(server.hostname);
}
const ns = ws.env.vars;
if (!ns) {
throw new Error("Invalid ws.env.vars");
}
// Generate logs in a specific pattern that checks edge cases in
// disableLog. We want to check various combinations of things that
// are/aren't disabled, as well as previously disabled.
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("before disableLog ALL");
expect(() => ns.disableLog("all")).toThrow("Invalid argument: all.");
ns.disableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after disableLog ALL");
ns.enableLog("brutessh");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after enableLog brutessh");
ns.disableLog("brutessh");
ns.enableLog("ftpcrack");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after enableLog ftpcrack");
ns.enableLog("ftpcrack");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("after redundant enable");
ns.disableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.enableLog("ALL");
ns.brutessh("home");
ns.ftpcrack("home");
ns.print("end");
expect(runningScript.logs).toEqual([
"brutessh: Executed BruteSSH.exe on 'home' to open SSH port (22).",
"ftpcrack: Executed FTPCrack.exe on 'home' to open FTP port (21).",
"before disableLog ALL",
"disableLog: Invalid argument: all.",
"after disableLog ALL",
"brutessh: SSH Port (22) already opened on 'home'.",
"after enableLog brutessh",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"after enableLog ftpcrack",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"after redundant enable",
"enableLog: Enabled logging for all functions",
"brutessh: SSH Port (22) already opened on 'home'.",
"ftpcrack: FTP Port (21) already opened on 'home'.",
"end",
]);
});