mirror of
https://github.com/bitburner-official/bitburner-src.git
synced 2026-04-23 01:32:55 +02:00
MISC: Improve several things relating to PID lookups (#1594)
findRunningScriptByPid needlessly took a "server" argument. This caused there to be a "getRunningScriptByPid" version that did *not*, and it was looping through all servers in order to function, which is needlessly inefficient. By removing the parameter and the needless inefficient helper method, the following changes: - Many Netscript functions such as isRunning() and getScript() become faster. - The terminal "tail" command now works by pid regardless of the current server. Note that "kill" already worked this way. I also improved the docs around "tail", since the pid argument wasn't in the help.
This commit is contained in:
@@ -212,7 +212,7 @@ function LogWindow({ hidden, script, onClose }: LogWindowProps): React.ReactElem
|
||||
function run(): void {
|
||||
const server = GetServer(script.server);
|
||||
if (server === null) return;
|
||||
const s = findRunningScriptByPid(script.pid, server);
|
||||
const s = findRunningScriptByPid(script.pid);
|
||||
if (s === null) {
|
||||
const baseScript = server.scripts.get(script.filename);
|
||||
if (!baseScript) {
|
||||
|
||||
Reference in New Issue
Block a user