felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-17 23:08:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

BUGFIX: Some calculations return NaN due to Player.playtimeSinceLastAug being 0 in edge cases (#1985)

Browse Source
This commit is contained in:
catloversg
2025-03-02 00:06:58 +07:00
committed by GitHub
parent c0e01f304d
commit 4ef597bd37
4 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/NetscriptFunctions.ts
View File

@@ -1564,7 +1564,11 @@ export const ns: InternalAPI<NSFull> = {
total += script.scriptRef.onlineMoneyMade / script.scriptRef.onlineRunningTime; total += script.scriptRef.onlineMoneyMade / script.scriptRef.onlineRunningTime;
} }
return [total, Player.scriptProdSinceLastAug / (Player.playtimeSinceLastAug / 1000)]; let incomeFromScriptsSinceLastAug = Player.scriptProdSinceLastAug / (Player.playtimeSinceLastAug / 1000);
if (!Number.isFinite(incomeFromScriptsSinceLastAug)) {
incomeFromScriptsSinceLastAug = 0;
}
return [total, incomeFromScriptsSinceLastAug];
}, },
getScriptIncome: getScriptIncome:
(ctx) => (ctx) =>

5
src/Script/ScriptHelpers.ts
View File

@@ -58,8 +58,11 @@ export function scriptCalculateOfflineProduction(runningScript: RunningScript):
const expGain = confidence * (runningScript.onlineExpGained / runningScript.onlineRunningTime) * timePassed; const expGain = confidence * (runningScript.onlineExpGained / runningScript.onlineRunningTime) * timePassed;
Player.gainHackingExp(expGain); Player.gainHackingExp(expGain);
const moneyGain = let moneyGain =
(runningScript.onlineMoneyMade / Player.playtimeSinceLastAug) * timePassed * CONSTANTS.OfflineHackingIncome; (runningScript.onlineMoneyMade / Player.playtimeSinceLastAug) * timePassed * CONSTANTS.OfflineHackingIncome;
if (!Number.isFinite(moneyGain)) {
moneyGain = 0;
}
// money is given to player during engine load // money is given to player during engine load
Player.scriptProdSinceLastAug += moneyGain; Player.scriptProdSinceLastAug += moneyGain;

5
src/engine.tsx
View File

@@ -276,8 +276,11 @@ const Engine: {
tryGeneratingRandomContract(timeOffline / CONSTANTS.MillisecondsPerTenMinutes); tryGeneratingRandomContract(timeOffline / CONSTANTS.MillisecondsPerTenMinutes);
let offlineReputation = 0; let offlineReputation = 0;
const offlineHackingIncome = let offlineHackingIncome =
(Player.moneySourceA.hacking / Player.playtimeSinceLastAug) * timeOffline * CONSTANTS.OfflineHackingIncome; (Player.moneySourceA.hacking / Player.playtimeSinceLastAug) * timeOffline * CONSTANTS.OfflineHackingIncome;
if (!Number.isFinite(offlineHackingIncome)) {
offlineHackingIncome = 0;
}
Player.gainMoney(offlineHackingIncome, "hacking"); Player.gainMoney(offlineHackingIncome, "hacking");
// Process offline progress // Process offline progress

5
src/ui/ActiveScripts/ScriptProduction.tsx
View File

@@ -30,7 +30,10 @@ const useStyles = makeStyles()((theme: Theme) => ({
})); }));
export function ScriptProduction(): React.ReactElement { export function ScriptProduction(): React.ReactElement {
const { classes } = useStyles(); const { classes } = useStyles();
const prodRateSinceLastAug = Player.scriptProdSinceLastAug / (Player.playtimeSinceLastAug / 1000); let prodRateSinceLastAug = Player.scriptProdSinceLastAug / (Player.playtimeSinceLastAug / 1000);
if (!Number.isFinite(prodRateSinceLastAug)) {
prodRateSinceLastAug = 0;
}
return ( return (
<Table size="small" classes={{ root: classes.size }}> <Table size="small" classes={{ root: classes.size }}>