DNET: simplify getServer return type; add all missing dnet properties to getServerAuthDetails (#2746)

This commit is contained in:
Michael Ficocelli
2026-05-12 16:22:25 -07:00
committed by GitHub
parent 00f0756a59
commit 3acdf019f8
62 changed files with 784 additions and 1178 deletions
+19 -19
View File
@@ -211,9 +211,9 @@ describe("home", () => {
const ns = getNsOnHome();
expect(ns.getServer().hostname).toStrictEqual(SpecialServers.Home);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnHome();
expect(() => ns.dnet.getServerAuthDetails()).toThrow("home is not a darknet server");
expect(() => ns.dnet.getServerDetails()).toThrow("home is not a darknet server");
});
test("induceServerMigration", () => {
const ns = getNsOnHome();
@@ -375,9 +375,9 @@ describe("Normal NPC server", () => {
const ns = getNS(SpecialServers.CyberSecServer);
expect(ns.getServer().hostname).toStrictEqual(SpecialServers.CyberSecServer);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNS(SpecialServers.CyberSecServer);
expect(() => ns.dnet.getServerAuthDetails()).toThrow("CSEC is not a darknet server");
expect(() => ns.dnet.getServerDetails()).toThrow("CSEC is not a darknet server");
});
test("induceServerMigration", () => {
const ns = getNS(SpecialServers.CyberSecServer);
@@ -465,9 +465,9 @@ describe("Private server", () => {
const ns = getNS("test-server-1");
expect(ns.getServer().hostname).toStrictEqual("test-server-1");
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNS("test-server-1");
expect(() => ns.dnet.getServerAuthDetails()).toThrow("test-server-1 is not a darknet server");
expect(() => ns.dnet.getServerDetails()).toThrow("test-server-1 is not a darknet server");
});
test("induceServerMigration", () => {
const ns = getNS("test-server-1");
@@ -555,9 +555,9 @@ describe("Hashnet server", () => {
const ns = getNS("hacknet-server-0");
expect(ns.getServer().hostname).toStrictEqual("hacknet-server-0");
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNS("hacknet-server-0");
expect(() => ns.dnet.getServerAuthDetails()).toThrow("hacknet-server-0 is not a darknet server");
expect(() => ns.dnet.getServerDetails()).toThrow("hacknet-server-0 is not a darknet server");
});
test("induceServerMigration", () => {
const ns = getNS("hacknet-server-0");
@@ -639,9 +639,9 @@ describe("Non-existent server", () => {
ns.getServer(hostnameOfNonExistentServer);
}).toThrow(errorMessageForNonExistentServer);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnDarkWeb();
expect(() => ns.dnet.getServerAuthDetails(hostnameOfNonExistentServer)).toThrow(errorMessageForNonExistentServer);
expect(() => ns.dnet.getServerDetails(hostnameOfNonExistentServer)).toThrow(errorMessageForNonExistentServer);
});
test("induceServerMigration", () => {
const ns = getNsOnDarkWeb();
@@ -782,9 +782,9 @@ describe("darkweb", () => {
expect(server.isOnline).toStrictEqual(true);
expect(server.ip).toStrictEqual(getDarknetServerOrThrow(SpecialServers.DarkWeb).ip);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnDarkWeb();
const authDetails = ns.dnet.getServerAuthDetails();
const authDetails = ns.dnet.getServerDetails();
expect(authDetails.isOnline).toStrictEqual(true);
expect(authDetails.modelId).toStrictEqual(ModelIds.NoPassword);
});
@@ -935,9 +935,9 @@ describe("Non-darkweb darknet server", () => {
const server = ns.getServer();
expect(server.hostname).toStrictEqual(ns.getHostname());
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnNonDarkwebDarknetServer();
const authDetails = ns.dnet.getServerAuthDetails();
const authDetails = ns.dnet.getServerDetails();
expect(authDetails.modelId).toStrictEqual(getDarknetServerOrThrow(ns.getHostname()).modelId);
});
test("induceServerMigration targeting connected server", async () => {
@@ -1071,12 +1071,12 @@ describe("Offline darknet server", () => {
expect(server.hostname).toBe("");
expect(server.ip).toBe(ipForOfflineServer);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnDarkWeb();
let authDetails = ns.dnet.getServerAuthDetails(hostnameForOfflineServer);
let authDetails = ns.dnet.getServerDetails(hostnameForOfflineServer);
expect(authDetails.isOnline).toStrictEqual(false);
authDetails = ns.dnet.getServerAuthDetails(ipForOfflineServer);
authDetails = ns.dnet.getServerDetails(ipForOfflineServer);
expect(authDetails.isOnline).toStrictEqual(false);
});
test("induceServerMigration", async () => {
@@ -1174,9 +1174,9 @@ describe("Use IP instead of hostname", () => {
}
expect(server.ip).toStrictEqual(ip);
});
test("getServerAuthDetails", () => {
test("getServerDetails", () => {
const ns = getNsOnNonDarkwebDarknetServer();
const authDetails = ns.dnet.getServerAuthDetails(ip);
const authDetails = ns.dnet.getServerDetails(ip);
expect(authDetails.isOnline).toStrictEqual(true);
expect(authDetails.modelId).toStrictEqual(getDarknetServerOrThrow(ip).modelId);
});