felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-21 16:52:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

API: Allow passing 0 SkillPoints to skillMaxUpgradeCount (#1844)

Browse Source
This commit is contained in:
catloversg
2024-12-12 18:07:31 +07:00
committed by GitHub
parent 7c732689dd
commit 37ddb43b82
3 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NetscriptFunctions/Formulas.ts
+11 -4
View File
@@ -52,6 +52,7 @@ import { getEnumHelper } from "../utils/EnumHelper";
import { CompanyPositions } from "../Company/CompanyPositions";
import { findCrime } from "../Crime/CrimeHelpers";
import { Skills } from "../Bladeburner/data/Skills";
import type { PositiveNumber } from "../types";
export function NetscriptFormulas(): InternalAPI<IFormulas> {
const checkFormulasAccess = function (ctx: NetscriptContext): void {
@@ -433,15 +434,21 @@ export function NetscriptFormulas(): InternalAPI<IFormulas> {
checkFormulasAccess(ctx);
const name = getEnumHelper("BladeburnerSkillName").nsGetMember(ctx, _name, "name");
const level = helpers.number(ctx, "level", _level);
if (level < 0) {
throw new Error(`Level must be a non-negative number.`);
if (!Number.isFinite(level) || level < 0) {
throw new Error(`Level must be a finite, non-negative number. Its value is ${level}.`);
}
const skillPoints = helpers.number(ctx, "skillPoints", _skillPoints);
if (!Number.isFinite(skillPoints) || skillPoints < 0) {
throw new Error(`SkillPoints must be a finite, non-negative number. Its value is ${skillPoints}.`);
}
const skillPoints = helpers.positiveNumber(ctx, "skillPoints", _skillPoints);
const skill = Skills[name];
if (level >= skill.maxLvl) {
return 0;
}
return skill.calculateMaxUpgradeCount(level, skillPoints);
if (skillPoints === 0) {
return 0;
}
return skill.calculateMaxUpgradeCount(level, skillPoints as PositiveNumber);
},
},
};