felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-19 07:48:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

MISC: Enforce stricter param check on ns.getBitNodeMultipliers and ns.hacknet.spendHashes (#2085)

Browse Source
This commit is contained in:
catloversg
2025-04-15 06:20:36 +07:00
committed by GitHub
parent 44b8baa8ad
commit 31e6e4d74b
4 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/NetscriptFunctions.ts
+4 -12
View File
@@ -330,7 +330,7 @@ export const ns: InternalAPI<NSFull> = {
(_host, _multiplier, _cores = 1) => {
const host = helpers.string(ctx, "hostname", _host);
const mult = helpers.number(ctx, "multiplier", _multiplier);
const cores = helpers.number(ctx, "cores", _cores);
const cores = helpers.positiveInteger(ctx, "cores", _cores);
// Check argument validity
const server = helpers.getServer(ctx, host);
@@ -339,13 +339,9 @@ export const ns: InternalAPI<NSFull> = {
helpers.log(ctx, () => `${host} is not a hackable server. Returning 0.`);
return 0;
}
if (mult < 1 || !isFinite(mult)) {
if (!Number.isFinite(mult) || mult < 1) {
throw helpers.errorMessage(ctx, `Invalid argument: multiplier must be finite and >= 1, is ${mult}.`);
}
// TODO 2.3: Add assertion function for positive integer, there are a lot of places everywhere that can use this
if (!Number.isInteger(cores) || cores < 1) {
throw helpers.errorMessage(ctx, `Cores should be a positive integer. Cores provided: ${cores}`);
}
return numCycleForGrowth(server, mult, cores);
},
@@ -986,15 +982,11 @@ export const ns: InternalAPI<NSFull> = {
if (!canAccessBitNodeFeature(5)) {
throw helpers.errorMessage(ctx, "Requires Source-File 5 to run.");
}
// TODO v3.0: check n and lvl with helpers.number() and Number.isInteger().
const n = Math.round(helpers.number(ctx, "n", _n));
const lvl = Math.round(helpers.number(ctx, "lvl", _lvl));
const n = helpers.positiveInteger(ctx, "n", _n);
const lvl = helpers.positiveInteger(ctx, "lvl", _lvl);
if (!validBitNodes.includes(n)) {
throw new Error(`Invalid BitNode: ${n}.`);
}
if (lvl < 1) {
throw new Error("SF level must be greater than or equal to 1.");
}
return Object.assign({}, getBitNodeMultipliers(n, lvl));
},