felixfoertsch/bitburner-src
1
0
Fork 0
mirror of https://github.com/bitburner-official/bitburner-src.git synced 2026-04-18 23:38:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3055 from ApamNapat/simplified_some_boolean_logic

Browse Source 
Simplified some booleans and if elses
This commit is contained in:
hydroflame
2022-03-10 22:11:26 -05:00
committed by GitHub
parent 1ed27bb88a 0eced1b9f2
commit 31a26a31ad
10 changed files with 14 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/PersonObjects/Player/PlayerObjectGeneralMethods.tsx
View File

@@ -2004,18 +2004,13 @@ export function isQualified(this: IPlayer, company: Company, position: CompanyPo
const reqAgility = position.requiredDexterity > 0 ? position.requiredDexterity + offset : 0;
const reqCharisma = position.requiredCharisma > 0 ? position.requiredCharisma + offset : 0;
if (
this.hacking >= reqHacking &&
return this.hacking >= reqHacking &&
this.strength >= reqStrength &&
this.defense >= reqDefense &&
this.dexterity >= reqDexterity &&
this.agility >= reqAgility &&
this.charisma >= reqCharisma &&
company.playerReputation >= position.requiredReputation
) {
return true;
}
return false;
company.playerReputation >= position.requiredReputation;
}
/********** Reapplying Augmentations and Source File ***********/
@@ -2573,7 +2568,7 @@ export function queueAugmentation(this: IPlayer, name: string): void {
/************* Coding Contracts **************/
export function gainCodingContractReward(this: IPlayer, reward: ICodingContractReward, difficulty = 1): string {
if (reward == null || reward.type == null || reward == null) {
if (reward == null || reward.type == null) {
return `No reward for this contract`;
}