From 2cabb98095796fe6738fcc2c737fbda42dd15083 Mon Sep 17 00:00:00 2001 From: catloversg <152669316+catloversg@users.noreply.github.com> Date: Tue, 3 Jun 2025 15:21:59 +0700 Subject: [PATCH] API: Rename BN multiplier RepToDonateToFaction to FavorToDonateToFaction (#2178) --- ...ner.bitnodemultipliers.favortodonatetofaction.md} | 6 +++--- markdown/bitburner.bitnodemultipliers.md | 2 +- src/Achievements/Achievements.ts | 2 +- src/BitNode/BitNode.tsx | 6 +++--- src/BitNode/BitNodeMultipliers.ts | 2 +- src/BitNode/ui/BitnodeMultipliersDescription.tsx | 2 +- src/Documentation/pages.ts | 6 +++--- src/Faction/formulas/donation.ts | 2 +- src/NetscriptFunctions.ts | 2 +- src/ScriptEditor/NetscriptDefinitions.d.ts | 2 +- src/utils/APIBreaks/3.0.0.ts | 12 ++++++++++++ 11 files changed, 28 insertions(+), 16 deletions(-) rename markdown/{bitburner.bitnodemultipliers.reptodonatetofaction.md => bitburner.bitnodemultipliers.favortodonatetofaction.md} (56%) diff --git a/markdown/bitburner.bitnodemultipliers.reptodonatetofaction.md b/markdown/bitburner.bitnodemultipliers.favortodonatetofaction.md similarity index 56% rename from markdown/bitburner.bitnodemultipliers.reptodonatetofaction.md rename to markdown/bitburner.bitnodemultipliers.favortodonatetofaction.md index acbed2524..ca50ff0ea 100644 --- a/markdown/bitburner.bitnodemultipliers.reptodonatetofaction.md +++ b/markdown/bitburner.bitnodemultipliers.favortodonatetofaction.md @@ -1,13 +1,13 @@ -[Home](./index.md) > [bitburner](./bitburner.md) > [BitNodeMultipliers](./bitburner.bitnodemultipliers.md) > [RepToDonateToFaction](./bitburner.bitnodemultipliers.reptodonatetofaction.md) +[Home](./index.md) > [bitburner](./bitburner.md) > [BitNodeMultipliers](./bitburner.bitnodemultipliers.md) > [FavorToDonateToFaction](./bitburner.bitnodemultipliers.favortodonatetofaction.md) -## BitNodeMultipliers.RepToDonateToFaction property +## BitNodeMultipliers.FavorToDonateToFaction property Influences the minimum favor the player must have with a faction before they can donate to gain rep. **Signature:** ```typescript -RepToDonateToFaction: number; +FavorToDonateToFaction: number; ``` diff --git a/markdown/bitburner.bitnodemultipliers.md b/markdown/bitburner.bitnodemultipliers.md index 01d5b8afe..78b494c2c 100644 --- a/markdown/bitburner.bitnodemultipliers.md +++ b/markdown/bitburner.bitnodemultipliers.md @@ -39,6 +39,7 @@ interface BitNodeMultipliers | [FactionPassiveRepGain](./bitburner.bitnodemultipliers.factionpassiverepgain.md) | | number | Influences how much rep the player gains in each faction simply by being a member. | | [FactionWorkExpGain](./bitburner.bitnodemultipliers.factionworkexpgain.md) | | number | Influences the experience gained for each ability when the player completes work for a Faction. | | [FactionWorkRepGain](./bitburner.bitnodemultipliers.factionworkrepgain.md) | | number | Influences how much rep the player gains when performing work for a faction or donating to it. | +| [FavorToDonateToFaction](./bitburner.bitnodemultipliers.favortodonatetofaction.md) | | number | Influences the minimum favor the player must have with a faction before they can donate to gain rep. | | [FourSigmaMarketDataApiCost](./bitburner.bitnodemultipliers.foursigmamarketdataapicost.md) | | number | Influences how much it costs to unlock the stock market's 4S Market Data API | | [FourSigmaMarketDataCost](./bitburner.bitnodemultipliers.foursigmamarketdatacost.md) | | number | Influences how much it costs to unlock the stock market's 4S Market Data (NOT API) | | [GangSoftcap](./bitburner.bitnodemultipliers.gangsoftcap.md) | | number | Influences the respect gain and money gain of your gang. | @@ -56,7 +57,6 @@ interface BitNodeMultipliers | [PurchasedServerLimit](./bitburner.bitnodemultipliers.purchasedserverlimit.md) | | number | Influences the maximum number of purchased servers you can have | | [PurchasedServerMaxRam](./bitburner.bitnodemultipliers.purchasedservermaxram.md) | | number | Influences the maximum allowed RAM for a purchased server | | [PurchasedServerSoftcap](./bitburner.bitnodemultipliers.purchasedserversoftcap.md) | | number | Influence how much it costs to purchase a server | -| [RepToDonateToFaction](./bitburner.bitnodemultipliers.reptodonatetofaction.md) | | number | Influences the minimum favor the player must have with a faction before they can donate to gain rep. | | [ScriptHackMoney](./bitburner.bitnodemultipliers.scripthackmoney.md) | | number | Influences how much money is stolen from a server when the player performs a hack against it. | | [ScriptHackMoneyGain](./bitburner.bitnodemultipliers.scripthackmoneygain.md) | | number | Influences how much money the player actually gains when a script hacks a server. This is different from ScriptHackMoney. When a script hacks a server, the amount of money in that server is reduced, but the player does not gain that same amount. | | [ServerGrowthRate](./bitburner.bitnodemultipliers.servergrowthrate.md) | | number | Influences the growth percentage per cycle against a server. | diff --git a/src/Achievements/Achievements.ts b/src/Achievements/Achievements.ts index e11c15f5e..6d51463b6 100644 --- a/src/Achievements/Achievements.ts +++ b/src/Achievements/Achievements.ts @@ -347,7 +347,7 @@ export const achievements: Record = { Icon: "donation", Condition: () => Object.values(Factions).some( - (f) => f.favor >= Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction), + (f) => f.favor >= Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.FavorToDonateToFaction), ), }, TRAVEL: { diff --git a/src/BitNode/BitNode.tsx b/src/BitNode/BitNode.tsx index c5774e900..4b427940c 100644 --- a/src/BitNode/BitNode.tsx +++ b/src/BitNode/BitNode.tsx @@ -592,7 +592,7 @@ export function getBitNodeMultipliers(n: number, lvl: number): BitNodeMultiplier HacknetNodeMoney: 0.25, ScriptHackMoney: 0.2, - RepToDonateToFaction: 0.5, + FavorToDonateToFaction: 0.5, AugmentationMoneyCost: 3, AugmentationRepCost: 3, @@ -751,7 +751,7 @@ export function getBitNodeMultipliers(n: number, lvl: number): BitNodeMultiplier ScriptHackMoneyGain: 0, CodingContractMoney: 0, - RepToDonateToFaction: 0, + FavorToDonateToFaction: 0, InfiltrationMoney: 0, @@ -930,7 +930,7 @@ export function getBitNodeMultipliers(n: number, lvl: number): BitNodeMultiplier FactionPassiveRepGain: dec, FactionWorkRepGain: dec, - RepToDonateToFaction: inc, + FavorToDonateToFaction: inc, AugmentationMoneyCost: inc, AugmentationRepCost: inc, diff --git a/src/BitNode/BitNodeMultipliers.ts b/src/BitNode/BitNodeMultipliers.ts index 10a07b6c9..758cafb89 100644 --- a/src/BitNode/BitNodeMultipliers.ts +++ b/src/BitNode/BitNodeMultipliers.ts @@ -134,7 +134,7 @@ export class BitNodeMultipliers { PurchasedServerMaxRam = 1; /** Influences the minimum favor the player must have with a faction before they can donate to gain rep. */ - RepToDonateToFaction = 1; + FavorToDonateToFaction = 1; /** Influences how much money is stolen from a server when the player performs a hack against it. */ ScriptHackMoney = 1; diff --git a/src/BitNode/ui/BitnodeMultipliersDescription.tsx b/src/BitNode/ui/BitnodeMultipliersDescription.tsx index 7b622a9b5..214bfd97a 100644 --- a/src/BitNode/ui/BitnodeMultipliersDescription.tsx +++ b/src/BitNode/ui/BitnodeMultipliersDescription.tsx @@ -195,7 +195,7 @@ function StockMults({ mults }: IMultsProps): React.ReactElement { function FactionMults({ mults }: IMultsProps): React.ReactElement { const rows: IBNMultRows = { - RepToDonateToFaction: { name: "Favor to Donate" }, + FavorToDonateToFaction: { name: "Favor to Donate" }, FactionWorkRepGain: { name: "Work Reputation", color: Settings.theme.rep, diff --git a/src/Documentation/pages.ts b/src/Documentation/pages.ts index 005f50a72..cd550447c 100644 --- a/src/Documentation/pages.ts +++ b/src/Documentation/pages.ts @@ -122,6 +122,7 @@ import nsDoc_bitburner_bitnodemultipliers_dexteritylevelmultiplier_md from "../. import nsDoc_bitburner_bitnodemultipliers_factionpassiverepgain_md from "../../markdown/bitburner.bitnodemultipliers.factionpassiverepgain.md?raw"; import nsDoc_bitburner_bitnodemultipliers_factionworkexpgain_md from "../../markdown/bitburner.bitnodemultipliers.factionworkexpgain.md?raw"; import nsDoc_bitburner_bitnodemultipliers_factionworkrepgain_md from "../../markdown/bitburner.bitnodemultipliers.factionworkrepgain.md?raw"; +import nsDoc_bitburner_bitnodemultipliers_favortodonatetofaction_md from "../../markdown/bitburner.bitnodemultipliers.favortodonatetofaction.md?raw"; import nsDoc_bitburner_bitnodemultipliers_foursigmamarketdataapicost_md from "../../markdown/bitburner.bitnodemultipliers.foursigmamarketdataapicost.md?raw"; import nsDoc_bitburner_bitnodemultipliers_foursigmamarketdatacost_md from "../../markdown/bitburner.bitnodemultipliers.foursigmamarketdatacost.md?raw"; import nsDoc_bitburner_bitnodemultipliers_gangsoftcap_md from "../../markdown/bitburner.bitnodemultipliers.gangsoftcap.md?raw"; @@ -140,7 +141,6 @@ import nsDoc_bitburner_bitnodemultipliers_purchasedservercost_md from "../../mar import nsDoc_bitburner_bitnodemultipliers_purchasedserverlimit_md from "../../markdown/bitburner.bitnodemultipliers.purchasedserverlimit.md?raw"; import nsDoc_bitburner_bitnodemultipliers_purchasedservermaxram_md from "../../markdown/bitburner.bitnodemultipliers.purchasedservermaxram.md?raw"; import nsDoc_bitburner_bitnodemultipliers_purchasedserversoftcap_md from "../../markdown/bitburner.bitnodemultipliers.purchasedserversoftcap.md?raw"; -import nsDoc_bitburner_bitnodemultipliers_reptodonatetofaction_md from "../../markdown/bitburner.bitnodemultipliers.reptodonatetofaction.md?raw"; import nsDoc_bitburner_bitnodemultipliers_scripthackmoney_md from "../../markdown/bitburner.bitnodemultipliers.scripthackmoney.md?raw"; import nsDoc_bitburner_bitnodemultipliers_scripthackmoneygain_md from "../../markdown/bitburner.bitnodemultipliers.scripthackmoneygain.md?raw"; import nsDoc_bitburner_bitnodemultipliers_servergrowthrate_md from "../../markdown/bitburner.bitnodemultipliers.servergrowthrate.md?raw"; @@ -1642,6 +1642,8 @@ AllPages["nsDoc/bitburner.bitnodemultipliers.factionworkexpgain.md"] = nsDoc_bitburner_bitnodemultipliers_factionworkexpgain_md; AllPages["nsDoc/bitburner.bitnodemultipliers.factionworkrepgain.md"] = nsDoc_bitburner_bitnodemultipliers_factionworkrepgain_md; +AllPages["nsDoc/bitburner.bitnodemultipliers.favortodonatetofaction.md"] = + nsDoc_bitburner_bitnodemultipliers_favortodonatetofaction_md; AllPages["nsDoc/bitburner.bitnodemultipliers.foursigmamarketdataapicost.md"] = nsDoc_bitburner_bitnodemultipliers_foursigmamarketdataapicost_md; AllPages["nsDoc/bitburner.bitnodemultipliers.foursigmamarketdatacost.md"] = @@ -1673,8 +1675,6 @@ AllPages["nsDoc/bitburner.bitnodemultipliers.purchasedservermaxram.md"] = nsDoc_bitburner_bitnodemultipliers_purchasedservermaxram_md; AllPages["nsDoc/bitburner.bitnodemultipliers.purchasedserversoftcap.md"] = nsDoc_bitburner_bitnodemultipliers_purchasedserversoftcap_md; -AllPages["nsDoc/bitburner.bitnodemultipliers.reptodonatetofaction.md"] = - nsDoc_bitburner_bitnodemultipliers_reptodonatetofaction_md; AllPages["nsDoc/bitburner.bitnodemultipliers.scripthackmoney.md"] = nsDoc_bitburner_bitnodemultipliers_scripthackmoney_md; AllPages["nsDoc/bitburner.bitnodemultipliers.scripthackmoneygain.md"] = diff --git a/src/Faction/formulas/donation.ts b/src/Faction/formulas/donation.ts index 7cd1991d6..4a596a066 100644 --- a/src/Faction/formulas/donation.ts +++ b/src/Faction/formulas/donation.ts @@ -14,7 +14,7 @@ export function donationForRep(rep: number, person: IPerson): number { } export function favorNeededToDonate(): number { - return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction); + return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.FavorToDonateToFaction); } export function canDonate(amt: number): boolean { diff --git a/src/NetscriptFunctions.ts b/src/NetscriptFunctions.ts index 3d292e73d..f6a768d1e 100644 --- a/src/NetscriptFunctions.ts +++ b/src/NetscriptFunctions.ts @@ -1687,7 +1687,7 @@ export const ns: InternalAPI = { return true; }, getFavorToDonate: () => () => { - return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.RepToDonateToFaction); + return Math.floor(CONSTANTS.BaseFavorToDonate * currentNodeMults.FavorToDonateToFaction); }, getPlayer: () => () => { const data = { diff --git a/src/ScriptEditor/NetscriptDefinitions.d.ts b/src/ScriptEditor/NetscriptDefinitions.d.ts index 6f5351e93..af1d07db4 100644 --- a/src/ScriptEditor/NetscriptDefinitions.d.ts +++ b/src/ScriptEditor/NetscriptDefinitions.d.ts @@ -746,7 +746,7 @@ interface BitNodeMultipliers { /** Influences the maximum allowed RAM for a purchased server */ PurchasedServerMaxRam: number; /** Influences the minimum favor the player must have with a faction before they can donate to gain rep. */ - RepToDonateToFaction: number; + FavorToDonateToFaction: number; /** Influences how much money is stolen from a server when the player performs a hack against it. */ ScriptHackMoney: number; /** diff --git a/src/utils/APIBreaks/3.0.0.ts b/src/utils/APIBreaks/3.0.0.ts index 3b8679617..936ea9742 100644 --- a/src/utils/APIBreaks/3.0.0.ts +++ b/src/utils/APIBreaks/3.0.0.ts @@ -179,5 +179,17 @@ export const breakingChanges300: VersionBreakingChange = { 'It has been automatically replaced with "ns.stock.has4SDataTixApi()".', showPopUp: false, }, + { + brokenAPIs: [ + { + name: "ns.getBitNodeMultipliers().RepToDonateToFaction", + migration: { searchValue: "RepToDonateToFaction", replaceValue: "FavorToDonateToFaction" }, + }, + ], + info: + "ns.getBitNodeMultipliers().RepToDonateToFaction was removed.\n" + + 'It has been automatically replaced with "ns.getBitNodeMultipliers().FavorToDonateToFaction".', + showPopUp: false, + }, ], };