Simplified some booleans and if elses

This commit is contained in:
BB
2022-03-01 20:37:47 +01:00
parent 570b8caf78
commit 0eced1b9f2
10 changed files with 15 additions and 48 deletions

View File

@@ -2002,18 +2002,13 @@ export function isQualified(this: IPlayer, company: Company, position: CompanyPo
const reqAgility = position.requiredDexterity > 0 ? position.requiredDexterity + offset : 0;
const reqCharisma = position.requiredCharisma > 0 ? position.requiredCharisma + offset : 0;
if (
this.hacking >= reqHacking &&
return this.hacking >= reqHacking &&
this.strength >= reqStrength &&
this.defense >= reqDefense &&
this.dexterity >= reqDexterity &&
this.agility >= reqAgility &&
this.charisma >= reqCharisma &&
company.playerReputation >= position.requiredReputation
) {
return true;
}
return false;
company.playerReputation >= position.requiredReputation;
}
/********** Reapplying Augmentations and Source File ***********/
@@ -2571,7 +2566,7 @@ export function queueAugmentation(this: IPlayer, name: string): void {
/************* Coding Contracts **************/
export function gainCodingContractReward(this: IPlayer, reward: ICodingContractReward, difficulty = 1): string {
if (reward == null || reward.type == null || reward == null) {
if (reward == null || reward.type == null) {
return `No reward for this contract`;
}